Commits · 34bf31ea8a027f8d43958ec6d79ecedc3a8188d4 · github.com / v8-riscv / node

Jan 15, 2017

util: improve readability of normalizeEncoding · 34bf31ea

Joyee Cheung authored Dec 25, 2016

* Improve readability of util.normalizeEncoding
  and add some comments
* Add a benchmark for util.normalizeEncoding

PR-URL: https://github.com/nodejs/node/pull/10439


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

34bf31ea

benchmark: improve WHATWG URL benchmarks · d4b749b6

Joyee Cheung authored Jan 11, 2017

* add benchmark to compare the performance of getting url
  properties between the WHATWG URL and the legacy implementation
* add benchmark to compare the performance of serializing urls
  between the WHATWG URL and the legacy implementation
* refactor the benchmark for comparing parsing performance
  between the two implementations

PR-URL: https://github.com/nodejs/node/pull/10678


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>

d4b749b6

test,net: add tests for server.connections · 97f001ab

Rich Trott authored Jan 11, 2017

There were no tests confirming situations where server.connections
should return `null`. Add a test for that situation.

Expand existing server.connection test slightly to check value.

Refactor (mostly spacing) code for server.connections setter.

PR-URL: https://github.com/nodejs/node/pull/10762


Reviewed-By: James M Snell <jasnell@gmail.com>

97f001ab

Revert "fs: ensure readFile[Sync] reads from the beginning" · 66f09be7

Sakthipriyan Vairamani (thefourtheye) authored Jan 15, 2017

This reverts commit 4444e731.

PR-URL: https://github.com/nodejs/node/pull/10809


Reviewed-By: Anna Henningsen <anna@addaleax.net>

66f09be7

fs: ensure readFile[Sync] reads from the beginning · 4444e731

Nikolai Vavilov authored Jan 14, 2017

It would previously read from the current file position, which can be
non-zero if the `fd` has been read from or written to. This contradicts
the documentation which states that it "reads the entire contents of a
file".

PR-URL: https://github.com/nodejs/node/pull/9699
Fixes: https://github.com/nodejs/node/issues/9671


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

4444e731

Jan 14, 2017

benchmark: use "confidence" in output of compare.R · f18b4632

Joyee Cheung authored Jan 11, 2017

Use the word "confidence" to indicate the confidence level of
the p value so it's easier to understand.
With this change more stars in the output of compare.R means
higher confidence level (lower significance level).

PR-URL: https://github.com/nodejs/node/pull/10737
Refs: https://github.com/nodejs/node/pull/10439


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>

f18b4632

cluster: refactor module into multiple files · 2f885e7a

cjihrig authored Jan 11, 2017

This commit splits the existing cluster module into several
internal modules. More specifically, the cluster master and
worker implementations are separated, and the various data
structures are separated.

PR-URL: https://github.com/nodejs/node/pull/10746


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>

2f885e7a

test: add http.ClientRequest defaults test · 57e2ec43

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

57e2ec43

benchmark: add ClientRequest creation benchmark · c5d0fd96

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

c5d0fd96

http: misc ClientRequest cleanup · 2f775964

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

2f775964

http: avoid duplicate isArray() · 15c6187a

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

15c6187a

http: optimize default method case · dab22b5b

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

dab22b5b

http: optimize short path validation · 5c2ef14f

Brian White authored Jan 06, 2017

PR-URL: https://github.com/nodejs/node/pull/10654


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>

5c2ef14f

test: check error msg test-writeint.js · 6782577e

Irene Li authored Jan 11, 2017

PR-URL: https://github.com/nodejs/node/pull/10755


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

6782577e

lib: refactor bootstrap_node.js regular expression · 20efbffa

Rich Trott authored Jan 11, 2017

* use `+` instead of `*` where one-or-more is required
* switch from String.prototype.match() to RegExp.prototype.test()

PR-URL: https://github.com/nodejs/node/pull/10749


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>

20efbffa

doc: remove duplicate properties bullet in readme · 4424e847

Javis Sullivan authored Jan 11, 2017

PR-URL: https://github.com/nodejs/node/pull/10741


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

4424e847

test: no unused args test-fs-watch-file.js · 19917ee4

istinson authored Jan 11, 2017

PR-URL: https://github.com/nodejs/node/pull/10758


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

19917ee4

test: improve the code in test-crypto-dh · 5520e40a

Adrian Estrada authored Jan 12, 2017

* validate the errors for all assert.throws
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10734


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

5520e40a

test: improve tests in pummel/test-exec · a2af61af

Chase Starr authored Jan 11, 2017

* add asset.strictEqual to stdout and stderr. Fixes no-unused-vars.
* replace double quotes with single

PR-URL: https://github.com/nodejs/node/pull/10757


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

a2af61af

Jan 13, 2017

readline: refactor construct Interface · dad98bfe

Jackson Tian authored Jan 18, 2016

Remove the dependency on the arguments.length.

PR-URL: https://github.com/nodejs/node/pull/4740


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

dad98bfe

test: fix temp-dir option in tools/test.py · 57f6a106

Gibson Fahnestock authored Jan 10, 2017

If a temp-dir is specified and already exists, the NODE_TEST_DIR
environment variable will never be set. This fixes that.

PR-URL: https://github.com/nodejs/node/pull/10723


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

57f6a106

test: use realpath for NODE_TEST_DIR in common.js · dd2d3d3f

Gibson Fahnestock authored Jan 10, 2017

If you don't specify NODE_TEST_DIR, common.tmpDir will resolve to the
realpath of `node/test`.

If you do specify NODE_TEST_DIR (with the environment variable or by
running or by running tools/test.py --test-dir=x), common.tmpDir (which
is resolved from testRoot) uses the symbolic path (doesn't resolve
symlinks). This uses fs.realpathSync() to fix that.

PR-URL: https://github.com/nodejs/node/pull/10723


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

dd2d3d3f

test: fix linting for test-tls-add-ca-cert.js · 822bbe0b

Sam Roberts authored Jan 12, 2017

Fix lint error introduced in ea72331a

PR-URL: https://github.com/nodejs/node/pull/10771


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

822bbe0b

eslint: remove dangling eslint symlink · 0c8cfd4e

Sam Roberts authored Jan 12, 2017

Reapplication of https://github.com/nodejs/node/pull/9299 since the
symlink was re-added in f44969a5.

PR-URL: https://github.com/nodejs/node/pull/10771


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

0c8cfd4e

test: getgroups() may contain duplicate GIDs · 9271a412

Sam Roberts authored Dec 21, 2016

Some systems may have multiple group names with the same group ID, in
which case getgroups() returns duplicate values, where `id -G` will
filter the duplicates. Unique and sort the arrays so they can be
compared.

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

9271a412

doc,test: tls .ca option supports multi-PEM files · 84a23c72

Sam Roberts authored Dec 21, 2016

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

84a23c72

test: tls cert chain completion scenarios · 733c4a81

Sam Roberts authored Dec 20, 2016

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

733c4a81

doc: use correct tls certificate property name · f9665280

Sam Roberts authored Dec 20, 2016

Docs referred to an `issuer` property being optionally present, when it
should have referred to the `issuerCertificate` property.

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

f9665280

test: check tls server verification with addCACert · ea72331a

Sam Roberts authored Dec 20, 2016

SecureContext.addCACert() adds to the existing root store,
preserving root cert entries. option.ca is applied without
calling SecureContext.addRootCerts() so should add to
the default, empty, root store.

This test confirms that the built-in root CAs are not included
when options.ca is used.

Based on:

https://github.com/shigeki/node/commit/acd5837fd737351dd953b0387695705067cd69cb

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

ea72331a

test: move common tls connect setup into fixtures · 99b0c2e7

Sam Roberts authored Dec 17, 2016

TLS connection setup boilerplate is common to many TLS tests, factor it
into a test fixture so tests are clearer to read and faster to write.

PR-URL: https://github.com/nodejs/node/pull/10389


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

99b0c2e7

doc: update writable.write return value · 7f20c8a3

Nathan Phillip Brink authored Jan 03, 2017

Fix the explanation which stated that write() would return false if
highWaterMark is exceeded to correctly state that false is returned
once highWaterMark is reached. See #9247.

PR-URL: https://github.com/nodejs/node/pull/10582


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

7f20c8a3

benchmark: don't lint autogenerated modules · c001d2aa

Brian White authored Jan 11, 2017

PR-URL: https://github.com/nodejs/node/pull/10756


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

c001d2aa

test: improve test stream transform constructor · 537d7bd9

Adrian Estrada authored Jan 08, 2017

* new test for the error when a transform function is not specified
* use let instead of var
* use assert.strictEqual instead of assert.equal
* use arrow functions

PR-URL: https://github.com/nodejs/node/pull/10699


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

537d7bd9

Jan 12, 2017

deps: upgrade libuv to 1.10.2 · 74fb8a29

cjihrig authored Jan 09, 2017

Refs: https://github.com/nodejs/node/issues/9439
Fixes: https://github.com/nodejs/node/issues/9464
Fixes: https://github.com/nodejs/node/issues/9690
PR-URL: https://github.com/nodejs/node/pull/10717


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>

74fb8a29

test: move resource intensive test to sequential · d3eca025

Rich Trott authored Jan 11, 2017

test-fs-readfile-tostring-fail is resource-intensive and is flaky in
CI. Move to sequential tests so it is not competing for resources with
other tests.

PR-URL: https://github.com/nodejs/node/pull/10744
Fixes: https://github.com/nodejs/node/issues/10742


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

d3eca025

src: enable writev for pipe handles on Unix · d85d1205

Alexey Orlenko authored Jan 07, 2017

This commit enables writev for Unix Domain Sockets on supported
platforms thus enabling cork/uncork functionality for them and
improving IPC performance.

Fixes: https://github.com/nodejs/node/issues/5095
PR-URL: https://github.com/nodejs/node/pull/10677


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

d85d1205

doc: edit writing-tests.md · 0674789f

Rich Trott authored Jan 02, 2017

* Remove passive voice
* Remove unneeded modifiers
* Minor comma change

PR-URL: https://github.com/nodejs/node/pull/10585


Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

0674789f

doc: fix misleading language in vm docs · 8781e618

Alexey Orlenko authored Jan 09, 2017

The note following the http.Server example in the vm documentation
contains misleading language. This commit removes the incorrect
reference to threads.

Fixes: https://github.com/nodejs/node/issues/10697
PR-URL: https://github.com/nodejs/node/pull/10708


Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

8781e618

test: add test for noAssert option in buf.read*() · c8ed5f29

larissayvette authored Jan 05, 2017

PR-URL: https://github.com/nodejs/node/pull/10713


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

c8ed5f29

stream: avoid instanceof · 03b9f6fe

Brian White authored Dec 31, 2016

PR-URL: https://github.com/nodejs/node/pull/10558


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>

03b9f6fe