- Aug 04, 2016
-
-
vladimir authored
Classes cannot be instantiated without new, but util.deprecate() uses Function.prototype.apply(). This commit uses new.target to detect constructor calls, allowing classes to be deprecated. PR-URL: https://github.com/nodejs/node/pull/7690 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Сковорода Никита Андреевич authored
This splits one huge commit description into paragraphs, which supposedly was the intended behavior there. PR-URL: https://github.com/nodejs/node/pull/7727 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Сковорода Никита Андреевич authored
* Add language specification for the txt code blocks. * Move the definitions to the bottom. Ref: https://github.com/nodejs/node/pull/7727 PR-URL: https://github.com/nodejs/node/pull/7727 Reviewed-By:
-
Сковорода Никита Андреевич authored
This removes the extra two spaces indentation which was somewhy present in the iojs changelog from v1.8.1 to v3.3.1. iojs changelog was the only file affected. PR-URL: https://github.com/nodejs/node/pull/7727 Reviewed-By:
-
Сковорода Никита Андреевич authored
Continuing what a58b48bc did for the doc/ dir, this fixes some formatting issues in the *.md files that are placed directly in the top-level directory. README.md changes are excluded as they are covered by https://github.com/nodejs/node/pull/7971 Refs: https://github.com/nodejs/node/pull/7637 PR-URL: https://github.com/nodejs/node/pull/7727 Reviewed-By:
-
Сковорода Никита Андреевич authored
Convert all instances of tab indentation in *.md files to spaces. This affects only three files. PR-URL: https://github.com/nodejs/node/pull/7727 Reviewed-By:
-
James M Snell authored
piscisaureus has voluntarily stepped-down from the CTC PR-URL: https://github.com/nodejs/node/pull/7969 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com>
-
Anna Henningsen authored
Voted on and approved at CTC meeting https://github.com/nodejs/node/issues/7948 (2016-08-03). PR-URL: https://github.com/nodejs/node/pull/7966 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
James M Snell authored
As discussed and agreed upon by the CTC, the punycode module bundled in core is soft-deprecated (docs only) for v7 with an eye towards hard-deprecation in v8 or later. Also see discussion in https://github.com/nodejs/node/pull/7552 PR-URL: https://github.com/nodejs/node/pull/7941 Reviewed-By:
-
- Aug 03, 2016
-
-
João Reis authored
Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> PR-URL: https://github.com/nodejs/node/pull/7798
-
Ben Noordhuis authored
Depend on include/ares_rules.h, src/ares_rules.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: https://github.com/nodejs/node/pull/7945 Reviewed-By:
-
Ben Noordhuis authored
Depend on src/inspector_agent.h, src/inspector-agent.h does not exist. The typo didn't break the build but it made some of the gyp-based tooling complain. PR-URL: https://github.com/nodejs/node/pull/7945 Reviewed-By:
-
Franziska Hinkelmann authored
Original commit message: [regexp] Fix case-insensitive matching for one-byte subjects. The bug occurs because we do not canonicalize character class ranges before adding case equivalents. While adding case equivalents, we abort early for one-byte subject strings, assuming that the ranges are sorted. Which they are not. R=marja@chromium.org BUG=v8:5199 Review-Url: https://codereview.chromium.org/2159683002 Cr-Commit-Position: refs/heads/master@{#37833} Fixes: https://github.com/nodejs/node/issues/7708 PR-URL: https://github.com/nodejs/node/pull/7833 Reviewed-By:
ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
-
Rich Trott authored
A new version of ESLint flags chained properties on multiple lines that were not flagged by the previous version of ESLint. In preparation for turning that feature on, adjust alignment to that expected by the linter. This change happened to be predominantly around assertions using `assert()` and `assert.equal()`. These were changed to `assert.strictEqual()` where possible. PR-URL: https://github.com/nodejs/node/pull/7920 Reviewed-By:
-
- Aug 02, 2016
-
-
Santiago Gimeno authored
Set the `SIGUSR2` handler before spawning the child process to make sure the signal is always handled. Fixes: https://github.com/nodejs/node/issues/7767 PR-URL: https://github.com/nodejs/node/pull/7854 Reviewed-By:
-
Anna Henningsen authored
When SIMD is enabled, `util.format` couldn’t display objects (with at least 1 key) because the formatter function got overridden. PR-URL: https://github.com/nodejs/node/pull/7864 Reviewed-By:
-
Ben Noordhuis authored
uv_close() is an asynchronous operation. Calling it on a data member inside the destructor is unsound because its memory is about to be reclaimed but libuv is not done with it yet. PR-URL: https://github.com/nodejs/node/pull/7907 Reviewed-By:
Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By:
-
cjihrig authored
This commit allows setupMaster() to configure the stdio channels for worker processes. Refs: https://github.com/nodejs/node-v0.x-archive/issues/5727 Refs: https://github.com/nodejs/node/pull/7811 PR-URL: https://github.com/nodejs/node/pull/7838 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Josh Gavant authored
closes #7366 PR-URL: https://github.com/nodejs/node/pull/7390 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
-
Josh Gavant authored
PR-URL: https://github.com/nodejs/node/pull/7570 Reviewed-By:
-
Josh Gavant authored
PR-URL: https://github.com/nodejs/node/pull/7571 Reviewed-By:
-
Rich Trott authored
Add language identifying a request for voluntary resignation as the typical mechanism for addressing inactive CTC members. PR-URL: https://github.com/nodejs/node/pull/7720 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By:
Brian White <mscdex@mscdex.net> Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
-
Daniel Bevenius authored
Currently the build-addons target is called as part of the test target, and it has test/addons/.buildstamp as a dependency. When running ./configure --debug and later switching/ updating branches you can be in a situation where the config.gypi files in the addons build directories are using an incorrect value for default_configuration. Currently this can happen and you will get test errors as there are a few test that depend on the value of default_configuration to be Release. Ben Noordhuis provided the solution for this by adding a dependency to config.gypi, which is generated when running ./configure, and will correct this situation. This commit is related to #7860. Please see the dicussion in that issue regarding the test using hard-coded paths. PR-URL: https://github.com/nodejs/node/pull/7893 Reviewed-By:
-
William Kapke authored
PR-URL: https://github.com/nodejs/node/pull/7900 Reviewed-By:
-
Prince J Wesley authored
PR-URL: https://github.com/nodejs/node/pull/7927 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
- Aug 01, 2016
-
-
Joey Cozza authored
Single quotes in two of the examples were throwing off the formatting of the path documentation on the Node.js website. This commit expands two contractions to remove the offending quotes. PR-URL: https://github.com/nodejs/node/pull/7817 Reviewed-By:
-
Ben Noordhuis authored
Don't link binaries that run on the host system against liblog, it breaks cross-compiling for android. Fixes: https://github.com/nodejs/node/issues/7731 PR-URL: https://github.com/nodejs/node/pull/7762 Reviewed-By:
-
Ben Noordhuis authored
Make the inspector code easier to reason about by restructuring it to avoid manual memory allocation and copying as much as possible. An amusing side effect is that it reduces the total amount of memory used in the test suite. Before: $ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31- 1,017 allocs, 1,017 frees, 21,695,456 allocated After: $ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31- 869 allocs, 869 frees, 14,484,641 bytes allocated PR-URL: https://github.com/nodejs/node/pull/7906 Reviewed-By: -
Ben Noordhuis authored
The inspector tests weren't closing open libuv handles properly, making valgrind complain. Strengthen the uv_loop_close() check while here. With this commit applied: $ valgrind ./out/Release/cctest 2>&1 | grep 'total heap' | cut -c31- 1,017 allocs, 1,017 frees, 21,695,456 bytes allocated PR-URL: https://github.com/nodejs/node/pull/7906 Reviewed-By: -
Ravindra barthwal authored
PR-URL: https://github.com/nodejs/node/pull/7915 Reviewed-By:
Minwoo Jung <jmwsoft@gmail.com> Reviewed-By:
-
Vse Mozhet Byt authored
1. `process.env['PROCESSOR_ARCHITEW6432']` -> `process.env.PROCESSOR_ARCHITEW6432`. 2. `path.dirname(__filename)` -> `__dirname`. 3. `path.resolve(__dirname)` -> `__dirname`. PR-URL: https://github.com/nodejs/node/pull/7758 Reviewed-By:
-
Santiago Gimeno authored
On every platform but `Windows`. Also, print the crash information when using the tap reporter. PR-URL: https://github.com/nodejs/node/pull/7859 Reviewed-By:
-
Rich Trott authored
Competing timers were causing a race condition and thus the test was flaky. Instead, we check an object property on process exit. Fixes: https://github.com/nodejs/node/issues/7650 PR-URL: https://github.com/nodejs/node/pull/7857 Reviewed-By:
-
- Jul 30, 2016
-
-
Eugene Ostroukhov authored
Node process will no longer terminate with an assertion if the inspector port is not available. PR-URL: https://github.com/nodejs/node/pull/7874 Reviewed-By:
-
Erin Spiceland authored
For nested timers with the same timeout, we can get into a situation where we have recreated a timer list immediately before we need to clean up an old timer list with the same key. Fix: make sure the list to be deleted is the same instance as the list whose reference was used to determine that a cleanup is necessary. If it's not the same instance, a new list with the same key has been created, and it should not be deleted. Fixes: https://github.com/nodejs/node/issues/7722 PR-URL: https://github.com/nodejs/node/pull/7827 Reviewed-By:
Julien Gilli <jgilli@fastmail.fm>
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/7878 Reviewed-By:
-
Joe Esposito authored
PR-URL: https://github.com/nodejs/node/pull/7885 Reviewed-By:
-
- Jul 29, 2016
-
-
Rich Trott authored
The test takes 50 seconds on some of the project's Windows CI infrastructure. Reducing the test repetitions from 50 to 20 trims that to about 20 seconds. Tests will timeout at 60 seconds, so this helps keep the test reliable. (There was a timeout on CI today when testing an unrelated code change.) Refs: https://github.com/nodejs/node/pull/7827#issuecomment-235476222 PR-URL: https://github.com/nodejs/node/pull/7886 Reviewed-By:
-
Rich Trott authored
Provide example activities to better distinguish Collaborator activities from CTC member activities. PR-URL: https://github.com/nodejs/node/pull/7744 Reviewed-By:
-
Rich Trott authored
CTC quorum rules were not in writing. There was an informal understanding between CTC members. Document the rules to avoid differences in interpretation. PR-URL: https://github.com/nodejs/node/pull/7813 Reviewed-By:
-
