- Dec 16, 2017
-
-
Ben Noordhuis authored
Remove a pointless adapter frame by fixing up the function's formal parameter count. Before: frame #0: 0x000033257ea446d5 onParserExecute(...) frame #1: 0x000033257ea3b93f <adaptor> frame #2: 0x000033257ea41959 <internal> frame #3: 0x000033257e9840ff <entry> After: frame #0: 0x00000956287446d5 onParserExecute(...) frame #1: 0x0000095628741959 <internal> frame #2: 0x00000956286840ff <entry> PR-URL: https://github.com/nodejs/node/pull/17693 Reviewed-By:Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Matheus Marchini authored
Adds instructions on how to format C++ comments to the C++ style guide, as `cpplint.py` doesn't complain about C-style comments on the code. PR-URL: https://github.com/nodejs/node/pull/17617 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
-
Anna Henningsen authored
This is superfluous now that typechecking in `net` and `stream` are aligned. PR-URL: https://github.com/nodejs/node/pull/17644 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Jon Moss <me@jonathanmoss.me>
-
Anna Henningsen authored
`validChunk` allowed `undefined` as a chunk in object mode; however, this was redundant, since: - `validChunk()` is only used by `.write()` - If the `validChunk()` check passes for `undefined`, `.write()` calls `writeOrBuffer()` - If `writeOrBuffer()` does not receive a Buffer, it calls `decodeChunk()` - `decodeChunk()` ignores `undefined` because it checks `typeof chunk === 'string'` - After that call, `chunk.length` is accessed, which throws an error if `chunk` is undefined`. This “fixes” a bug in the sense that `state.pendingcb` is no longer incremented for write attempts that fail like this. PR-URL: https://github.com/nodejs/node/pull/17644 Reviewed-By: -
cjihrig authored
The function IsInt64() in src/node_file.cc is no longer used. This commit removes it. PR-URL: https://github.com/nodejs/node/pull/17671 Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Tyler authored
PR-URL: https://github.com/nodejs/node/pull/17609 Fixes: https://github.com/nodejs/node/issues/17605 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Ruben Bridgewater authored
assert.throws and assert.doesNotThrow set the operator to a internal function. That was by accident and originally the operator was undefined. This changes it to show "throws" or "doesNotThrow". PR-URL: https://github.com/nodejs/node/pull/17575 Reviewed-By:
-
Hakan Kimeiga authored
Percent-encoded additional characters in fragment state with new FRAGMENT_ENCODE_SET lookup table. The fragment percent-encode set includes the C0 control percent-encode set and code points U+0020, U+0022, U+003C, U+003E, and U+0060. PR-URL: https://github.com/nodejs/node/pull/17627 Fixes: https://github.com/nodejs/node/issues/17540 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/17653 Reviewed-By:
-
- Dec 15, 2017
-
-
Rich Trott authored
Allow zero results for short benchmark test. PR-URL: https://github.com/nodejs/node/pull/17686 Reviewed-By:
-
Bartosz Sosnowski authored
Fixes --with-intl option passed to configure script when without-intl is used PR-URL: https://github.com/nodejs/node/pull/17614 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Ben Noordhuis authored
Fix compiler warnings introduced in commit 47edfd9c ("crypto: move node_crypto_clienthello-inl.h to cc") by moving constructors around. They were defined inline but depended on definitions from `node_crypto_clienthello-inl.h`. PR-URL: https://github.com/nodejs/node/pull/17649 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Ben Noordhuis authored
Fix warnings introduced in commit 73ad3f9b ("inspector: Fix crash for WS connection"): * add missing `override` keywords * remove unused fields and functions PR-URL: https://github.com/nodejs/node/pull/17649 Reviewed-By:
-
Rich Trott authored
Remove string literals as messages to `assert.strictEqual()`. They can be misleading here (where perhaps the reason an assertino failed isn't that the deleter wasn't called but rather was called too many times. PR-URL: https://github.com/nodejs/node/pull/17642 Reviewed-By:
-
Mithun Sasidharan authored
Add a test that confirms that non-function arguments passed to util.promisify throw an ERR_INVALID_ARG_TYPE error. PR-URL: https://github.com/nodejs/node/pull/17591 Reviewed-By:
-
- Dec 14, 2017
-
-
Anatoli Papirovski authored
Refactor lib & src code to eliminate all deep reaches into the internal _events dictionary object, instead use available APIs and add an extra method to EventEmitter: rawListeners. PR-URL: https://github.com/nodejs/node/pull/17440 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Daniel Bevenius authored
Currently building test_inspector_socket.cc generates the following warning: ../test/cctest/test_inspector_socket.cc:189:8: warning: private field 'disposed_' is not used [-Wunused-private-field] bool disposed_ = false; ^ 1 warning generated. This commit removes this variable. PR-URL: https://github.com/nodejs/node/pull/17628 Reviewed-By: -
Evan Lucas authored
e8a26e78 added `process` to the internal module wrapper. This broke the utility used to write coverage information due to a SyntaxError that `process` had already been declared. PR-URL: https://github.com/nodejs/node/pull/17651 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/17652 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
James M Snell authored
The type is already checked in JS. Change to a CHECK PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
Refael Ackermann <refack@gmail.com> Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/17334 Reviewed-By:
-
- Dec 13, 2017
-
-
Anatoli Papirovski authored
Fix an issue where error is never emitted on the original EventEmitter in situations where a listener for error does exist. Refactor to eliminate unnecessary try/catch/finally block. PR-URL: https://github.com/nodejs/node/pull/17588 Refs: https://github.com/nodejs/node/pull/17403 Reviewed-By:
-
Daniel Bevenius authored
This commit updates node_crypto.h to just include node_crypto_clienthello.h instead of the inline header. Also node_crypto.cc is updated to include node_crypto_clienthello-inl.h. PR-URL: https://github.com/nodejs/node/pull/17606 Reviewed-By:
-
Anna Henningsen authored
Check that `serverConnectionHandle.writeQueueSize === 0` after a large write finished. PR-URL: https://github.com/nodejs/node/pull/17564 Reviewed-By:
-
Anna Henningsen authored
Instead of having per-request callbacks, always call a callback on the `StreamBase` instance itself for `WriteWrap` and `ShutdownWrap`. This makes `WriteWrap` cleanup consistent for all stream classes, since the after-write callback is always the same now. If special handling is needed for writes that happen to a sub-class, `AfterWrite` can be overridden by that class, rather than that class providing its own callback (e.g. updating the write queue size for libuv streams). If special handling is needed for writes that happen on another stream instance, the existing `after_write_cb()` callback is used for that (e.g. custom code after writing to the transport from a TLS stream). As a nice bonus, this also makes `WriteWrap` and `ShutdownWrap` instances slightly smaller. PR-URL: https://github.com/nodejs/node/pull/17564 Reviewed-By:
-
Anna Henningsen authored
This is not necessary since C++ already has `static_cast` as a proper way to cast inside a class hierarchy. PR-URL: https://github.com/nodejs/node/pull/17564 Reviewed-By:
-
Haejin Jo authored
PR-URL: https://github.com/nodejs/node/pull/17558 Fixes: https://github.com/nodejs/node/issues/17540 Reviewed-By:
-
Anna Henningsen authored
When the TLS stream is destroyed for whatever reason, we should unset all callbacks on the underlying transport stream. PR-URL: https://github.com/nodejs/node/pull/17478 Fixes: https://github.com/nodejs/node/issues/17475 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/17432 Fixes: https://github.com/nodejs/node/issues/17430 Reviewed-By:
-
Gus Caplan authored
PR-URL: https://github.com/nodejs/node/pull/17395 Reviewed-By:
-
Weijia Wang authored
Primitives should use lowercase in error message. Refs: https://github.com/nodejs/node/pull/16401 PR-URL: https://github.com/nodejs/node/pull/17568 Reviewed-By:
-
Jem Bezooyen authored
PR-URL: https://github.com/nodejs/node/pull/16042 Refs: https://github.com/nodejs/node/issues/1826 Reviewed-By:
-
