- Sep 06, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2685 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Ali Ijaz Sheikh authored
Pick up https://github.com/v8/v8-git-mirror/commit/f9a0a1636a4623a5522c33674e110b346d085340 Commit log at https://chromium.googlesource.com/v8/v8.git/+log/branch-heads/4.5 PR-URL: https://github.com/nodejs/node/pull/2632 Reviewed-By:
targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By:
rvagg - Rod Vagg <rod@vagg.org>
-
Michaël Zasso authored
Ref: https://github.com/nodejs/node/issues/1376 Ref: https://github.com/nodejs/node/pull/1398 Issue fixed in V8: https://chromium.googlesource.com/v8/v8/+/81703350bbb9923d211fe5b79e90bd458b0916e2 V8-Bug: https://code.google.com/p/v8/issues/detail?id=4019 PR-URL: https://github.com/nodejs/node/pull/2592 Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com>
-
Ali Ijaz Sheikh authored
The flag is no longer supported by V8 4.5, and the original issue [1] on ARMv6 no longer manifests with (at least) 4.5.103.20. [1] See https://code.google.com/p/v8/issues/detail?id=4338 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Michaël Zasso authored
v8::Handle is deprecated: https://codereview.chromium.org/1224623004 PR-URL: https://github.com/nodejs/io.js/pull/2202 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ben Noordhuis authored
Turn on V8 API deprecation warnings. Fix up the no-arg Isolate::New() calls in src/node.cc and src/debug-agent.cc. PR-URL: https://github.com/nodejs/io.js/pull/2091 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ali Ijaz Sheikh authored
The list of Array properties needed to be updated to match the new ones added in V8 4.5. PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Fedor Indutny authored
The `context_` is not initialized until the `CreateV8Context` will return. Make sure that it will be empty (by moving away initialization from constructor) at start, and ignore getter callbacks until it will have some value. PR-URL: https://github.com/nodejs/io.js/pull/2091 Reviewed-By:
Trevor Norris <trev.norris@gmail.com>
-
Ali Ijaz Sheikh authored
Apply the src/node_contextify.cc and lib/module.js fixups from @bnoordhuis https://github.com/nodejs/node/commit/41e63fb088a29fa05e16fb0d997255678134c043 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Ali Ijaz Sheikh authored
Upgrade to the latest branch-head for V8 4.5. For the full commit log see https://github.com/v8/v8-git-mirror/commits/4.5.103.24 PR-URL: https://github.com/nodejs/node/pull/2509 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Jeremiah Senkpiel authored
Now parts of our public and public-ish APIs fall back to old-style listenerCount() if the emitter does not have a listenerCount function. Fixes: https://github.com/nodejs/node/issues/2655 Refs: 8f58fb92 PR-URL: https://github.com/nodejs/node/pull/2661 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Karl Skomski authored
PR-URL: https://github.com/nodejs/node/pull/2376 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
James M Snell authored
Port of joyent/node commits: * https://github.com/nodejs/node-v0.x-archive/commit/e17c5a72b23f920f291d61f2780068c18768cb92 * https://github.com/nodejs/node-v0.x-archive/commit/70dafa7b624abd43432e03304d65cc527fbecc11 Pull over test-child-process-spawn-typeerror.js from v0.12, replacing the existing test in master. The new test includes a broader set of tests on the various arg choices and throws. Reviewed-By:
trevnorris - Trevor Norris <trevnorris@nodejs.org> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By: thefourtheye - Sakthipriyan Vairamani PR-URL: https://github.com/nodejs/node/pull/2667 Fixes: https://github.com/nodejs/node/issues/2515
-
Rich Trott authored
This retains the key elements of test-child-process-fork-getconnections (forks a child process, sends a bunch of sockets, uses getConnections() to enumerate them) but contains some code to work around an apparent intermittent bug that occurs on OS X where a socket seems to close itself unexpectedly. https://github.com/nodejs/node/issues/2610 was opened for the bug that was causing the problem in the first place. PR-URL: https://github.com/nodejs/node/pull/2609 Fixes: https://github.com/nodejs/node/issues/1100 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu> Reviewed-By:
Brendan Ashworth <brendan.ashworth@me.com>
-
Jeremiah Senkpiel authored
Fixes: https://github.com/nodejs/node/issues/2113 Ref: 17a379ec PR-URL: https://github.com/nodejs/node/pull/2605 Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
mscdex - Brian White <mscdex@mscdex.net>
-
Johan Bergström authored
Fixes: https://github.com/nodejs/node/issues/1972 PR-URL: https://github.com/nodejs/node/pull/2322 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Alexis Campailla authored
This test has failed recently during a PR test in Jenkins, for reasons seemingly not related to the change in the PR. PR-URL: https://github.com/nodejs/node/pull/2648 Reviewed-By:
evanlucas - Evan Lucas <evanlucas@me.com>
-
Ben Noordhuis authored
Add an optional callback parameter to `ChildProcess.prototype.send()` that is invoked when the message has been sent. Juggle the control channel's reference count so that in-flight messages keep the event loop (and therefore the process) alive until they have been sent. `ChildProcess.prototype.send()` and `process.send()` used to operate synchronously but became asynchronous in commit libuv/libuv@393c1c5 ("unix: set non-block mode in uv_{pipe,tcp,udp}_open"), which landed in io.js in commit 07bd05ba ("deps: update libuv to 1.2.1"). Fixes: https://github.com/nodejs/node/issues/760 PR-URL: https://github.com/nodejs/node/pull/2620 Reviewed-By:trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
jasnell - James M Snell <jasnell@gmail.com>
-
Karl Skomski authored
v8 will silently return an empty handle which doesn't delete our data if string length is above String::kMaxLength Fixes: https://github.com/nodejs/node/issues/1374 PR-URL: https://github.com/nodejs/node/pull/2402 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
indutny - Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Amended by @rvagg to change author date from "1970-08-16 16:09:02 +0200" to "2015-08-16 16:09:02 +0200" as per discussion @ https://github.com/nodejs/node/issues/2713
-
- Sep 03, 2015
-
-
João Reis authored
Ref: https://github.com/nodejs/node/issues/2660 PR-URL: https://github.com/nodejs/node/pull/2662 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org>
-
João Reis authored
This test is already being investigated, but until a solution is found it should be marked flaky. Ref: https://github.com/nodejs/node/issues/2319 Ref: https://github.com/nodejs/node/pull/2356 PR-URL: https://github.com/nodejs/node/pull/2659 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org>
-
saper authored
Note: chunk in test-heap.cc:1989 discarded as related code missing from current version in node. Original commit message: Use static_cast<> for NULL (clang 3.7) The following errors come up when compiling v8 with clang 3.7 on FreeBSD/amd64: src/runtime/runtime-i18n.cc:629:37: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Smi *' is not allowed local_object->SetInternalField(1, reinterpret_cast<Smi*>(NULL)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:131:20: error: reinterpret_cast from 'nullptr_t' to 'v8::internal::Object *' is not allowed Handle<Object> n(reinterpret_cast<Object*>(NULL), isolate); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test/cctest/test-heap.cc:1989:18: error: reinterpret_cast from 'nullptr_t' to 'Address' (aka 'unsigned char *') is not allowed Address base = reinterpret_cast<Address>(NULL); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ +add myself to the AUTHORS file. BUG= Review URL: https://codereview.chromium.org/1277353002 Cr-Commit-Position: refs/heads/master@{#30103} PR-URL: https://github.com/nodejs/node/pull/2636 Reviewed-By:thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
- Sep 02, 2015
-
-
Rod Vagg authored
Notable changes: * build: Add a --link-module option to configure that can be used to bundle additional JavaScript modules into a built binary (Bradley Meck) #2497 * docs: Merge outstanding doc updates from joyent/node (James M Snell) #2378 * http_parser: Significant performance improvement by having http.Server consume all initial data from its net.Socket and parsing directly without having to enter JavaScript. Any 'data' listeners on the net.Socket will result in the data being "unconsumed" into JavaScript, thereby undoing any performance gains. (Fedor Indutny) #2355 * libuv: Upgrade to 1.7.3 (from 1.6.1), see https://github.com/libuv/libuv/blob/v1.x/ChangeLog for details (Saúl Ibarra Corretgé) #2310 * V8: Upgrade to 4.4.63.30 (from 4.4.63.26) (Michaël Zasso) #2482 cherry-picked from v3.x @ 1a6e52db PR-URL: https://github.com/nodejs/node/pull/2653 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
Jeremiah Senkpiel authored
This commit addresses most of the review comments in https://github.com/nodejs/node/pull/2540, which are kept in this separate commit so as to better preserve the prior two patches as they landed in 0.12. This commit: - Fixes a bug with unrefActive timers and disposed domains. - Fixes a bug with unrolling an unrefActive timer from another. - Adds a test for both above bugs. - Improves check logic, making it stricter, simpler, or both. - Optimizes nicer with a smaller, separate function for the try/catch. Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
Commit 934bfe23 had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes: https://github.com/joyent/node/issues/8897 Conflicts: lib/timers.js Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Julien Gilli authored
Before this change, _unrefActive would keep the unrefList sorted when adding a new timer. Because _unrefActive is called extremely frequently, this linear scan (O(n) at worse) would make _unrefActive show high in the list of contributors when profiling CPU usage. This commit changes _unrefActive so that it doesn't try to keep the unrefList sorted. The insertion thus happens in constant time. However, when a timer expires, unrefTimeout has to go through the whole unrefList because it's not ordered anymore. It is usually not large enough to have a significant impact on performance because: - Most of the time, the timers will be removed before unrefTimeout is called because their users (sockets mainly) cancel them when an I/O operation takes place. - If they're not, it means that some I/O took a long time to happen, and the initiator of subsequents I/O operations that would add more timers has to wait for them to complete. With this change, _unrefActive does not show as a significant contributor in CPU profiling reports anymore. Fixes: https://github.com/joyent/node/issues/8160 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com> Conflicts: lib/timers.js Fixes: https://github.com/nodejs/node-convergence-archive/issues/23 Ref: https://github.com/nodejs/node/issues/268 PR-URL: https://github.com/nodejs/node/pull/2540 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
-
Evan Lucas authored
ParseArgs sets the first element of v8_args to argv[0], so v8_argc will always be at least 1. This change only calls V8::SetFlagsFromCommandLine if v8_argc > 1, leading to an additional startup improvement of ~5%. PR-URL: https://github.com/nodejs/node/pull/2646 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2645 Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Saúl Ibarra Corretgé authored
PR-URL: https://github.com/nodejs/node/pull/2310 Reviewed-By:
bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
Karl Skomski authored
Both pointer arguments to memcmp are defined as non-null and compiler optimizes upon that. PR-URL: https://github.com/nodejs/node/pull/2544 Reviewed-By:
trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
Trevor Norris authored
String concatenation in the assert messages has drastic impact on test runtime. Removal of these messages is unlikely to affect debugging if any breaking changes are made. Previous time to run: $ time ./iojs test/parallel/test-stringbytes-external.js real 0m2.321s user 0m2.256s sys 0m0.092s With fix: $ time ./iojs test/parallel/test-stringbytes-external.js real 0m0.518s user 0m0.508s sys 0m0.008s PR-URL: https://github.com/nodejs/node/pull/2544 Reviewed-By:trevnorris - Trevor Norris <trev.norris@gmail.com> Reviewed-By:
thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Sep 01, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2623 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
new server has "nodejs" and "iojs" directories, upload to the appropriate one PR-URL: https://github.com/nodejs/node/pull/2623 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
to match nodejs.org directory name PR-URL: https://github.com/nodejs/node/pull/2623 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
now need to specify "nodejs" or "iojs", also remove .gpg file PR-URL: https://github.com/nodejs/node/pull/2623 Reviewed-By:
jbergstroem - Johan Bergström <bugs@bergstroem.nu>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2625 Reviewed-By:
orangemocha - Alexis Campailla <orangemocha@nodejs.org> Reviewed-By:
joaocgreis - João Reis <reis@janeasystems.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2438 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
Rich Trott authored
https://github.com/nodejs/node/pull/2541 fixed flakiness in test-process-argv-0.js. However, it was not removed from the list of flaky tests. This removes it from the list of flaky tests. PR-URL: https://github.com/nodejs/node/pull/2613 Reviewed-By:
cjihrig - Colin Ihrig <cjihrig@gmail.com>
-
- Aug 31, 2015
-
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/2591 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
-
- Aug 30, 2015
-
-
Rod Vagg authored
-