Commits · 30d55a3517cb64233c8d87f17f199b2cff355abd · github.com / v8-riscv / node

Mar 31, 2020

Sk Sajidul Kadir authored Mar 17, 2020

Fixes: https://github.com/nodejs/node/issues/2298
PR-URL: https://github.com/nodejs/node/pull/32356


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

30d55a35

util: fix inspecting document.all · 6d866510

Gus Caplan authored Feb 24, 2020

Fixes: https://github.com/nodejs/node/issues/31889

PR-URL: https://github.com/nodejs/node/pull/31938


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

6d866510

src: add test/abort build tasks · 928a4900

Christian Niederer authored Feb 14, 2020

The Aliased*Array overflow check test introduced a dependency to a
compiled artifact. Add this artifact to the build process in a
similar fashion as test/addons and test/js-native-api do.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

928a4900

src: add aliased-buffer-overflow abort test · 9c901a5e

Christian Niederer authored Feb 12, 2020

Added native extension similar to
test/addons/stringbytes-external-exceeded-max.
Added an abort test to regression test the non overflow behaviour.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

9c901a5e

src: check for overflow when extending AliasedBufferBase · 1e76bc67

Christian Niederer authored Feb 11, 2020

When resizing an aliased_buffer check if the new size will overflow.

PR-URL: https://github.com/nodejs/node/pull/31740


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1e76bc67

benchmark: use let instead of var in zlib · b556670d

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

b556670d

benchmark: use let instead of var in worker · d8316654

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

d8316654

benchmark: use let instead of var in util · f1d3fb06

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

f1d3fb06

benchmark: use let instead of var in url · 148df0a7

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

148df0a7

benchmark: use let instead of var in tls · 108e91fb

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

108e91fb

benchmark: use let instead of var in timers · f1720145

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

f1720145

benchmark: use let instead of var in run.js · 4ce6fc5f

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

4ce6fc5f

benchmark: use let instead of var in dns · 93b39974

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

93b39974

benchmark: use let instead of var in common.js · 54c6219c

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

54c6219c

benchmark: use const instead of var in async_hooks · b188b3c1

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

b188b3c1

benchmark: add `no-var` rule in .eslintrc.yaml · 05111c43

Daniele Belardi authored Feb 14, 2020

PR-URL: https://github.com/nodejs/node/pull/31794


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

05111c43

doc: fix typo in http2 docs · 002048ef

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

002048ef

doc: fix typo in maintaining-zlib guide · 02b0c9e4

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

02b0c9e4

doc: fix typo in maintaining-openssl guide · 6cdccc8f

Nitin Kumar authored Mar 30, 2020

PR-URL: https://github.com/nodejs/node/pull/32292


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>

6cdccc8f

test: revise test-http-response-multi-content-length · 02eea777

Rich Trott authored Mar 27, 2020

Isolate the two test cases here a bit more and refactor code.

PR-URL: https://github.com/nodejs/node/pull/32526


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

02eea777

src: unify Linux and FreeBSD large pages implem · c71736ef

Gabriel Schulhof authored Mar 26, 2020

dl_iterate_phdr(3) is also available for FreeBSD. This change adds the
same trimming code for the start and end of the .text section as on
Linux, making it work on FreeBSD, and removing the need for the
additional FreeBSD-specific check.

Manually tested on
  * https://www.osboxes.org/freebsd/#freebsd-12-1-vbox
  * https://www.osboxes.org/freebsd/#freebsd-11-vbox


  * test-digitalocean-freebsd11-x64-2

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: https://github.com/nodejs/node/pull/32534


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

c71736ef

src: replace handle dereference with ContainerOf · 06bff18f

Harshitha KP authored Mar 16, 2020

this was influenced by https://github.com/nodejs/node/pull/32269

PR-URL: https://github.com/nodejs/node/pull/32298


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

06bff18f

doc: fix profile type of --heap-prof-name · 7d4ec42b

Syohei YOSHIDA authored Mar 21, 2020

V8 CPU profile -> V8 heap profile

PR-URL: https://github.com/nodejs/node/pull/32404


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

7d4ec42b

doc: use uppercase on windows path · e7e3aeec

himself65 authored Mar 16, 2020

PR-URL: https://github.com/nodejs/node/pull/32294


Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

e7e3aeec

deps: update acorn to v7.1.1 · f690fc93

Ruben Bridgewater authored Mar 17, 2020

Also clean up the plugins package.json files.

PR-URL: https://github.com/nodejs/node/pull/32310


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

f690fc93

src: enhance template function 'MakeUtf8String' · b973b938

himself65 authored Mar 17, 2020

PR-URL: https://github.com/nodejs/node/pull/32322


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>

b973b938

doc,crypto: clarify oaepHash option's impact · 394f8ca3

Filip Skokan authored Mar 18, 2020

PR-URL: https://github.com/nodejs/node/pull/32340


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>

394f8ca3

http: increase default header size from 8KB to 16KB · bd9f4d29

unknown authored Mar 27, 2020

Fixes: https://github.com/nodejs/node/issues/27645

PR-URL: https://github.com/nodejs/node/pull/32520


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>

bd9f4d29

test: remove a duplicated test · f179a223

himself65 authored Mar 24, 2020

PR-URL: https://github.com/nodejs/node/pull/32453


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

f179a223

test: check bundled binaries are signed on macOS · fbb51b9c

Richard Lau authored Mar 27, 2020



For notarization on macOS all packaged binaries must be signed. Add a
regression test to check that known binaries from our dependencies
(at the time of this commit term-size via npm) are signed.

Signed-off-by: Richard Lau <riclau@uk.ibm.com>

PR-URL: https://github.com/nodejs/node/pull/32522


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

fbb51b9c

test: unflake async-hooks/test-statwatcher · 36c6d221

Bartosz Sosnowski authored Mar 25, 2020

On Windows 2016 under high load further change events can be emitted
after writing the 5 bytes is reported. Updating the mtime of the file
can be reported as a separate change. This will increase the "before"
count, but not the "w1HookCount" since we removed the listener.

This makes the test keep the listeners until the end of the test.

Fixes: https://github.com/nodejs/node/issues/21425

PR-URL: https://github.com/nodejs/node/pull/32484


Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

36c6d221

doc: rename cve_management_process.md to fit doc style guide · 1b97d25a

Ling Samuel authored Mar 24, 2020

PR-URL: https://github.com/nodejs/node/pull/32456


Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1b97d25a

doc: add missing changes: entry for mkdir · 1e27f66c

Anna Henningsen authored Mar 25, 2020

Refs: https://github.com/nodejs/node/pull/31530

PR-URL: https://github.com/nodejs/node/pull/32490


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Coe <bencoe@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>

1e27f66c

build: disable -Wattributes warnings on aix · 432e58fc

Ben Noordhuis authored Mar 22, 2020

Disable the following compiler warning:

    warning: visibility attribute not supported in this
    configuration; ignored [-Wattributes]

This is gcc complaining about `__attribute((visibility("default"))`
in static library builds. Legitimate but harmless (and uninteresting)
and it drowns out more relevant warnings.

PR-URL: https://github.com/nodejs/node/pull/32419


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

432e58fc

src: fix compiler warnings in node_report_module · fbf0493b

Daniel Bevenius authored Mar 26, 2020

Currently, the following compiler warnings are generated:
../src/node_report_module.cc:
In function ‘void report::ShouldReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:132:16: warning:
unused variable ‘env’ [-Wunused-variable]
  132 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~
../src/node_report_module.cc:
In function ‘void report::SetReportOnFatalError(
    const v8::FunctionCallbackInfo<v8::Value>&)’:
../src/node_report_module.cc:138:16: warning:
unused variable ‘env’ [-Wunused-variable]
  138 |   Environment* env = Environment::GetCurrent(info);
      |                ^~~

This commit removes the unused variables.

PR-URL: https://github.com/nodejs/node/pull/32498


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

fbf0493b

console: fixup error message · 814d88a0

James M Snell authored Mar 24, 2020



Use "options.inspectOptions" instead of just "inspectOptions"

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32475


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

814d88a0

fs: fixup error message for invalid options.recursive · 8770fd96

James M Snell authored Mar 24, 2020



Use "options.recursive" instead of just "recursive"

Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32472


Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

8770fd96

src: remove excess v8 namespace · 1de9718b

himself65 authored Mar 11, 2020

PR-URL: https://github.com/nodejs/node/pull/32191


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1de9718b

test: use Promise.all() in test-cluster-net-listen-ipv6only-false · b1e6f297

Rich Trott authored Mar 20, 2020



Use Promise.all() instead of countdown in
test-cluster-net-listen-ipv6only-false.

Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32398


Reviewed-By: Anna Henningsen <anna@addaleax.net>

b1e6f297

test: replace Map with Array in test-cluster-net-listen-ipv6only-false · 11d7cf15

Rich Trott authored Mar 20, 2020



Signed-off-by: Rich Trott <rtrott@gmail.com>

PR-URL: https://github.com/nodejs/node/pull/32398


Reviewed-By: Anna Henningsen <anna@addaleax.net>

11d7cf15