- Jan 15, 2015
-
-
Julien Gilli authored
Conflicts: test/simple/test-child-process-spawn-typeerror.js
-
Robert Kowalski authored
- `sh.css` already exists in `api_assets` - `sh_vim-dark.css` is unused, but used in the repo `node-website` now Reviewed-by:Trevor Norris <trev.norris@gmail.com> Signed-off-by:
Julien Gilli <julien.gilli@joyent.com>
-
- Jan 14, 2015
-
-
cjihrig authored
Backport 10703774 from the v0.12 branch. Currently, the test-child-process-spawn-typeerror.js is calling execFile() on a JavaScript source file, which is causing failures on Windows. This commit switches to calling spawn() on an actual executable. Fixes #8930. Signed-off-by:
Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
Conflicts: deps/v8/src/debug-debugger.js deps/v8/src/mirror-debugger.js deps/v8/src/platform-freebsd.cc deps/v8/src/platform-linux.cc deps/v8/src/platform-macos.cc deps/v8/src/platform-openbsd.cc deps/v8/src/platform-posix.cc deps/v8/src/platform-solaris.cc deps/v8/tools/gyp/v8.gyp
-
Julien Gilli authored
This reverts commit 45f13304. 45f13304 was basically breaking node-inspector. V8 landed a patch upstream that would probably fix these issues (see https://codereview.chromium.org/813873007 ), but without the ability to properly test it in the wild, it's safer to just revert the breaking change. Fixes #8948. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Jan 13, 2015
-
-
Julien Gilli authored
-
Julien Gilli authored
child_process.spawn's argument parsing is stricter in v0.12 than in v0.10. Changes in tests merged from v0.10 that relied on the less-strict argument parsing would fail. This change updates the test so that it makes sure that the stricter argument parsing fails as expected. This change also fixes a small typo introduced during the conflicts resolution of said merge.
-
Colin Ihrig authored
fs.exists() and fs.existsSync() do not follow the typical error first callback convention. access() and accessSync() are added as alternatives in this commit. PR-URL: https://github.com/joyent/node/pull/8714 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Fedor Indutny authored
Original source: http://openssl.6102.n7.nabble.com/PATCH-s-client-Fix-keypress-requirement-with-redirected-input-on-Windows-td46787.html Reviewed-By:
Fedor Indutny <fedor@indutny.com>
-
cjihrig authored
Currently, the test-child-process-spawn-typeerror.js is calling execFile() on a JavaScript source file, which is causing failures on Windows. This commit switches to calling spawn() on an actual executable. Reviewed-by:
Sam Roberts <sam@strongloop.com> Reviewed-by:
Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Julien Gilli authored
Fix indentation issue in code added during the latest merge. This change makes jslint pass for _tls_wrap.js.
-
Ben Noordhuis authored
Reduce the overhead of the CPU profiler by replacing sched_yield() with nanosleep() in V8's tick event processor thread. The former only yields the CPU when there is another process scheduled on the same CPU. Before this commit, the thread would effectively busy loop and consume 100% CPU time. By forcing a one nanosecond sleep period rounded up to the task scheduler's granularity (about 50 us on Linux), CPU usage for the processor thread now hovers around 10-20% for a busy application. PR-URL: https://github.com/joyent/node/pull/8789 Ref: https://github.com/strongloop/strong-agent/issues/3 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Julien Gilli authored
The latest merge resulted in uv__loop_configure being defined twice on Windows. This changes removes one of these duplicates to fix the build on this platform.
-
Julien Gilli authored
Conflicts: AUTHORS ChangeLog configure deps/uv/AUTHORS deps/uv/ChangeLog deps/uv/README.md deps/uv/config-unix.mk deps/uv/include/uv-private/uv-win.h deps/uv/include/uv.h deps/uv/src/unix/internal.h deps/uv/src/unix/kqueue.c deps/uv/src/unix/stream.c deps/uv/src/uv-common.c deps/uv/src/uv-common.h deps/uv/src/version.c deps/uv/src/win/poll.c deps/uv/test/test-osx-select.c deps/v8/src/debug-debugger.js deps/v8/src/isolate.cc deps/v8/src/isolate.h deps/v8/src/mirror-debugger.js doc/api/buffer.markdown doc/api/child_process.markdown doc/api/dns.markdown doc/api/tls.markdown doc/api/url.markdown lib/_stream_writable.js lib/assert.js lib/child_process.js lib/crypto.js lib/dgram.js lib/http.js lib/net.js lib/timers.js lib/tls.js src/node.cc src/node.h src/node.js src/node_crypto.cc src/node_version.h test/common.js test/simple/test-child-process-spawn-typeerror.js tools/certdata.txt
-
- Jan 09, 2015
-
-
cjihrig authored
b636ba81 caused a regression on Windows due to the way server handles are cleaned up. This commit fixes the test by allowing the handle to be cleaned up. Fixes: https://github.com/joyent/node/issues/8986 PR-URL: https://github.com/joyent/node/pull/8998 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com> Reviewed-By:
Bert Belder <bertbelder@gmail.com>
-
- Jan 08, 2015
-
-
Chris Dickinson authored
Revert "src: fix windows build error" and "zlib: support concatenated gzip files". Treating subsequent data as a concatenated stream breaks npm install. This reverts commits 93533e98 and 6f6a9795. Fixes: https://github.com/joyent/node/issues/8962 PR-URL: https://github.com/joyent/node/pull/8985 Reviewed-By:
Julien Gilli <julien.gilli@joyent.com>
-
- Jan 05, 2015
-
-
Trevor Norris authored
If the data length passed to smalloc.alloc() the array_length will be zero, causing an overflow check to fail. This prevents that from happening. Signed-off-by:Trevor Norris <trev.norris@gmail.com>
-
- Jan 04, 2015
-
-
cjihrig authored
Socket.prototype.connect() sometimes throws on bad inputs after an asynchronous operation. This commit makes the input validation synchronous. This commit also removes some hard coded IP addresses. PR-URL: https://github.com/joyent/node/pull/8180 Fixes: https://github.com/joyent/node/issues/8140 Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com>
-
- Jan 03, 2015
-
-
Steven R. Loomis authored
PR-URL: https://github.com/joyent/node/pull/8964 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Steven R. Loomis authored
Make "--with-intl=none" the default and add "intl-none" option to vcbuild.bat. If icu data is missing print a warning unless either --download=all or --download=icu is set. If set then automatically download, verify (MD5) and unpack the ICU data if not already available. There's a "list" of URLs being used, but right now only the first is picked up. The logic works something like this: * If there is no directory deps/icu, * If no zip file (currently icu4c-54_1-src.zip), * Download zip file (icu-project.org -> sf.net) * Verify the MD5 sum of the zipfile * If bad, print error and exit * Unpack the zipfile into deps/icu * If deps/icu now exists, use it, else fail with help text Add the configuration option "--with-icu-source=..." Usage: * --with-icu-source=/path/to/my/other/icu * --with-icu-source=/path/to/icu54.zip * --with-icu-source=/path/to/icu54.tgz * --with-icu-source=http://example.com/icu54.tar.bz2 Add the configuration option "--with-ic...
-
- Dec 31, 2014
-
-
CGavrila authored
The url.parse() function now checks whether an escapable character is in the URL before trying to escape it. PR-URL: https://github.com/joyent/node/pull/8638 [trev.norris@gmail.com: Switch to use continue instead of if] Signed-off-by:
Trevor Norris <trev.norris@gmail.com>
-
- Dec 24, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
- Dec 23, 2014
-
-
Timothy J Fontaine authored
* tls: re-add 1024-bit SSL certs removed by f9456a2d (Chris Dickinson) * timers: don't close interval timers when unrefd (Julien Gilli) * timers: don't mutate unref list while iterating it (Julien Gilli)
-
James M Snell authored
Better wording for start and end parameters, also document .length should be considered readonly. RE: #8857, #8859, #8913 PR: #8910 PR-URL: https://github.com/joyent/node/pull/8910 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
James M Snell authored
Clarify that adding or removing a listener is not idempotent. RE: #8853 PR: #8911 PR-URL: https://github.com/joyent/node/pull/8911 Signed-off-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Julien Gilli authored
Commit 934bfe23 had introduced a regression where node would crash trying to access a null unref timer if a given unref timer's callback would remove other unref timers set to fire in the future. More generally, it makes the unrefTimeout function more solid by not mutating the unrefList while traversing it. Fixes #8897. Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
- Dec 20, 2014
-
-
Chris Dickinson authored
this fixes a problem where connecting to AWS services would report an untrusted cert error. Fixes: https://github.com/joyent/node/issues/8894 PR-URL: https://github.com/joyent/node/pull/8904 Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Julien Gilli <julien.gilli@joyent.com>
-
Julien Gilli authored
This change fixes a regression introduced by commit 0d051238 , which contained a typo that would cause every unrefd interval to fire only once. Fixes #8900. Reviewed-By:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
Jackson Tian authored
Add documentation for the callback parameter of http.ClientRequest's and http.ServerResponse's end methods. Signed-off-by:Julien Gilli <julien.gilli@joyent.com>
-
- Dec 19, 2014
-
-
Chris Dickinson authored
In cases where many small writes are made to a stream lacking _writev, the array data structure backing the WriteReq buffer would greatly increase GC pressure. Specifically, in the fs.WriteStream case, the clearBuffer routine would only clear a single WriteReq from the buffer before exiting, but would cause the entire backing array to be GC'd. Switching to [].shift lessened pressure, but still the bulk of the time was spent in memcpy. This replaces that structure with a linked list-backed queue so that adding and removing from the queue is O(1). In the _writev case, collecting the buffer requires an O(N) loop over the buffer, but that was already being performed to collect callbacks, so slowdown should be neglible. PR-URL: https://github.com/joyent/node/pull/8826 Reviewed-by:
Timothy J Fontaine <tjfontaine@gmail.com> Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
- Dec 18, 2014
-
-
Timothy J Fontaine authored
-
Timothy J Fontaine authored
-
Ben Noordhuis authored
Fix a Windows-only build error that was introduced in commit 1183ba47 ("zlib: support concatenated gzip files"). Rename the NO_ERROR and FAILED enumerations, they conflict with macros of the same name in <winerror.h>. PR-URL: https://github.com/joyent/node/pull/8893 Reviewed-By:
Fedor Indutny <fedor@indutny.com> Reviewed-By:
Rod Vagg <rod@vagg.org> Reviewed-by:
Timothy J Fontaine <tjfontaine@gmail.com>
-
Timothy J Fontaine authored
* uv: update to v0.10.30 * zlib: upgrade to v1.2.8 * child_process: check execFile args is an array (Sam Roberts) * child_process: check fork args is an array (Sam Roberts) * crypto: update root certificates (Ben Noordhuis) * domains: fix issues with abort on uncaught (Julien Gilli) * timers: Avoid linear scan in _unrefActive. (Julien Gilli) * timers: fix unref() memory leak (Trevor Norris) * v8: add api for aborting on uncaught exception (Julien Gilli) * debugger: fix when using "use strict" (Julien Gilli)
-
Miroslav Bajtoš authored
Fix Interface.setBreakpoint() to correctly handle an attempt to set a breakpoint in the current script when there is no current script. This usually happens when the debugged process is not paused. Fixes: https://github.com/joyent/node/issues/6453 PR-URL: https://github.com/joyent/node/pull/6460 Reviewed-By:
Chris Dickinson <christopher.s.dickinson@gmail.com>
-
Trevor Norris authored
This reverts commit 1eb1e0a9.
-
Ben Noordhuis authored
Reduce the overhead of the CPU profiler by suppressing SIGPROF signals when sleeping / polling for events. Avoids unnecessary wakeups when the CPU profiler is active. Depends on https://github.com/libuv/libuv#15. Ref: https://github.com/strongloop/strong-agent/issues/3 PR-URL: https://github.com/joyent/node/pull/8791 Reviewed-by:
Trevor Norris <trev.norris@gmail.com>
-
cjihrig authored
A block of asserts were duplicated in test/simple/test-child-process-spawn-typeerror.js. This commit removes the duplicated asserts. Fixes: https://github.com/joyent/node/pull/8454 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-