- Mar 13, 2017
-
-
Claudio Rodriguez authored
Refactor dgram module to use the more efficient module.exports = {} pattern. PR-URL: https://github.com/nodejs/node/pull/11696 Reviewed-By:Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Timothy Gu <timothygu99@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
Ron Korving <ron@ronkorving.nl>
-
Gibson Fahnestock authored
The font size for tablet sized screens (or half a laptop screen) is overly large, reduce it to a more readable size. Fixes: https://github.com/nodejs/nodejs.org/issues/919 PR-URL: https://github.com/nodejs/node/pull/11695 Fixes: https://github.com/nodejs/nodejs.org#919 Reviewed-By:
Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By:
-
Jeroen Mandersloot authored
I identified a number of files where it said "the the" in the comments of the source code and in general documentation texts. I replaced these occurences with a single instance of "the". PR-URL: https://github.com/nodejs/node/pull/11711 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Sam Roberts authored
Fixes: https://github.com/nodejs/node/issues/11717 PR-URL: https://github.com/nodejs/node/pull/11718 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/11488 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Julien Gilli <jgilli@nodejs.org> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
-
Amelia Clarke authored
Ref: https://github.com/nodejs/node/issues/9399 PR-URL: https://github.com/nodejs/node/pull/11681 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
-
Richard Lau authored
Code was calculating $PREFIX/lib/node relative to process.execPath, but on Windows process.execPath is $PREFIX\node.exe whereas everywhere else process.execPath is $PREFIX/bin/node (where $PREFIX is the root of the installed Node.js). PR-URL: https://github.com/nodejs/node/pull/9283 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
João Reis <reis@janeasystems.com> Reviewed-By:
-
Juwan Yoo authored
Arguments of Socket.prototype.connect should be also normalized, causing error when called without callback. Changed Socket.prototype.connect's code same as net.connect and added test. Fixes: https://github.com/nodejs/node/issues/11761 PR-URL: https://github.com/nodejs/node/pull/11762 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
Junliang Yan authored
PR-URL: https://github.com/nodejs/node/pull/11730 Reviewed-By:
-
Steven R. Loomis authored
* We use these functions that are declared in <unicode/ustring.h> u_strFromUTF8() u_strToUTF8() * At present, <unicode/ustring.h> is indirectly included, but this will likely change in future ICUs. Adding this header has been the right thing to do for many years, so it is backwards compatible. Fixes: https://github.com/nodejs/node/issues/11753 PR-URL: https://github.com/nodejs/node/issues/11754 Reviewed-By: -
Anna Henningsen authored
The `NODE_ISOLATE_SLOT` macro has been unused since c3cd453c. PR-URL: https://github.com/nodejs/node/pull/11692 Reviewed-By:
-
Richard Lau authored
Test executes with a copy of the node executable since $PREFIX/lib/node is relative to the executable location. PR-URL: https://github.com/nodejs/node/pull/9283 Reviewed-By:
-
Shigeki Ohtsu authored
0-dns-cert.pem and 0-dns-key.pem were stored in `test/fixtures/key` directory, but the cert file cannot be created with the openssl command via Makefile. Added a script to create it with using `asn1.js` and `asn1.js-rfc5280` and moved them out of key directory and put into `test/fixtures/0-dns`. The domains listed in the cert were also changed into example.com and example.org to show the use for only testing. Fixes: https://github.com/nodejs/node/issues/10228 PR-URL: https://github.com/nodejs/node/pull/11579 Reviewed-By:
-
Clarence Dimitri CHARLES authored
PR-URL: https://github.com/nodejs/node/pull/11622 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/11691 Reviewed-By:
-
DavidCai authored
PR-URL: https://github.com/nodejs/node/pull/11653 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By:
-
Rich Trott authored
When ArrayBufferAllocator has an undefined zeroFill property, Buffer.allocUnsafe() should zero fill. Refs: https://github.com/nodejs/node/commit/27e84ddd4e1#commitcomment-19182129 PR-URL: https://github.com/nodejs/node/pull/11706 Reviewed-By:
-
Rich Trott authored
nexttick_throw.js has a comment that disables all ESLint rules for a line. Change it to only disable the one ESLint rule that the line violates. PR-URL: https://github.com/nodejs/node/pull/11724 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
Michael Cox authored
This modifies the script that generates the docs to create a static link from each Stability Index callout bar to the Stability Index explanations in documentation.html. PR-URL: https://github.com/nodejs/node/pull/11664 Reviewed-By:
-
Brian White authored
'file' should have been 'file:' but since the WHATWG URL spec suggests using an opaque origin (which is what was already being used for file URLs), we'll just keep using that, making this merely a cleanup. PR-URL: https://github.com/nodejs/node/pull/11691 Reviewed-By:
-
- Mar 09, 2017
-
-
Evan Lucas authored
PR-URL: https://github.com/nodejs/node/pull/11745
-
- Mar 08, 2017
-
-
Evan Lucas authored
Notable changes: * doc: add `Daijiro Wachi` to collaborators (Daijiro Wachi) https://github.com/nodejs/node/pull/11676 * tty: add ref() so process.stdin.ref() etc. work (Ben Schmidt) https://github.com/nodejs/node/pull/7360 * util: fix inspecting symbol key in string (Ali BARIN) https://github.com/nodejs/node/pull/11672 PR-URL: https://github.com/nodejs/node/pull/11745
-
Joyee Cheung authored
* Make normalizeArgs return either [options, null] or [options, cb] (the second element won't be undefined anymore) and avoid OOB read * Use Socket.prototype.connect.call instead of .apply when the number of arguments is certain(returned by normalizeArgs). * Rename some args[i] for readability * Refactor Server.prototype.listen, separate backlogFromArgs and options.backlog, comment the overloading process, refactor control flow PR-URL: https://github.com/nodejs/node/pull/11667 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/11555 Ref: https://github.com/nodejs/CTC/pull/73 Reviewed-By:
-
Shigeki Ohtsu authored
In FreeBSD-10, the banner of clang version is "FreeBSD clang version". Fix regex to detect it. PR-URL: https://github.com/nodejs/node/pull/11668 Reviewed-By:
-
- Mar 07, 2017
-
-
On Windows, the test simply returns which will be counted as passed. The test actually skips the rest of the test. So proper TAP message has to be included while skipping. This patch uses `common.skip` rather than `console.log` to print the skip messages. PR-URL: https://github.com/nodejs/node/pull/11584 Reviewed-By:
-
Sam Roberts authored
Apply unreleased (as of zlib v1.2.11) patch from upstream: - https://github.com/madler/zlib/commit/38e8ce32afbaa82f67d992b9f3056f281fe69259 Original commit message: Fix CLEAR_HASH macro to be usable as a single statement. As it is used in deflateParams(). PR-URL: https://github.com/nodejs/node/pull/11616 Reviewed-By:
-
Laurent Fortin authored
readable.isPaused(): added a missing YAML placeholder so the 'Added to version' annotation is displayed in docs PR-URL: https://github.com/nodejs/node/pull/11677 Reviewed-By:
-
Ali BARIN authored
PR-URL: https://github.com/nodejs/node/pull/11672 Reviewed-By:
-
Poker authored
PR-URL: https://github.com/nodejs/node/pull/11670 Reviewed-By:
-
Rich Trott authored
The stability index 3 (Locked) is unused and is being eliminated. Remove it from the documentation about the stability index. Remove mention of the Locked from CONTRIBUTING.md. The remaining text about the stability index is slight and not seemingly valuable. Removing it too. PR-URL: https://github.com/nodejs/node/pull/11661 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
-
Rich Trott authored
Update documentation for `module` to reflect stability index 2 (Stable) rather than 3 (Locked). PR-URL: https://github.com/nodejs/node/pull/11661 Ref: https://github.com/nodejs/node/issues/11200 Reviewed-By:
-
- Mar 06, 2017
-
-
Rahat Ahmed authored
PR-URL: https://github.com/nodejs/node/pull/11657 Reviewed-By:
-
Daijiro Wachi authored
In the getter of the origin in URL, the URL that has blob protocol will be parsed in a function called "originFor". Add test cases into the url-tests-additional fixture to test that. Refs: https://github.com/w3c/web-platform-tests/pull/4941 PR-URL: https://github.com/nodejs/node/pull/11426 Reviewed-By:
-
maurice_hayward authored
test: changed test1 of test-vm-timeout.js so that entire error message would be matched in assert.throw. Before test 1 of test-vm-timeout.js would match any error, now it looks specifically for the error message "Script execution timed out." PR-URL: https://github.com/nodejs/node/pull/11590 Reviewed-By:
-
James M Snell authored
Move to the more efficient module.exports = {} pattern. PR-URL: https://github.com/nodejs/node/pull/11597 Reviewed-By: -
Daniel Bevenius authored
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: https://github.com/nodejs/node/issues/4641 PR-URL: https://github.com/nodejs/node/pull/11669 Reviewed-By:
-
Rich Trott authored
The align-function-arguments custom rule is obsolete and has been removed from the code base. Remove comment that used to disable it for one file. PR-URL: https://github.com/nodejs/node/pull/11643 Reviewed-By:
-
Daijiro Wachi authored
Like the other internal modules, we should use `process.binding('config').hasIntl` instead of `try-catch` to make sure `icu` is bonded or not. PR-URL: https://github.com/nodejs/node/pull/11571 Reviewed-By:Jackson Tian <shyvo1987@gmail.com>
-
Benjamin Fleischer authored
PR-URL: https://github.com/nodejs/node/pull/11189 Reviewed-By:
-
