- Apr 22, 2020
-
-
Matheus Marchini authored
Original commit message: Fix scanner-level error reporting for hashbang When the file begins with a hashbang, the scanner is in a failed state when SkipHashbang() is called. This is usually not an issue but when the parser encounters an ILLEGAL token, it will reset the SyntaxError location because of it. Bug: v8:10110 Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66038} Refs: https://github.com/v8/v8/commit/f9257802c1c0a0663a1d05bacf662283f6bd9050 Fixes: https://github.com/nodejs/node/issues/31284 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32180 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Mateusz Krawczuk authored
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: https://github.com/nodejs/node/pull/32012 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Harshitha KP authored
The test wanted to cut huge string into 1KB strings, for which a new line character was inserted at appropriate places. The value is different in Windows (10, 13). Make it portable, by making use of os.EOL semantics Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/32104 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Bartosz Sosnowski authored
Document Windows specific fs.watch caveats. Fixes: https://github.com/nodejs/node/issues/31702 PR-URL: https://github.com/nodejs/node/pull/32176 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32125 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Harshitha KP authored
Make sure longer strings are written up to the buffer end Refs: https://github.com/nodejs/node/pull/32119 PR-URL: https://github.com/nodejs/node/pull/32123 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32087 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Eric Bickle authored
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: https://github.com/nodejs/node/issues/32072 PR-URL: https://github.com/nodejs/node/pull/32073 Reviewed-By:
-
Michael Dawson authored
Signed-off-by:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Ben Noordhuis authored
We might not have sufficient privileges to signal the child process so don't make assumptions about the return value of `uv_process_kill()`. Example: node -e 'child_process.spawnSync("sudo", ["ls"], { maxBuffer: 1 })' No test because: 1. The test needs to run as root (can't invoke sudo), and 2. The parent needs to drop privileges but can't, because then the child process won't have sufficient privileges. Fixes: https://github.com/nodejs/node/issues/31747 PR-URL: https://github.com/nodejs/node/pull/31768 Reviewed-By:Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/31952 Reviewed-By:
-
Gerhard Stoebich authored
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: https://github.com/nodejs/node/pull/31972 Refs: https://github.com/nodejs/node/pull/30959 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Joe Pea authored
PR-URL: https://github.com/nodejs/node/pull/32152 Reviewed-By:
-
Denys Otrishko authored
Fixes: https://github.com/nodejs/node/issues/20605 Refs: https://github.com/libuv/libuv/pull/1837 PR-URL: https://github.com/nodejs/node/pull/32091 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Sam Roberts authored
It was not possible to understand which, if either, of the sentences after the first ("Windows does not... emulation") apply specifically to Windows. Specifically, `kill(pid, 0)` works on Linux and Windows and I couldn't find it documented anywhere else, but the unconditional termination occurs only on Windows. PR-URL: https://github.com/nodejs/node/pull/32079 Reviewed-By: -
Eric Bickle authored
Fixes tls.rootCertificates missing certificates loaded from NODE_EXTRA_CA_CERTS. Fixes: https://github.com/nodejs/node/issues/32074 PR-URL: https://github.com/nodejs/node/pull/32075 Reviewed-By:
-
Anna Henningsen authored
Various improvements to the Buffer docs. PR-URL: https://github.com/nodejs/node/pull/32086 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31911 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31883 Reviewed-By:
-
Harshitha KP authored
fixes: https://github.com/nodejs/node/issues/31661 PR-URL: https://github.com/nodejs/node/pull/31865 Fixes: https://github.com/nodejs/node/issues/31661 Reviewed-By:
-
David Gilbertson authored
Tables on some pages (e.g. https://nodejs.org/api/crypto.html) are quite wide because of long content (e.g. URLs) that don't break. With this change, cell padding is smaller on small screens, and the table content is allowed to break. PR-URL: https://github.com/nodejs/node/pull/31859 Reviewed-By:
-
Ben Noordhuis authored
Turn the `strategy_` method pointer into an enum-based static dispatch. It's both safer and more secure (no chance of method pointer corruption) and it helps GCC see that the shift and suffix tables it's complaining about are unused in single char search mode. Fixes the following warning: ../src/string_search.h:113:30: warning: ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized] return (this->*strategy_)(subject, index); Fixes: https://github.com/nodejs/node/issues/26733 Refs: https://github.com/nodejs/node/pull/31532 Refs: https://github.com/nodejs/node/pull/31798 PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:Michaël Zasso <targos@protonmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:
-
forfun414 authored
change scripts and sources for android build, don't need standalone toolchain after ndk 19, and use clang as default android target compiler. PR-URL: https://github.com/nodejs/node/pull/31521 Reviewed-By:
Christian Clauss <cclauss@me.com>
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.2 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.1 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.0 PR-URL: https://github.com/nodejs/node/pull/31400 Reviewed-By:
-
RamanandPatil authored
PR-URL: https://github.com/nodejs/node/pull/32041 Reviewed-By:
-
Myles Borins authored
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: https://github.com/nodejs/node/issues/21781 PR-URL: https://github.com/nodejs/node/pull/32189 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
- Apr 21, 2020
-
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/31845 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32959 Reviewed-By:
-
Alba Mendez authored
Completely disables the use of positioned writes at writeFile and writeFileSync, which allows it to work with non-seekable files. Fixes: https://github.com/nodejs/node/issues/31926 Backport-PR-URL: https://github.com/nodejs/node/pull/32172 PR-URL: https://github.com/nodejs/node/pull/32006 Reviewed-By:
-
antsmartian authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32164 PR-URL: https://github.com/nodejs/node/pull/31187 Refs: https://github.com/nodejs/node/pull/31144 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Matheus Marchini authored
If the subprocess being inspected hard crashes, there will be no information on the log, and the parent process will just wait until timeout. Logging the error signal when it happens can help developers understand failures faster. Signed-off-by:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Denys Otrishko authored
This adds `const char*` based APIs to KVStore to avoid multiple string conversions (char -> Utf8 -> Local -> char etc.) when possible. PR-URL: https://github.com/nodejs/node/pull/31773 Reviewed-By:
-
Robert Nagy authored
Whether and when a socket is destroyed or not after a timeout is up to the user. This leaves an edge case where a socket that has emitted 'timeout' might be re-used from the free pool. Even if destroy is called on the socket, it won't be removed from the freelist until 'close' which can happen several ticks later. Sockets are removed from the free list on the 'close' event. However, there is a delay between calling destroy() and 'close' being emitted. This means that it possible for a socket that has been destroyed to be re-used from the free list, causing unexpected failures. PR-URL: https://github.com/nodejs/node/pull/32000 Reviewed-By:
-
