- Apr 11, 2020
-
-
Ben Noordhuis authored
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887 PR-URL: https://github.com/nodejs/node/pull/32420 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Lucas Holmquist authored
This makes the offset, length and position parameters optional by passing in an options object. PR-URL: https://github.com/nodejs/node/pull/32460 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
James M Snell authored
Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
cjihrig authored
Update ESLint to 7.0.0-alpha.3 PR-URL: https://github.com/nodejs/node/pull/32533 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32542 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32544 Reviewed-By:
-
Daniel Estiven Rico Posada authored
PR-URL: https://github.com/nodejs/node/pull/32549 Reviewed-By:
-
James M Snell authored
* Simplify Http2Priority struct * BooleanValue => IsTrue/IsFalse Signed-off-by:
-
James M Snell authored
Suppress compile warnings on Windows, rename class for consistent styling. Signed-off-by:
-
James M Snell authored
Signed-off-by:
-
Anna Henningsen authored
There’s no reason for this to not be stored alongside the loop data structure itself. PR-URL: https://github.com/nodejs/node/pull/32562 Refs: https://github.com/nodejs/node/pull/32344 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Instead of setting and then in the case of error un-setting properties, only set them when no error occurs. Refs: https://github.com/nodejs/node/pull/32344 PR-URL: https://github.com/nodejs/node/pull/32562 Reviewed-By:
-
Hachimi Aa (Sfeir) authored
PR-URL: https://github.com/nodejs/node/pull/29270 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Ben Noordhuis authored
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: https://github.com/nodejs/node/issues/31733 PR-URL: https://github.com/nodejs/node/pull/31734 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
Overlooked in 2fa74e3e. Refs: https://github.com/nodejs/node/pull/32207 PR-URL: https://github.com/nodejs/node/pull/32535 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Anna Henningsen authored
The JSONWriter feature is not inherently related to the report feature in any way. As a drive-by fix, remove a number of unused header includes. PR-URL: https://github.com/nodejs/node/pull/32552 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Anna Henningsen authored
Class names are written in UpperCamelCase. Otherwise, this looks like it’s a variable, not a class name. PR-URL: https://github.com/nodejs/node/pull/32539 Reviewed-By:
-
Andrey Pechkurov authored
PR-URL: https://github.com/nodejs/node/pull/32503 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Alex R authored
For keep-alive connections, the headersTimeout may fire during subsequent request because the measurement was reset after a request and not before a request. PR-URL: https://github.com/nodejs/node/pull/32329 Fixes: https://github.com/nodejs/node/issues/27363 Reviewed-By:
-
Anna Henningsen authored
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: https://github.com/nodejs/node/pull/32546 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32548 Reviewed-By:
-
Myles Borins authored
Moved emeritus members keys and fixed alphabetization issues PR-URL: https://github.com/nodejs/node/pull/32577 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz $ mv openssl-1.1.0h openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By: -
Myles Borins authored
This test is somewhat regularly flaky on 12.x and it appears master as well. There appears to be an issue tracking flakes for 6+ months. Seems reasonable to mark this to keep us from having red CI. Refs: https://github.com/nodejs/node/issues/29802 PR-URL: https://github.com/nodejs/node/pull/32595 Reviewed-By:
-
Myles Borins authored
Consistently failing on ubuntu1804_sharedlibs_debug_x64 Refs: https://github.com/nodejs/node/issues/26401 PR-URL: https://github.com/nodejs/node/pull/32589 Reviewed-By:
-
Robert Nagy authored
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: https://github.com/nodejs/node/issues/32486#issuecomment-604072559 PR-URL: https://github.com/nodejs/node/pull/32491 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32436 Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/32351 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Apr 01, 2020
-
-
Richard Lau authored
Refactor the logic for working out the previous versions of Node.js for the API documentation so that the parsing (including the potential https get) happens at most once per build (as opposed to the current once per generated API doc). Signed-off-by:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
Replace magic numbers with constant. Use for loop for repeated code. Reduce console logging. Remove unneeded countdown module use. PR-URL: https://github.com/nodejs/node/pull/32547 Reviewed-By:
-
Sam Roberts authored
Follow on to https://github.com/nodejs/node/pull/32207, 3 other options are also not respected under situations that the isolate is not available. PR-URL: https://github.com/nodejs/node/pull/32497 Reviewed-By:
-
Gabriel Schulhof authored
Replace the portion of the context-aware addon example that advocates for managing the life cycle of the per-addon-instance data using a weak reference with code that illustrates how to manage its life cycle using an environment cleanup hook. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/28659 Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
- Mar 31, 2020
-
-
Denys Otrishko authored
PR-URL: https://github.com/nodejs/node/pull/31797 Reviewed-By:
-
murgatroid99 authored
PR-URL: https://github.com/nodejs/node/pull/32183 Reviewed-By:
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32222 Reviewed-By:
-
Ben Noordhuis authored
The publicEncrypt/privateDecrypt/etc. family of functions didn't clear OpenSSL's error stack on early return. Notably, trying to use an encrypted key with the wrong passphrase left an error on the stack that made subsequent encrypt or decrypt operations fail, even with an unencrypted key. Fixes: https://github.com/nodejs/node/issues/32240 PR-URL: https://github.com/nodejs/node/pull/32248 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32286 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
