- May 23, 2020
-
-
Michaël Zasso authored
Refs: https://github.com/unicode-org/icu/releases/tag/release-67-1 PR-URL: https://github.com/nodejs/node/pull/33337 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
- May 13, 2020
-
-
Daniele Belardi authored
Run CommonJS resolver only if `error.code` is ERR_MODULE_NOT_FOUND. Avoid using absolute paths in hint by: * using a parent-relative path if the specifier is a relative path * using a `pkg/x.js` format if the specifier is bare (e.g. `pkg/x`) PR-URL: https://github.com/nodejs/node/pull/31906 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
bcoe authored
PR-URL: https://github.com/nodejs/node/pull/33151 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Robert Nagy authored
unshifting into an empty array is the same as creating a new array. PR-URL: https://github.com/nodejs/node/pull/33200 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33187 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Adrian Estrada authored
PR-URL: https://github.com/nodejs/node/pull/33180 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
New version of remark-preset-lint-node includes prohibited string entry accidentally removed in the last version. PR-URL: https://github.com/nodejs/node/pull/33157 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
Kevin Locke authored
This function was added by nodejs/node#15663, but was never documented. This commit documents it. PR-URL: https://github.com/nodejs/node/pull/33092 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com>
-
Juan José Arboleda authored
Collaborators won't need to run CI on documentation-only changes. PR-URL: https://github.com/nodejs/node/pull/33101 Reviewed-By:
-
白一梓 authored
Change `64kb` to `64KB` in `stream.md` PR-URL: https://github.com/nodejs/node/pull/31561 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
-
Anna Henningsen authored
Running tests with an ASAN build leads to increased memory usage, rendering the memory usage assumptions in the test invalid. Refs: https://github.com/nodejs/node/pull/32776#issuecomment-620407014 PR-URL: https://github.com/nodejs/node/pull/33129 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Anna Henningsen authored
This test can fail when run in parallel with test-process-title-cli, which also sets the process title, which is global state on Windows. Example failure (note that `foo` does not appear in test-process-title but in test-process-title-cli): not ok 1727 parallel/test-process-title --- duration_ms: 0.156 severity: fail exitcode: 1 stack: |- assert.js:103 throw new AssertionError(obj); ^ AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + 'foo' - 'd:\\a\\node\\node\\out\\Release\\node.exe' at Object.<anonymous> (d:\a\node\node\test\parallel\test-process-title.js:22:1) at Module._compile (internal/modules/cjs/loader.js:1176:30) at Object.Module._extensions..js (internal/modules/cjs/loader.js:1196:10) at Module.load (internal/modules/cjs/loader.js:1040:32) at Function.Module._load (internal/modules/cjs/loader.js:929:14) at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12) at internal/main/run_main_module.js:17:47 { generatedMessage: true, code: 'ERR_ASSERTION', actual: 'foo', expected: 'd:\\a\\node\\node\\out\\Release\\node.exe', operator: 'strictEqual' } ... (from https://github.com/nodejs/node/runs/628144750?check_suite_focus=true) PR-URL: https://github.com/nodejs/node/pull/33150 Reviewed-By: -
Guy Bedford authored
PR-URL: https://github.com/nodejs/node/pull/33086 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Anna Henningsen authored
`sizeof(data)` does not return the correct result here, as it measures the size of the `data` variable, not what it points to. PR-URL: https://github.com/nodejs/node/pull/33115 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/33114 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
This closes a memory leak. PR-URL: https://github.com/nodejs/node/pull/33113 Reviewed-By:
Gus Caplan <me@gus.host>
-
Anna Henningsen authored
As this is allocated with `Calloc()`, we cannot use `delete[]` here. PR-URL: https://github.com/nodejs/node/pull/33110 Reviewed-By:
-
James M Snell authored
Extracted from the QUIC PR. Not specific to QUIC even if the behavior is currently only used there. Signed-off-by:
Sam Roberts <vieuxtech@gmail.com>
-
James M Snell authored
Extracted from the QUIC PR. Not specific to QUIC. Signed-off-by:
-
James M Snell authored
This is a largely cosmetic change suggested for easier maintainability of the builtinLibs list. While the QUIC PR no longer modifies this list, the original version of the PR did and the fact that all of the entries were bundled up into the same lines meant that adding one forced a larger change to all. With this PR, when we want to add a new built-in, it won't impact any of the others. PR-URL: https://github.com/nodejs/node/pull/33106 Reviewed-By:
-
James M Snell authored
Extracted from the [QUIC PR](https://github.com/nodejs/node/pull/32379 ) So far, this is only used by the QUIC PR directly but the change itself is independent of QUIC, even if not used directly by anything else yet. Separated out per request. Signed-off-by:
-
Nick Schonning authored
PR-URL: https://github.com/nodejs/node/pull/33088 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Pranshu Srivastava authored
Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By:
Matteo Collina <matteo.collina@gmail.com>
-
Ranjan Purbey authored
In the worker pool example, the 'kWorkerFreedEvent' should be emitted in case of error as well. After adding new worker in the error handler, the pending tasks should be notified of an available worker. PR-URL: https://github.com/nodejs/node/pull/33082 Reviewed-By:
-
Chris Holland authored
PR-URL: https://github.com/nodejs/node/pull/33081 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32956 Reviewed-By:
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/32996 Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
uv_idle_init(), uv_idle_start() and uv_idle_stop() always succeed. Remove the superfluous error handling. Refs: https://github.com/libuv/libuv/pull/2803 PR-URL: https://github.com/nodejs/node/pull/32997 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33072 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33077 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32964 Fixes: https://github.com/nodejs/node/issues/32947 Reviewed-By:
-
Ben Noordhuis authored
It's possible to pass in the prime and generator params as buffers but that mode of input wasn't as rigorously checked as numeric input. PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
Validate the generator argument in `crypto.createDiffieHellman(key, g)`. When it's a number, it should be an int32. Fixes: https://github.com/nodejs/node/issues/32748 PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
The JS code accepted any value where `typeof sizeOrKey === 'number'` was true but the C++ code checked that `args[0]->IsInt32()` and subsequently aborted. Fixes: https://github.com/nodejs/node/issues/32738 PR-URL: https://github.com/nodejs/node/pull/32739 Reviewed-By:
-
Santiago Gimeno authored
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: https://github.com/nodejs/node/issues/32106 PR-URL: https://github.com/nodejs/node/pull/32793 Reviewed-By:
-
Sam Roberts authored
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: https://github.com/nodejs/node/issues/31280 PR-URL: https://github.com/nodejs/node/pull/32849 Refs: https://github.com/nodejs/node/issues/28803 Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/28803 PR-URL: https://github.com/nodejs/node/pull/32849 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32861 Fixes: https://github.com/nodejs/node/issues/32857 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
thecodrr authored
PR-URL: https://github.com/nodejs/node/pull/32942 Reviewed-By:
-
cjihrig authored
This release focuses on improving the robustness of the path resolution and sandboxing, including adding support for relative preopen paths. PR-URL: https://github.com/nodejs/node/pull/33078 Reviewed-By:
-
