- Apr 29, 2020
-
-
Pranshu Srivastava authored
Throws `ERR_STREAM_NULL_VALUES` error if a null value is passed to `Readable.from`. Also added docs for the same. Co-Authored-By:
扩散性百万甜面包 <himself65@outlook.com> Fixes: https://github.com/nodejs/node/issues/32845 PR-URL: https://github.com/nodejs/node/pull/32873 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
Add `stackSizeMb` to the `resourceLimit` option group. Refs: https://github.com/nodejs/node/pull/31593#issuecomment-619633820 PR-URL: https://github.com/nodejs/node/pull/33085 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Anna Henningsen authored
Mostly, this introduces a pattern that makes sure that if a custom error is reported, `stopped_` will be set to `true` correctly in every cast, which was previously missing for the `NewContext().IsEmpty()` case (which led to a hard crash from the `Worker` destructor). This also leaves TODO comments for a few cases in which `ERR_WORKER_OUT_OF_MEMORY` was not used in accordance with the documentation for that error code (or according to its intention). Fixing that is semver-major. PR-URL: https://github.com/nodejs/node/pull/33084 Reviewed-By:
-
cjihrig authored
Fix the 'uncaugth' typo in the test name. PR-URL: https://github.com/nodejs/node/pull/33083 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com>
-
Ranjan Purbey authored
In the worker pool example, the 'kWorkerFreedEvent' should be emitted in case of error as well. After adding new worker in the error handler, the pending tasks should be notified of an available worker. PR-URL: https://github.com/nodejs/node/pull/33082 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Chris Holland authored
PR-URL: https://github.com/nodejs/node/pull/33081 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Robert Nagy authored
Instead of reimplementing Writable properties, fetch them from the Writable prototype. PR-URL: https://github.com/nodejs/node/pull/33079 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/32956 Reviewed-By:
Gus Caplan <me@gus.host>
-
Ben Noordhuis authored
PR-URL: https://github.com/nodejs/node/pull/32996 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
uv_idle_init(), uv_idle_start() and uv_idle_stop() always succeed. Remove the superfluous error handling. Refs: https://github.com/libuv/libuv/pull/2803 PR-URL: https://github.com/nodejs/node/pull/32997 Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/33067 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/33072 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33077 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32964 Fixes: https://github.com/nodejs/node/issues/32947 Reviewed-By:
-
Ben Noordhuis authored
It's possible to pass in the prime and generator params as buffers but that mode of input wasn't as rigorously checked as numeric input. PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
Validate the generator argument in `crypto.createDiffieHellman(key, g)`. When it's a number, it should be an int32. Fixes: https://github.com/nodejs/node/issues/32748 PR-URL: https://github.com/nodejs/node/pull/32739 Fixes: https://github.com/nodejs/node/issues/32738 Reviewed-By:
-
Ben Noordhuis authored
The JS code accepted any value where `typeof sizeOrKey === 'number'` was true but the C++ code checked that `args[0]->IsInt32()` and subsequently aborted. Fixes: https://github.com/nodejs/node/issues/32738 PR-URL: https://github.com/nodejs/node/pull/32739 Reviewed-By:
-
Santiago Gimeno authored
Avoid sending multiple `exitedAfterDisconnect` messages when concurrently calling `disconnect()` and/or `destroy()` from the worker so `ERR_IPC_DISCONNECTED` errors are not generated. Fixes: https://github.com/nodejs/node/issues/32106 PR-URL: https://github.com/nodejs/node/pull/32793 Reviewed-By:
-
Alba Mendez authored
Some small fixes on HTTP/2 and its documentation: - Add a note that, on server streams, it's not necessary to start data flow. - Set EOF flag if we have marked all data for sending: there's no need to wait until the queue is actually empty (and send a separate, empty DATA). (Note that, even with this change, a separate DATA frame will always be sent, because the streams layer waits until data has been flushed before dispatching EOF) PR-URL: https://github.com/nodejs/node/pull/28044 Reviewed-By:
-
Sam Roberts authored
Test name test-worker-message-port-message-before-close is too long for a commit message description. Refs: https://github.com/nodejs/node/issues/31280 PR-URL: https://github.com/nodejs/node/pull/32849 Refs: https://github.com/nodejs/node/issues/28803 Reviewed-By:
-
Sam Roberts authored
Refs: https://github.com/nodejs/node/issues/28803 PR-URL: https://github.com/nodejs/node/pull/32849 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/32861 Fixes: https://github.com/nodejs/node/issues/32857 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Joyee Cheung authored
Instead of holding shared pointers to ArrayBuffers, simplify the code by using AliasedBuffers directly which allows the binding to own the buffers. PR-URL: https://github.com/nodejs/node/pull/32929 Reviewed-By:
Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By:
-
thecodrr authored
PR-URL: https://github.com/nodejs/node/pull/32942 Reviewed-By:
-
cjihrig authored
This release focuses on improving the robustness of the path resolution and sandboxing, including adding support for relative preopen paths. PR-URL: https://github.com/nodejs/node/pull/33078 Reviewed-By:
-
cjihrig authored
_start() and _initialize() shouldn't be called from the same function, as they have different behavior. Furthermore, Node should throw if both are provided. This commit updates the implementation, docs, and tests accordingly. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By:
-
cjihrig authored
Upstream WASI has renamed __wasi_unstable_reactor_start() to _initialize(). This commit updates Node's WASI implementation to reflect that change. PR-URL: https://github.com/nodejs/node/pull/33073 Reviewed-By:
-
cjihrig authored
The links for the ArrayBufferView and WebAssembly.Instance types appear to be broken. This commit updates them to point to the correct MDN locations. PR-URL: https://github.com/nodejs/node/pull/33068 Reviewed-By:
-
- Apr 28, 2020
-
-
himself65 authored
Fixes: https://github.com/nodejs/node/issues/32806 PR-URL: https://github.com/nodejs/node/pull/32810 Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Robert Nagy authored
Readable stream could emit 'end' after 'close'. PR-URL: https://github.com/nodejs/node/pull/33076 Reviewed-By:
-
Robert Nagy authored
Validate encoding passed to write(chunk, encoding, cb) and throw if it is invalid. PR-URL: https://github.com/nodejs/node/pull/33075 Reviewed-By:
-
Michaël Zasso authored
Refs: https://github.com/v8/v8/compare/8.1.307.30...8.1.307.31 PR-URL: https://github.com/nodejs/node/pull/33080 Reviewed-By:
-
Michaël Zasso authored
Notable changes: Dependencies: * Updated OpenSSL to 1.1.1g. https://github.com/nodejs/node/pull/32971 * Updated c-ares to 1.16.0. https://github.com/nodejs/node/pull/32246 * Updated experimental uvwasi to 0.0.6. https://github.com/nodejs/node/pull/32309 ESM (experimental): * Additional warnings are no longer printed for modules that use conditional exports or package name self resolution. https://github.com/nodejs/node/pull/31845 PR-URL: https://github.com/nodejs/node/pull/33009 -
Anna Henningsen authored
When cherry-picking release commits for LTS releases into master, the `REPLACEME` metadata can be taken over as well, to give users a more accurate view of what is being released on which release line. This addresses this problem for all previous LTS releases for which this has not been done. Fixes: https://github.com/nodejs/node/issues/33001 PR-URL: https://github.com/nodejs/node/pull/33041 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/33062 Reviewed-By:
-
legendecas authored
napi_async_context should be an opaque type and not be used as same as node::async_context. PR-URL: https://github.com/nodejs/node/pull/32928 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Richard Lau authored
Signed-off-by:
Beth Griggs <Bethany.Griggs@uk.ibm.com>
-
Liran Tal authored
Currently, the URL docs for the WHATWG URL spec support are somewhat lacking in their code example of how to access the new URL constructor that lives inside the core url package. PR-URL: https://github.com/nodejs/node/pull/32782 Reviewed-By:
-
Thomas authored
The previous error was wrongly redirecting users to the ICU installation steps, which is unrelated to missing Visual Studio. PR-URL: https://github.com/nodejs/node/pull/32658 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com>
-
Sam Roberts authored
It used to have some `cd` commands that if done literally would invalidate the subsequent commands. Modify them to be more accurate, which also simplifies pasting them directly into the console from the guide while doing an update. PR-URL: https://github.com/nodejs/node/pull/32977 Reviewed-By:
-
