- Apr 18, 2020
-
-
Anna Henningsen authored
Use a JS function as the single entry point for emitting `.onmessage()` calls, avoiding the overhead of manually constructing each message event object in C++. confidence improvement accuracy (*) (**) (***) worker/echo.js n=100000 sendsPerBroadcast=1 payload='object' workers=1 *** 16.34 % ±1.16% ±1.54% ±1.99% worker/echo.js n=100000 sendsPerBroadcast=1 payload='string' workers=1 *** 24.41 % ±1.50% ±1.99% ±2.58% worker/echo.js n=100000 sendsPerBroadcast=10 payload='object' workers=1 *** 26.66 % ±1.54% ±2.05% ±2.65% worker/echo.js n=100000 sendsPerBroadcast=10 payload='string' workers=1 *** 32.72 % ±1.60% ±2.11% ±2.73% worker/messageport.js n=1000000 payload='object' *** 40.28 % ±1.48% ±1.95% ±2.52% worker/messageport.js n=1000000 payload='string' *** 76.95 % ±2.19% ±2.90% ±3.75% Also fix handling exceptions returned from `MessagePort::New`. PR-URL: https://github.com/nodejs/node/pull/31605 Reviewed-By:James M Snell <jasnell@gmail.com> Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/31535 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Matteo Collina authored
A test was missing for an async iterator created after the stream had emitted 'close'. This was regressed by #31314. See: https://github.com/nodejs/node/pull/31314 PR-URL: https://github.com/nodejs/node/pull/31508 Reviewed-By:
Anatoli Papirovski <apapirovski@mac.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32883 PR-URL: https://github.com/nodejs/node/pull/32351 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com> Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
- Apr 09, 2020
-
-
Shelley Vohr authored
PR-URL: https://github.com/nodejs/node/pull/32313
-
- Apr 08, 2020
-
-
Shelley Vohr authored
Notable changes: doc: * add ronag to collaborators (Robert Nagy) [#31498](https://github.com/nodejs/node/pull/31498) * add GeoffreyBooth to collaborators (Geoffrey Booth) [#31306](https://github.com/nodejs/node/pull/31306) deps: * upgrade npm to 6.13.6 (Ruy Adorno) [#31304](https://github.com/nodejs/node/pull/31304) * update openssl to 1.1.1e (Hassaan Pasha) [#32328](https://github.com/nodejs/node/pull/32328)
-
- Apr 04, 2020
-
-
Richard Lau authored
PR-URL: https://github.com/nodejs/node/pull/32619 Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Milad Farazmand authored
Original commit message: PPC: allow for calling CFunctions without function descriptors on AIX. The calling conventions on AIX uses function descriptors, which means that pointers to functions do not point to code, but instead point to metadata about them. When calling JITed code, we must assure to use function descriptors instead of raw pointers when needed. Before this CL 213504b, all CallCFunction on AIX were guaranteed to have function descriptors. Starting form the CL mentioned above, CallCFunction can also Jump to a Trampoline which does not have a function descriptor, hence a new "CallCFunctionWithoutFunctionDescriptor" method is proposed to deal with this issue. BUG= v8:9766 Change-Id: I9343c31c812f5d4dda8503a5adf024b24dbde072 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1825961 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64357} Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c PR-URL: https://github.com/nodejs/node/pull/32619 Refs: https://github.com/v8/v8/commit/07ee86a5a28b7f9526748ca8f765c1b704f93c0c Reviewed-By:
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32610 Reviewed-By:
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 Co-Authored-By:
Geoffrey Booth <GeoffreyBooth@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/32098 Reviewed-By:
-
Nick Schonning authored
This matches what the lint-js make target passes through the CLI. Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32145 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
Rich Trott authored
Remove "obvious" and "obviously" in two places in esm.md. It may be obvious to some, but likely not everyone or else it probably wouldn't be worth mentioning/documenting. Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32457 Reviewed-By:
-
Richard Lau authored
Signed-off-by:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
-
Rich Trott authored
Simplify complex sentence. Remove use of "straightforward". Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32427 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Eric Dobbertin authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31479 Reviewed-By:
-
Jan Krems authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32068 Reviewed-By:
-
himself65 authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/32147 Reviewed-By:
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31625 Reviewed-By:
-
Guy Bedford authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32610 PR-URL: https://github.com/nodejs/node/pull/31032 Reviewed-By:
-
- Apr 02, 2020
-
-
Rich Trott authored
Update minimist used by lint-md.js to 1.2.5. Refs: https://app.snyk.io/vuln/SNYK-JS-MINIMIST-559764 Signed-off-by:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
-
Christian Clauss authored
GitHub Actions is running all tests already present on Travis, as well as building on more platforms (OS X and Windows). With Travis we're also getting timeouts more frequently than with Actions, which gives the false impression tests are failing (making it harder to triage PRs ready to merge). To make our config simpler, CI.yml and pythonpackage.yml got merged. The coverage is also increased by running tests on OS X. Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/32450 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Ben Coe <bencoe@gmail.com> Reviewed-By:
-
Richard Lau authored
Add a problem matcher for output from remark-lint to our lint-md GitHub Actions CI workflow so that any markdown linter failures are annotated in the pull request in the web UI. Signed-off-by:
Matheus Marchini <mat@mmarchini.me>
-
Richard Lau authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31504 Reviewed-By:
-
Richard Lau authored
The setup-node GitHub Action installs problem matchers that happen to match the warning message format of Visual Studio's C/C++ compiler. This is resulting in all of our pull requests being annotated with `Unchanged files with check annotations` which are confusing to new contributors as they are not due to the changes in the pull request. The action is used to run `npx envinfo` to dump some information into the logs before the actual build. All GitHub hosted runners already have a version of Node.js installed (12.x at the time of this commit) which we can use to run `envinfo`. Remove the action to avoid using the problematic problem matcher. Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31349 Fixes: https://github.com/nodejs/node/issues/31347 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
扩散性百万甜面包 authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31327 Reviewed-By:
Minwoo Jung <nodecorelab@gmail.com> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Richard Lau authored
The CI workflow doesn't use the matrix strategy so there is no `${{ matrix.node-version }}` variable to use in the `Use Node.js` step names. Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31323 Reviewed-By: -
Richard Lau authored
Add jobs to our GitHub Actions workflow to run our various lint Makefile targets. The `setup-node` action used to run the JavaScript linter contains problem matchers for eslint that will annotate the files in a pull request if there are failures. Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31323 Reviewed-By:
-
gengjiawen authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32608 PR-URL: https://github.com/nodejs/node/pull/31153 Reviewed-By:
-
ExE Boss authored
Define `util.promisify.custom` as `Symbol.for("nodejs.util.inspect.custom")`, rather than as `Symbol("util.inspect.custom")`. This allows custom `promisify` wrappers to easily/safely be defined in non‑Node.js environments. Fixes: https://github.com/nodejs/node/issues/31647 Backport-PR-URL: https://github.com/nodejs/node/pull/32349 PR-URL: https://github.com/nodejs/node/pull/31672 Reviewed-By: -
Anna Henningsen authored
Refs: https://github.com/nodejs/node/issues/29802#issuecomment-607522598 PR-URL: https://github.com/nodejs/node/pull/32607 Reviewed-By:
-
Gerhard Stoebich authored
Original commit message: Remove noscript_shared_function_infos SharedFunctionInfos that do not belong to a script were tracked in noscript_shared_function_infos. However this was only used in object-stats. Remove this since it was actually leaking memory in some use cases. Bug: v8:9674 Change-Id: I9482f7e5dedf975666a70684b3d2ea04c9a23518 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1798423 Reviewed-by:Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#63685} PR-URL: https://github.com/nodejs/node/pull/31939 Refs: https://github.com/v8/v8/commit/cb1c2b0fbfe730ed46d2b7a1ad3f58a21facc477 Refs: https://github.com/nodejs/node/issues/31914 Reviewed-By:
-
Matheus Marchini authored
While landing some of the V8 upgrades on the v12 branch, something went wrong and git made unecessary (and incorrect) whitespace changes to test fixtures, which broke V8 tests. This was likely caused by the use of `git node land` or a simiar tool. Revert those changes to fix our tests. Since this only reverts unwanted changes on deps/v8, and it only affects tests, don't bump v8_embedder_string. PR-URL: https://github.com/nodejs/node/pull/32605 Reviewed-By:
Shelley Vohr <codebytere@gmail.com>
-
Myles Borins authored
Moved emeritus members keys and fixed alphabetization issues PR-URL: https://github.com/nodejs/node/pull/32577 Reviewed-By:
-
Robert Nagy authored
pipe() ondata should not control flow state if cleaned up. Fixes: https://github.com/nodejs/node/issues/31190 Backport-PR-URL: https://github.com/nodejs/node/pull/32264 PR-URL: https://github.com/nodejs/node/pull/31191 Reviewed-By:
-
Rod Vagg authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Signed-off-by:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
Includes hardened-runtime patch from gdams from https://github.com/nodejs/node/issues/29216#issuecomment-546932966 Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
-
Ruy Adorno authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/32495 Reviewed-By:
-
Rod Vagg authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By:
-
Ben Noordhuis authored
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/32387 Refs: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/npm/cli/issues/1037 Reviewed-By:
-
Myles Borins authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32527 PR-URL: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/nodejs/node/issues/32296 Reviewed-By:
-
