- Mar 25, 2020
-
-
Robert Nagy authored
Backport-PR-URL: https://github.com/nodejs/node/pull/32372 PR-URL: https://github.com/nodejs/node/pull/32275 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Backport-PR-URL: https://github.com/nodejs/node/pull/32372
-
Rod Vagg authored
Until npm updates update-notifier to a newer version, the dependency tree will contain a version of term-size that has an unsigned macOS binary. This will fail .pkg notarization and will result in failed release builds. We built and signed a term-size and contributed it back to the project for this purpose, but the dependency chain is long enough that it's not likely to be included in a new npm very quickly. Until it is, we need to cherry-pick commit d2f08a1b ontop of any npm updates to master and any other release branch that includes notarization. PR-URL: https://github.com/nodejs/node/pull/32403 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Ash Cripps <ashley.cripps@ibm.com> Signed-off-by:
Rod Vagg <rod@vagg.org>
-
Rod Vagg authored
Includes hardened-runtime patch from gdams from https://github.com/nodejs/node/issues/29216#issuecomment-546932966 PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Reviewed-By:
-
Rod Vagg authored
PR-URL: https://github.com/nodejs/node/pull/31459 Refs: https://github.com/nodejs/node/issues/29216 Refs: https://github.com/sindresorhus/macos-term-size/pull/3 Reviewed-By:
-
Ben Noordhuis authored
These seem to have accidentally slipped into the npm source tarball and cause problems when contributors update their git checkout of node. PR-URL: https://github.com/nodejs/node/pull/32387 Refs: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/npm/cli/issues/1037 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com>
-
Myles Borins authored
PR-URL: https://github.com/nodejs/node/pull/32368 Refs: https://github.com/nodejs/node/issues/32296 Reviewed-By:
Bradley Farias <bradley.meck@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
isaacs authored
PR-URL: https://github.com/nodejs/node/pull/31977 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Rich Trott authored
Use common.mustCall() in place of countdown in test-timers-immediate-unref. PR-URL: https://github.com/nodejs/node/pull/32416 Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anna Henningsen authored
Fix the condition for deleting the underlying data pointed to by a `BaseObjectWeakPtr`, which erroneously skipped that deletion when `ptr->get()` was `nullptr`. This fixes a memory leak reported by some of the tests. Refs: https://github.com/nodejs/node/pull/30374#issuecomment-601848973 PR-URL: https://github.com/nodejs/node/pull/32393 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32407 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/32400 PR-URL: https://github.com/nodejs/node/pull/32405 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
Sam Roberts authored
In openssl-1.1.1e the client doesn't seem to like having the TLS connection shut down with no data sent, so send an empty string. A number of related issues showed up in the TLS1.3 port, so this is not entirely surprising. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This test was timing out after update to OpenSSL-1.1.1e. PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/include PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Hassaan Pasha authored
The scripts used by make were modified to correctly reference the source files that were originially in crypto/include/internal, but got moved to include/crypto. The base path has been left unaltered since that would require too many changes PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By:
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1e.tar.gz $ mv openssl-1.1.1e openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32328 Fixes: https://github.com/nodejs/node/issues/32210 Reviewed-By: -
Jan Krems authored
PR-URL: https://github.com/nodejs/node/pull/32068 Reviewed-By:
Geoffrey Booth <webmaster@geoffreybooth.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
-
Matheus Marchini authored
This reverts commit 3ec4b21b. See: https://github.com/nodejs/node/issues/32257 PR-URL: https://github.com/nodejs/node/pull/32324 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Gabriel Schulhof <gabriel.schulhof@intel.com>
-
- Mar 24, 2020
-
-
Anna Henningsen authored
There’s no need to use `Isolate::GetCurrent()`, which is generally discouraged, as the `Isolate*` pointer can generally be looked up from the per-Isolate platform data structure. PR-URL: https://github.com/nodejs/node/pull/32269 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31502#issuecomment-599242824 PR-URL: https://github.com/nodejs/node/pull/32300 Reviewed-By:
-
Steven R. Loomis authored
- ICU 66.1 http://site.icu-project.org/download/66 - Unicode 13 - CLDR 36.1 - Updated ./LICENSE PR-URL: https://github.com/nodejs/node/pull/32348 Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
-
Steven R. Loomis authored
- Docs used the word "copy" when it really meant a tool is needed. - README-FULL-ICU.txt was generated in binary mode, but it's a text file. This breaks on Python3 for maintaining ICU - The ICU downloader was broken (also probably python3). It's basically dead code since 1a25e901 landed (full icu in repo), unless someone deleted the deps/icu-small directory from their repo. Co-Authored-By:
-
Sam Roberts authored
There is lots of space to expand this not-so-well-known acronym in the option usage message. PR-URL: https://github.com/nodejs/node/pull/32325 Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
-
Gabriel Schulhof authored
This adds the new option `HUGEPAGES` to `NODE_DEBUG_NATIVE` that causes the code responsible for re-mapping to large pages to output memory range and page count information to `stderr`. Signed-off-by:
-
Xu Meng authored
When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: https://github.com/nodejs/node/pull/32338 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32251 Reviewed-By:
-
Anna Henningsen authored
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: https://github.com/nodejs/node/pull/32246 Reviewed-By:
-
Anna Henningsen authored
They do the same thing, but OnScopeLeave avoids an extra heap allocation and is more explicit about what it does. PR-URL: https://github.com/nodejs/node/pull/32247 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/31679 Reviewed-By:
-
James M Snell authored
Signed-off-by:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32309 Reviewed-By:
-
Jonathan MERCIER authored
PR-URL: https://github.com/nodejs/node/pull/31659 Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32200 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Gabriel Schulhof authored
We have received feedback indicating that the N-API support matrix as present now can be misinterpreted to mean that old versions of N-API are no longer supported on newer versions of Node.js. Filling out the bottom of the matrix should hopefully make it clear that support for such old versions continues. PR-URL: https://github.com/nodejs/node/pull/32304 Reviewed-By:
Chengzhong Wu <legendecas@gmail.com> Reviewed-By:
-
Gus Caplan authored
Adds `--disable-proto` CLI option which can be set to `delete` or `throw`. Fixes #31951 PR-URL: https://github.com/nodejs/node/pull/32279 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com>
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32276 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Rich Trott authored
We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
