- Jan 25, 2017
-
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10874 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10927 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
dcposch@dcpos.ch authored
PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
Roman Reiss <me@silverwind.io> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com> Reviewed-By:
Trevor Norris <trev.norris@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
dcposch@dcpos.ch authored
PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
-
dcposch@dcpos.ch authored
Test type coercion for non-number offset arguments. Verify that Buffer and String behave the same way. PR-URL: https://github.com/nodejs/node/pull/10162 Fixes: https://github.com/nodejs/node/issues/9801 Reviewed-By:
-
John Barboza authored
When the double dash "--" appears after "-e <script>" on the command line, it indicates the end of options and the beginning of positional parameters for the script. PR-URL: https://github.com/nodejs/node/pull/10651 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
-
Travis Meisenheimer authored
Fixes coverity scan issue 55489. PR-URL: https://github.com/nodejs/node/pull/10891 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Adam Majer authored
PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Adam Majer authored
NodeJS can already use an external, shared OpenSSL library. This library knows where to look for OS managed certificates. Allow a compile-time option to use this CA store by default instead of using bundled certificates. In case when using bundled OpenSSL, the paths are also valid for majority of Linux systems without additional intervention. If this is not set, we can use SSL_CERT_DIR to point it to correct location. Fixes: https://github.com/nodejs/node/issues/3159 PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
-
Adam Majer authored
The pointer to std::vector is unnecessary, so replace it with standard instance. Also, make the for() loop more readable by using actual type instead of inferred - there is no readability benefit here from obfuscating the type. PR-URL: https://github.com/nodejs/node/pull/8334 Reviewed-By:
-
Vse Mozhet Byt authored
* var -> const / let in crypto.md * fix error in crypto.md code example * equal -> strictEqual, == -> === in crypto.md * update estimated outputs in crypto.md * snake_case -> camelCase in crypto.md examples * concatenation -> multiline template in crypto * add missing line break in crypto code example * add missing link reference in crypto.md PR-URL: https://github.com/nodejs/node/pull/10909 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
- Jan 24, 2017
-
-
Evan Lucas authored
This commit removes the topics and guides that the documentation working group has proposed added to the website. We want them to have more visibility and believe that moving them to the website does that. Ref: https://github.com/nodejs/nodejs.org/pull/1105 Fixes: https://github.com/nodejs/node/issues/10792 PR-URL: https://github.com/nodejs/node/pull/10896 Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
-
abouthiroppy authored
Refs: https://github.com/nodejs/node/blob/09ebdf14005cc948529b3f193ad550d5dfded26a/lib/dgram.js#L234 PR-URL: https://github.com/nodejs/node/pull/10901 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
legalcodes authored
Add a RegExp to `throws` assertions. PR-URL: https://github.com/nodejs/node/pull/10914 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
richnologies authored
Add RegExp to check assert throws the expected AssertionErrors. For the one with multiple flags is ok to hardcode the flags since the spec indicates the ordering will always be `gim`: Refs: http://www.ecma-international.org/ecma-262/6.0/#sec-get-regexp.prototype.flags PR-URL: https://github.com/nodejs/node/pull/10916 Reviewed-By:
-
abouthiroppy authored
Added test cases for error. PR-URL: https://github.com/nodejs/node/pull/10940 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Timothy Gu authored
The Web IDL spec mandates such a check. Also make error messages consistent with rest of Node.js and add additional tests for forEach(). PR-URL: https://github.com/nodejs/node/pull/10905 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* use common.mustCall to validate functions executions * use common.fail to check test fail * remove console.log * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10845 Reviewed-By:
-
Sam Roberts authored
The Hmac binding layer is not documented as part of the API, and is not intended to be used, but it should be robust to misuse, and contains defensive checks for misuse. This test checks that updates without init throw (as opposed to abort or misbehave in some other way). PR-URL: https://github.com/nodejs/node/pull/10923 Reviewed-By:
-
John Barboza authored
Don't do a write on stdout/stderr because that checks for their writability. But fd=1 could legitimately be opened with read-only access by the user. All this test needs to ensure is that they are used at startup. PR-URL: https://github.com/nodejs/node/pull/10339 Fixes: https://github.com/nodejs/node/issues/10234 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/10898 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/10620 Reviewed-By:
Timothy Gu <timothygu99@gmail.com>
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/10620 Reviewed-By:
-
cjihrig authored
This commit adds code coverage to the internals associated with the child_process shell option. This achieves the following: - Increased code coverage, which is currently only reported for Unix. - Ensures that all six code paths are covered, including the three Windows variations, and Android which is not tested at all on CI. PR-URL: https://github.com/nodejs/node/pull/10924 Reviewed-By:
-
Daniel Bevenius authored
The req_wrap_obj is only used in one place which is setting up the arguments for the MakeCallback call. Removing it to simplify the code somewhat. PR-URL: https://github.com/nodejs/node/pull/10942 Reviewed-By:
-
Alexey Orlenko authored
This commit makes a small stylistic fix adding a missing space in GetOSType function in node_os.cc PR-URL: https://github.com/nodejs/node/pull/10931 Reviewed-By:
-
Noah Rose Ledesma authored
Changed authors listing from `Noah Rose` to `Noah Rose Ledesma`. PR-URL: https://github.com/nodejs/node/pull/10945 Reviewed-By:
-
cjihrig authored
This commit adds a description of the NODE_NO_WARNINGS environment variable to the --help output. This was overlooked in 49902124. Refs: https://github.com/nodejs/node/pull/10842 PR-URL: https://github.com/nodejs/node/pull/10918 Reviewed-By:
-
- Jan 23, 2017
-
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/10899 Reviewed-By:
-
Joyee Cheung authored
* Add benchmarks for diffing a previous result * Improvements to the documentation, including type annotation * Update the outdated comments in src/node.cc, improve comments in lib/internal/process.js * Check the argument is an Array Tuple with length 2 PR-URL: https://github.com/nodejs/node/pull/10764 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10895 Reviewed-By:
Evan Lucas <evanlucas@me.com> Reviewed-By:
-
Adam Langley authored
The freelist_max_len member of SSL* (and the freelist itself) has been removed in OpenSSL 1.1.0. Thus this change will be necessary at some point but, for now, it makes it a little easier to build with 1.1.0 without breaking anything for previous versions of OpenSSL. PR-URL: https://github.com/nodejs/node/pull/10859 Reviewed-By:
Shigeki Ohtsu <ohtsu@ohtsu.org>
-
Rich Trott authored
* set an identifier for the separator rather than using multiple instances of the same literal * consistent arrow function body formatting PR-URL: https://github.com/nodejs/node/pull/10912 Reviewed-By:
-
Rich Trott authored
Even after being moved to `sequential` in 1ce05ad5, `test-regress-GH-897` still was occasionally flaky on Raspberry Pi devices on CI. The test is especially sensitive to resource constraints. It failed reliably on my laptop if I moved it to `parallel` and ran 32 competing node test processes. Even for a flaky test, that's unusually low. I typically don't see problems, even for flaky tests, until I get up to around four times that number. On a Raspberry Pi, of course, that sensitivity to resource constraints will manifest much sooner. This change checks the order of timers firing, rather than the duration before a timer is fired. This eliminates the sensitivity to resource constraints. The test can now be moved back to `parallel`. I am able to run many copies of the test simultaneously without seeing test failures. PR-URL: https://github.com/nodejs/node/pull/10903 Fixes: https://github.com/nodejs/node/issues/10073 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Gibson Fahnestock authored
If a test does http.listen(0) or net.listen(0), http.listen(0).address().address returns '::'. Some machines will resolve this to localhost, but not all. Every machine should have localhost defined in /etc/hosts (or equivalent), so it should always resolve. Fixes: https://github.com/nodejs/node/issues/7291 PR-URL: https://github.com/nodejs/node/pull/10854 Reviewed-By:
-
Birunthan Mohanathas authored
This fixes compilation errors like: node\src\node_url.cc(134) : error C4716: 'node::url::ToUnicode': must return a value PR-URL: https://github.com/nodejs/node/pull/10893 Reviewed-By:
-
Timothy Gu authored
PR-URL: https://github.com/nodejs/node/pull/10954 Reviewed-By:
-
Vinícius do Carmo authored
* use arrow funcion instead of function expression * add second argument to method assert.throws * check error messages from beginning to the end using ^ and $ PR-URL: nodejs#10908 Reviewed-By:
Adrian Estrada <edsadr@gmail.com> Reviewed-By:
-
- Jan 22, 2017
-
-
abouthiroppy authored
Test that an error is thrown when bind() is called on an already bound socket. PR-URL: https://github.com/nodejs/node/pull/10894 Reviewed-By:
Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By:
-
abouthiroppy authored
validateHeader: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L376 write: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L477 addTrailers: https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L557 PR-URL: https://github.com/nodejs/node/pull/10820 Reviewed-By:
-
