- Apr 23, 2020
-
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/32381 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Anna Henningsen authored
Refs: https://github.com/nodejs/node/pull/31502#issuecomment-599242824 PR-URL: https://github.com/nodejs/node/pull/32300 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Sam Roberts authored
There is lots of space to expand this not-so-well-known acronym in the option usage message. PR-URL: https://github.com/nodejs/node/pull/32325 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Xu Meng authored
When TTY initialization failed, uv_tty_init returned EBADF on IBM i PASE, rather than EINVAL PR-URL: https://github.com/nodejs/node/pull/32338 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Anna Henningsen authored
Refs: https://github.com/c-ares/c-ares/releases/tag/cares-1_16_0 PR-URL: https://github.com/nodejs/node/pull/32246 Reviewed-By:
-
Sam Roberts authored
PR-URL: https://github.com/nodejs/node/pull/31679 Reviewed-By:
-
cjihrig authored
PR-URL: https://github.com/nodejs/node/pull/32309 Reviewed-By:
-
Jonathan MERCIER authored
PR-URL: https://github.com/nodejs/node/pull/31659 Reviewed-By:
Christian Clauss <cclauss@me.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Thomas Watson authored
PR-URL: https://github.com/nodejs/node/pull/32200 Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Rich Trott authored
We have several tests where a number of asynchronous processes need to finish before some checks happen. These are done in a number of ways, including (as here) using our Countdown testing module. I think Promise.all() may be the idiomatic and ergonomic way to go for a lot of these tests. Using this one to get feedback on the idea. PR-URL: https://github.com/nodejs/node/pull/32273 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32230 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Sam Roberts authored
The maintainenance guides are mostly in doc/guides-maintaining-*.md, so move the OpenSSL one there, too. PR-URL: https://github.com/nodejs/node/pull/32209 Reviewed-By:
-
Matheus Marchini authored
`test-inspector-multisession-ws` and `test-inspector-break-when-eval` will be affected by an upstream bug when we upgrade V8 to 8.1. The bug is caused when the Inspector sets a pause at the start of a function compiled with `CompileFunctionInContext`, but that function hasn't been executed yet. On both tests, this issue is triggered by pausing while in C++ executing LookupAndCompile, which is called by requiring internal modules while running `console.log`. To eliminate this issue in both tests, we add an extra `console.log` to ensure we only pause we required all internal modules we need. On `test-inspector-break-when-eval`, we also need to start the child process with `--inspect-brk` instead of `--inspect` to ensure the test is predictable (this test would occasianlly fail on slower machines, when console.log doesn't run fast enough to finish after emitting `Runtime.consoleAPICalled` and before the parent process sending `Runtime.evaluate` message. Ref: https://bugs.chromium.org/p/v8/issues/detail?id=10287 PR-URL: https://github.com/nodejs/node/pull/32234 Refs: https://bugs.chromium.org/p/v8/issues/detail?id=10287 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
-
- Apr 22, 2020
-
-
cjihrig authored
../src/node_file.cc:386:7: warning: ignoring return value of function declared with 'warn_unused_result' attribute [-Wunused-result] PR-URL: https://github.com/nodejs/node/pull/32241 Refs: https://github.com/nodejs/node/pull/31972 Reviewed-By:
-
Rich Trott authored
Update acorn to 7.1.1 in the dev dependencies for the markdown linter. Refs: https://app.snyk.io/vuln/SNYK-JS-ACORN-559469 Signed-off-by:
Rich Trott <rtrott@gmail.com> PR-URL: https://github.com/nodejs/node/pull/32259 Reviewed-By:
-
Bradley Farias authored
PR-URL: https://github.com/nodejs/node/pull/32203 Fixes: https://github.com/nodejs/node/issues/32199 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Matheus Marchini authored
Original commit message: Fix scanner-level error reporting for hashbang When the file begins with a hashbang, the scanner is in a failed state when SkipHashbang() is called. This is usually not an issue but when the parser encounters an ILLEGAL token, it will reset the SyntaxError location because of it. Bug: v8:10110 Change-Id: I1c7344bf5ad20079cff80130c991f3bff4d7e9a8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1995312 Reviewed-by:Toon Verwaest <verwaest@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#66038} Refs: https://github.com/v8/v8/commit/f9257802c1c0a0663a1d05bacf662283f6bd9050 Fixes: https://github.com/nodejs/node/issues/31284 Signed-off-by:
Matheus Marchini <mmarchini@netflix.com> PR-URL: https://github.com/nodejs/node/pull/32180 Reviewed-By:
-
Mateusz Krawczuk authored
This change is to prevent potential bugs - e.g., someone might automatically use the variable `k` instead of `key`, that is used in vicinity of this loop. Also changed postincrement to preincrement in iteration steps. It is probably done by the optimizer anyway, but otherwise it will save an opcode each iteration. And it is a good practice. PR-URL: https://github.com/nodejs/node/pull/32012 Reviewed-By:
-
Harshitha KP authored
The test wanted to cut huge string into 1KB strings, for which a new line character was inserted at appropriate places. The value is different in Windows (10, 13). Make it portable, by making use of os.EOL semantics Refs: https://github.com/nodejs/node/issues/25988 PR-URL: https://github.com/nodejs/node/pull/32104 Reviewed-By:
-
Bartosz Sosnowski authored
Document Windows specific fs.watch caveats. Fixes: https://github.com/nodejs/node/issues/31702 PR-URL: https://github.com/nodejs/node/pull/32176 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
-
Ben Noordhuis authored
Different parts of the debug build were using differently sized std::vectors due to `_GLIBCXX_DEBUG` sometimes being defined and sometimes not. That ended about as well as you would expect. Remove the flag. Fixes: https://github.com/nodejs/node/issues/30056 PR-URL: https://github.com/nodejs/node/pull/30147 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32125 Reviewed-By:
-
Harshitha KP authored
Make sure longer strings are written up to the buffer end Refs: https://github.com/nodejs/node/pull/32119 PR-URL: https://github.com/nodejs/node/pull/32123 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32087 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
-
Eric Bickle authored
Fixes broken unit test for the NODE_EXTRA_CA_CERTS environment variable. Unit test was exiting without evaluating any assertions or running any tests. Fixes: https://github.com/nodejs/node/issues/32072 PR-URL: https://github.com/nodejs/node/pull/32073 Reviewed-By:
-
Michael Dawson authored
Signed-off-by:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Rich Trott authored
I sent an email to inactive collaborators (in the previous 6 months at the time, no commits, no PRs reviewed, and no commits landed) asking if it was time to move to emeritus. Some replied affirmatively and I have moved those people to emeritus. Others replied indicating a desire to remain collaborators, and I left them as collaborators. The remaining folks are being moved to emeritus in this change. Signed-off-by:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Yuta Hiroto <hello@hiroppy.me> Reviewed-By:
-
Ben Noordhuis authored
We might not have sufficient privileges to signal the child process so don't make assumptions about the return value of `uv_process_kill()`. Example: node -e 'child_process.spawnSync("sudo", ["ls"], { maxBuffer: 1 })' No test because: 1. The test needs to run as root (can't invoke sudo), and 2. The parent needs to drop privileges but can't, because then the child process won't have sufficient privileges. Fixes: https://github.com/nodejs/node/issues/31747 PR-URL: https://github.com/nodejs/node/pull/31768 Reviewed-By:Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/31952 Reviewed-By:
-
Gerhard Stoebich authored
Wrap reused read_wrap in a unique async resource to ensure that executionAsyncResource() is not ambiguous. PR-URL: https://github.com/nodejs/node/pull/31972 Refs: https://github.com/nodejs/node/pull/30959 Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
Joe Pea authored
PR-URL: https://github.com/nodejs/node/pull/32152 Reviewed-By:
-
Denys Otrishko authored
Fixes: https://github.com/nodejs/node/issues/20605 Refs: https://github.com/libuv/libuv/pull/1837 PR-URL: https://github.com/nodejs/node/pull/32091 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Sam Roberts authored
It was not possible to understand which, if either, of the sentences after the first ("Windows does not... emulation") apply specifically to Windows. Specifically, `kill(pid, 0)` works on Linux and Windows and I couldn't find it documented anywhere else, but the unconditional termination occurs only on Windows. PR-URL: https://github.com/nodejs/node/pull/32079 Reviewed-By: -
Eric Bickle authored
Fixes tls.rootCertificates missing certificates loaded from NODE_EXTRA_CA_CERTS. Fixes: https://github.com/nodejs/node/issues/32074 PR-URL: https://github.com/nodejs/node/pull/32075 Reviewed-By:
-
Anna Henningsen authored
Various improvements to the Buffer docs. PR-URL: https://github.com/nodejs/node/pull/32086 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31911 Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/31883 Reviewed-By:
-
Harshitha KP authored
fixes: https://github.com/nodejs/node/issues/31661 PR-URL: https://github.com/nodejs/node/pull/31865 Fixes: https://github.com/nodejs/node/issues/31661 Reviewed-By:
-
David Gilbertson authored
Tables on some pages (e.g. https://nodejs.org/api/crypto.html) are quite wide because of long content (e.g. URLs) that don't break. With this change, cell padding is smaller on small screens, and the table content is allowed to break. PR-URL: https://github.com/nodejs/node/pull/31859 Reviewed-By:
-
Ben Noordhuis authored
Turn the `strategy_` method pointer into an enum-based static dispatch. It's both safer and more secure (no chance of method pointer corruption) and it helps GCC see that the shift and suffix tables it's complaining about are unused in single char search mode. Fixes the following warning: ../src/string_search.h:113:30: warning: ‘search’ may be used uninitialized in this function [-Wmaybe-uninitialized] return (this->*strategy_)(subject, index); Fixes: https://github.com/nodejs/node/issues/26733 Refs: https://github.com/nodejs/node/pull/31532 Refs: https://github.com/nodejs/node/pull/31798 PR-URL: https://github.com/nodejs/node/pull/31809 Reviewed-By:Denys Otrishko <shishugi@gmail.com> Reviewed-By:
-
