- Aug 17, 2021
-
-
Himadri Ganguly authored
PR-URL: https://github.com/nodejs/node/pull/39604 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Robert Nagy authored
Adds did read accessor used to determine whether a readable has been read from. PR-URL: https://github.com/nodejs/node/pull/39589 Refs: https://github.com/nodejs/undici/pull/907 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Antoine du Hamel authored
PR-URL: https://github.com/nodejs/node/pull/39504 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
James M Snell authored
Signed-off-by:
James M Snell <jasnell@gmail.com> Fixes: https://github.com/nodejs/node/issues/39548 PR-URL: https://github.com/nodejs/node/pull/39550 Reviewed-By:
Bryan English <bryan@bryanenglish.com> Reviewed-By:
Chengzhong Wu <legendecas@gmail.com>
-
Rich Trott authored
This adds test coverage to `unpackError()` in `lib/internal/debugger/inspect_client.js`. That function previously was untested. PR-URL: https://github.com/nodejs/node/pull/39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Rich Trott authored
The data parameter of unpackError() is typically undefined. PR-URL: https://github.com/nodejs/node/pull/39570 Refs: https://github.com/nodejs/node-inspect/issues/101 Reviewed-By:
Jan Krems <jan.krems@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Mestery authored
Use ERR_ILLEGAL_CONSTRUCTOR error instead of `illegal constructor` or `Illegal constructor` TypeError. PR-URL: https://github.com/nodejs/node/pull/39556 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
Refs: https://github.com/nodejs/node/issues/39555 PR-URL: https://github.com/nodejs/node/pull/39557 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Ash Cripps authored
Update the minimum macos version that can compile to match the xcode requirements. Also move mac arm64 to tier 1. refs: https://github.com/nodejs/node/issues/39584#issuecomment-889701855 PR-URL: https://github.com/nodejs/node/pull/39586 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Richard Lau authored
Fixes doc build warnings: ``` Failed to add alternative version links to webstreams Failed to add alternative version links to async_context ``` PR-URL: https://github.com/nodejs/node/pull/39575 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Darshan Sen <raisinten@gmail.com>
-
Rich Trott authored
The email address for Weijia Wang in the AUTHORS and .mailmap files is different from the email address in the README.md file. Based on their GitHub profile and commit metadata, the one in the README.md file is the preferred email. Updating .mailmap and AUTHORS to reflect it. PR-URL: https://github.com/nodejs/node/pull/39505 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Weijia Wang <starkwang@126.com>
-
Rich Trott authored
Ignore all markdown files when determining if test-asan, coverage-*, and test-macos need to run. Refs: https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions#patterns-to-match-file-paths PR-URL: https://github.com/nodejs/node/pull/39565 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Rich Trott authored
Add mailmap entry for garygsc and re-run AUTHORS to remove duplicate entry. PR-URL: https://github.com/nodejs/node/pull/39588 Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Add mailmap entry for ttzztztz and re-run AUTHORS to remove duplicate entry. PR-URL: https://github.com/nodejs/node/pull/39588 Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39587 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/39491 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
legendecas authored
PR-URL: https://github.com/nodejs/node/pull/39532 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Khaidi Chu <i@2333.moe>
-
Jordan Harband authored
PR-URL: https://github.com/nodejs/node/pull/39583 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Ash Cripps <acripps@redhat.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39561 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39560 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Richard Lau authored
Move the section on `NODE_MODULE_VERSION` into the section for major releases as it should only be updated for a major release. Add a note to remove the `-pre` suffix from the registry for the release commit. PR-URL: https://github.com/nodejs/node/pull/39544 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Lau authored
We no longer produced ARMv6 builds, and the ARMv7 builds are now cross compiled and are as quick as builds on the other platforms. PR-URL: https://github.com/nodejs/node/pull/39544 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Lau authored
Put the command examples for finding and replacing the `REPLACEME` tags into code fences so that they are more easily copiable when viewing the guide in the GitHub web UI. PR-URL: https://github.com/nodejs/node/pull/39544 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Richard Lau authored
Add `backport-open-v1.x,backported-to-v1.x` labels to `branch-diff` commands as these indicate pull requests that are being manually backported and should not be cherry-picked. PR-URL: https://github.com/nodejs/node/pull/39544 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
Danielle Adams <adamzdanielle@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/39559 Reviewed-By:
Ricky Zhou <0x19951125@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Zijian Liu <lxxyxzj@gmail.com>
-
Rich Trott authored
Rather than hard-coding GitHub Actions to use Node.js 14.x, use the `lts/*` shorthand for "most recent LTS version". PR-URL: https://github.com/nodejs/node/pull/39538 Reviewed-By:
Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/39459 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Darshan Sen authored
Signed-off-by:
Darshan Sen <darshan.sen@postman.com> PR-URL: https://github.com/nodejs/node/pull/38468 Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Lew Gordon authored
This change properly decodes the url.username and url.password for the authorization header constructed from the URL object for http(s) requests. Fixes: https://github.com/nodejs/node/issues/31439 PR-URL: https://github.com/nodejs/node/pull/39310 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/39454 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/39455 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
Update email for Ujjwal Sharma. PR-URL: https://github.com/nodejs/node/pull/39521 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Update email for Shelley Vohr to correspond to what is specified in .mailmap and what is used in more recently authored commits. PR-URL: https://github.com/nodejs/node/pull/39521 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
Update email for Zeyu Yang. PR-URL: https://github.com/nodejs/node/pull/39521 Reviewed-By:
Zeyu Yang <himself65@outlook.com> Reviewed-By:
Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
cjihrig authored
Update ESLint to 7.31.0 PR-URL: https://github.com/nodejs/node/pull/39424 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
James M Snell <jasnell@gmail.com>
-
Rich Trott authored
George does not appear to be active in Node.js for quite some time (correction welcome!) and my attempts to get in touch have failed. PR-URL: https://github.com/nodejs/node/pull/39539 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Richard Lau <rlau@redhat.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Beth Griggs <bgriggs@redhat.com> Reviewed-By:
George Adams <george.adams@microsoft.com> Reviewed-By:
Stewart X Addison <sxa@redhat.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Myles Borins <myles.borins@gmail.com> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Michael Dawson <midawson@redhat.com>
-
legendecas authored
The option buffered is not about queueing the PerformanceEntrys with an event loop task or not. The option buffered in the spec is about filling the observer with the global PerformanceEntry buffer. The current (and the spec) behavior is different with Node.js version <= v16.0.0. PR-URL: https://github.com/nodejs/node/pull/39514 Refs: https://w3c.github.io/performance-timeline/#observe-method Refs: https://nodejs.org/dist/latest-v14.x/docs/api/perf_hooks.html#perf_hooks_performanceobserver_observe_options Refs: https://github.com/nodejs/node/pull/39297 Reviewed-By:
Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
legendecas authored
All API introduced in this PR are compliant with web [performance-timeline](https://w3c.github.io/performance-timeline) spec. "performance-timeline" is listed as supported web spec in the doc https://nodejs.org/docs/latest/api/perf_hooks.html#perf_hooks_performance_measurement_apis. Changes summary: 1. Add new supported wpt test subsets: user-timing and performance-timeline. 2. Add support for `Performance.getEntries`, `Performance.getEntriesByName` and `Performance.getEntriesByType` to synchronously fetch buffered performance entries. This means the user should invoke `Performance.clearMarks` and `Performance.clearMeasures` to clear buffered entries to prevent from those entries been kept alive forever. 3. Add support (again after https://github.com/nodejs/node/pull/37136) for `buffered` flags for `PerformanceObserver`. 3. Fixes `PerformanceMark` and `PerformanceMeasure` wpt compliance issues. 4. Only user-created performance entries will be buffered globally. This behavior should be compliant with https://w3c.github.io/timing-entrytypes-registry/#registry. With the new ability to fetch user-created performance entries synchronously, the issues raised in https://github.com/nodejs/diagnostics/issues/464#issuecomment-861920116 could also be fixed. PR-URL: https://github.com/nodejs/node/pull/39297 Reviewed-By:
James M Snell <jasnell@gmail.com>
-
- Aug 11, 2021
-
-
Beth Griggs authored
PR-URL: https://github.com/nodejs-private/node-private/pull/280
-
Beth Griggs authored
This is a security release. Notable Changes: - CVE-2021-3672/CVE-2021-22931: Improper handling of untypical characters in domain names (High) - CVE-2021-22930: Use after free on close http2 on stream canceling (High) - CVE-2021-22939: Incomplete validation of rejectUnauthorized parameter (Low) PR-URL: https://github.com/nodejs-private/node-private/pull/280
-