Commits · 16b32eae3e76348c954e46965739fbfb91d097bd · github.com / v8-riscv / node

Jul 16, 2020

quic: handle unhandled rejections on QuicSession · 16b32eae

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

16b32eae

quic: fixup kEndpointClose · e5d963e2

James M Snell authored Jul 09, 2020

Ensure that the QuicSocket is properly destroyed if the QuicEndpoint
is destroyed directly rather than through QuicSocket destroy

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

e5d963e2

quic: fix endpointClose error handling, document · 9f552df5

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

9f552df5

quic: restrict addEndpoint to before QuicSocket bind · b80108c0

James M Snell authored Jul 09, 2020

Restricting this to pre-bind keeps things simple

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

b80108c0

quic: use a getter for stream options · 81c01bbd

James M Snell authored Jul 09, 2020

Doesn't need to be a function

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

81c01bbd

quic: clarifying code comments · b8945ba2

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

b8945ba2

quic: minor reduction in code duplication · 429ab1dc

James M Snell authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

429ab1dc

quic: replace ipv6Only option with `'udp6-only'` type · aafdc2fc

James M Snell authored Jul 09, 2020

Since the `ipv6Only` option was mutually exclusive with
using `'udp6'`, making it it's own type simplifies things
a bit.

PR-URL: https://github.com/nodejs/node/pull/34283


Reviewed-By: Anna Henningsen <anna@addaleax.net>

aafdc2fc

stream: rename opts to options · 48404a17

rickyes authored Jul 13, 2020

PR-URL: https://github.com/nodejs/node/pull/34339
Refs: https://nodejs.org/dist/latest-v14.x/docs/api/stream.html#stream_stream_finished_stream_options_callback


Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

48404a17

quic: clear clang warning · fbc38ee1

gengjiawen authored Jul 13, 2020

PR-URL: https://github.com/nodejs/node/pull/34335


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>

fbc38ee1

doc: fix typo in assert.md · 9fc87789

Ye-hyoung Kang authored Jul 12, 2020

PR-URL: https://github.com/nodejs/node/pull/34316


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

9fc87789

http2: add support for sensitive headers · e876c0c3

Anna Henningsen authored Jul 01, 2020

Add support for “sensitive”/“never-indexed” HTTP2 headers.

Fixes: https://github.com/nodejs/node/issues/34091

PR-URL: https://github.com/nodejs/node/pull/34145


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

e876c0c3

vm: add tests for function declarations using [[DefineOwnProperty]] · 9ae84912

ExE Boss authored Jun 23, 2020

Refs: https://github.com/nodejs/node/issues/31808

PR-URL: https://github.com/nodejs/node/pull/34032


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>

9ae84912

doc,tools: syntax highlight api docs at compile-time · fa2e460d

Francisco Ryan Tolmasky I authored Jun 30, 2020

Prior to this commit, API docs would be highlighted after the page
loaded using `highlightjs`. This commit still uses `highlightjs`, but
runs the generation during the compilation of the documentation, making
it so no script needs to load on the client. This results in a faster
load, as well as allowing the pages to fully functional even when
JavaScript is turned off.

PR-URL: https://github.com/nodejs/node/pull/34148


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

fa2e460d

stream: try to wait for flush to complete before 'finish' · a65218f5

Robert Nagy authored Jul 11, 2020

Due to compat reasons Transform streams don't always wait
for flush to complete before finishing the stream.

Try to wait when possible, i.e. when the user does not
override _final.

Fixes: https://github.com/nodejs/node/issues/34274

PR-URL: https://github.com/nodejs/node/pull/34314


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

a65218f5

test: fix flaky test-net-connect-econnrefused · e44855d3

Rich Trott authored Jul 12, 2020

Test is flaky in CI with `common.PORT` but not flaky if a port is
determined from createServer() first.

PR-URL: https://github.com/nodejs/node/pull/34330


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

e44855d3

Jul 15, 2020

module: update expected module.parent DEP number · 128ed10f

Beth Griggs authored Jul 14, 2020

PR-URL: https://github.com/nodejs/node/pull/34368


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

128ed10f

doc: sync deprecation numbers with v14.x · 21838121

Beth Griggs authored Jul 14, 2020

Syncs master and v14.x for DEP0143 - `Transform._transformState`.
Bumps `module.parent` from DEP0143 to DEP0144 on master. Adds
missing DEP number and  metadata for DEP0145: `socket.bufferSize`.

PR-URL: https://github.com/nodejs/node/pull/34368


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>

21838121

test: use mustCall() in pummel test · 3b130327

Rich Trott authored Jul 12, 2020

Replace 'exit' check with common.mustCall().

PR-URL: https://github.com/nodejs/node/pull/34327


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

3b130327

policy: add startup benchmark and make SRI lazier · 66810a0d

Bradley Farias authored Sep 11, 2019

PR-URL: https://github.com/nodejs/node/pull/29527


Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

66810a0d

Jul 14, 2020

doc: clarify conditional exports guidance · e212955e

Guy Bedford authored Jul 10, 2020

PR-URL: https://github.com/nodejs/node/pull/34306


Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jan Krems <jan.krems@gmail.com>

e212955e

Revert "http2: streamline OnStreamRead streamline memory accounting" · e1b336ff

Rich Trott authored Jul 11, 2020

This reverts commit 51ccf1b5.

Fixes: https://github.com/nodejs/node/issues/31089

PR-URL: https://github.com/nodejs/node/pull/34315


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>

e1b336ff

doc: add danielleadams to collaborators · 9c11d5ce

Danielle Adams authored Jul 14, 2020

PR-URL: https://github.com/nodejs/node/pull/34360


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>

9c11d5ce

repl: support --loader option in builtin REPL · 05539c16

Michaël Zasso authored May 16, 2020

Fixes: https://github.com/nodejs/node/issues/33435

PR-URL: https://github.com/nodejs/node/pull/33437


Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

05539c16

test: fix flaky test-http2-reset-flood · 4195c31e

Rich Trott authored Jul 11, 2020

Set `allowHalfOpen: true` in the client.

Fixes: https://github.com/nodejs/node/issues/29802
Refs: https://github.com/nodejs/node/pull/31806

PR-URL: https://github.com/nodejs/node/pull/34318


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Robert Nagy <ronagy@icloud.com>

4195c31e

src,doc,test: remove String::New default parameter · a0381992

Anna Henningsen authored Jul 07, 2020

`kNormal` has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

a0381992

meta: make issue template mobile friendly and address nits · 2a29650e

Derek Lewis authored Jul 07, 2020

PR-URL: https://github.com/nodejs/node/pull/34243


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>

2a29650e

doc: buffer documentation improvements · f1dc5cd6

James M Snell authored Jul 06, 2020

PR-URL: https://github.com/nodejs/node/pull/34230


Reviewed-By: Anna Henningsen <anna@addaleax.net>

f1dc5cd6

worker: fix nested uncaught exception handling · 1274f89b

Anna Henningsen authored Jul 11, 2020

We are using `ObjectPrototypeToString()` as a cross-context brand check
for built-in errors, but weren’t making sure to set that when
deserializing errors back into JS objects.

Fix that by setting `[Symbol.toStringTag]` manually, to make sure that
multiple serialize-and-deserialize cycles keep giving the same result.

Fixes: https://github.com/nodejs/node/issues/34309

PR-URL: https://github.com/nodejs/node/pull/34310


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

1274f89b

worker: add option to track unmanaged file descriptors · 725cf476

Anna Henningsen authored Jul 11, 2020

Add a public option for Workers which adds tracking for raw
file descriptors, as currently, those resources are not cleaned
up, unlike e.g. `FileHandle`s.

PR-URL: https://github.com/nodejs/node/pull/34303


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

725cf476

src: add option to track unmanaged file descriptors · b58c06d9

Anna Henningsen authored Jul 11, 2020

Add the ability to track “raw” file descriptors, i.e. integers returned
by `fs.open()`, and close them on `Environment` shutdown, to match the
behavior for all other resource types (which are also closed on
shutdown).

PR-URL: https://github.com/nodejs/node/pull/34303


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

b58c06d9

src: remove redundant snprintf · 4cac5436

Anna Henningsen authored Jul 09, 2020

PR-URL: https://github.com/nodejs/node/pull/34282


Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: James M Snell <jasnell@gmail.com>

4cac5436

src: refactor TimerWrap lifetime management · 874460a1

Anna Henningsen authored Jul 08, 2020

Split `Stop(true)` and `Stop(false)` into separate methods since the
actions performed by these are fully distinct.

PR-URL: https://github.com/nodejs/node/pull/34252


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

874460a1

src: remove user_data from TimerWrap · e2f9dc6e

Anna Henningsen authored Jul 08, 2020

There’s no point in having an opaque user data pointer when we’re
already using `std::function`.

PR-URL: https://github.com/nodejs/node/pull/34252


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: David Carlier <devnexen@gmail.com>

e2f9dc6e

test: add regression tests for HTTP parser crash · 18667ac6

Anna Henningsen authored Jul 07, 2020

Since the tests only crash on v12.x, this commit adds separate
regression tests.

Refs: https://github.com/nodejs/node/issues/15102

PR-URL: https://github.com/nodejs/node/pull/34250
Refs: https://github.com/nodejs/node/issues/34016


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

18667ac6

async_hooks: improve resource stack performance · 460c81dc

Anna Henningsen authored Jul 12, 2020

Removes some of the performance overhead that came with
`executionAsyncResource()` by using the JS resource array
only as a cache for the values provided by C++. The fact that we now
use an entry trampoline is used to pass the resource without
requiring extra C++/JS boundary crossings, and the direct accesses
to the JS resource array from C++ are removed in all fast paths.

This particularly improves performance when async hooks are not
being used.

This is a continuation of https://github.com/nodejs/node/pull/33575
and shares some of its code with it.

    ./node benchmark/compare.js --new ./node --old ./node-master --runs 30 --filter messageport worker | Rscript benchmark/compare.R
    [00:06:14|% 100| 1/1 files | 60/60 runs | 2/2 configs]: Done
                                                       confidence improvement accuracy (*)    (**)   (***)
     worker/messageport.js n=1000000 payload='object'         **     12.64 %       ±7.30%  ±9.72% ±12.65%
     worker/messageport.js n=1000000 payload='string'          *     11.08 %       ±9.00% ±11.98% ±15.59%

    ./node benchmark/compare.js --new ./node --old ./node-master --runs 20 --filter async-resource-vs-destroy async_hooks | Rscript benchmark/compare.R
    [00:22:35|% 100| 1/1 files | 40/40 runs | 6/6 configs]: Done
                                                                                                                                                                         confidence improvement accuracy (*)
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-local-storage' benchmarker='autocannon'                     1.60 %       ±7.35%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-resource' benchmarker='autocannon'                          6.05 %       ±6.57%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='destroy' benchmarker='autocannon'                          *      8.27 %       ±7.50%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-local-storage' benchmarker='autocannon'                 7.42 %       ±8.22%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-resource' benchmarker='autocannon'                      4.33 %       ±7.84%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='destroy' benchmarker='autocannon'                             5.96 %       ±7.15%
                                                                                                                                                                           (**)   (***)
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-local-storage' benchmarker='autocannon'      ±9.84% ±12.94%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='async-resource' benchmarker='autocannon'           ±8.81% ±11.60%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='async' type='destroy' benchmarker='autocannon'                 ±10.07% ±13.28%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-local-storage' benchmarker='autocannon' ±11.01% ±14.48%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='async-resource' benchmarker='autocannon'      ±10.50% ±13.81%
     async_hooks/async-resource-vs-destroy.js n=1000000 duration=5 connections=500 path='/' asyncMethod='callbacks' type='destroy' benchmarker='autocannon'              ±9.58% ±12.62%

Refs: https://github.com/nodejs/node/pull/33575

PR-URL: https://github.com/nodejs/node/pull/34319


Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

460c81dc

build: add benchmark tests to CI runs · c7627da8

Rich Trott authored Jul 09, 2020

Closes: https://github.com/nodejs/node/issues/34321

PR-URL: https://github.com/nodejs/node/pull/34288


Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matheus Marchini <mat@mmarchini.me>

c7627da8

build,tools: fix cmd_regen_makefile · 8da0ae25

Daniel Bevenius authored Jul 08, 2020

Currently, after having configured and built node and then updating a
dependent target the following error is produced when trying to rebuild
the project:

$ ./configure && make -j8
$ touch node.gypi
$ make -j8
configure: error: no such option: -f
make[1]: *** [Makefile:685: Makefile] Error 2

The reason for this is that the target 'cmd_regen_makefile' is using the
command 'configure' instead of 'gyp_node.py' in out/Makefile:
cmd_regen_makefile = cd $(srcdir); /work/nodejs/node/configure -fmake

As far as I can tell gyp is using sys.argv[0] as the 'gyp_binary' in
__init__.py:
params = {'options': options,
              ...
              'gyp_binary': sys.argv[0],

But when called via 'configure' sys.argv[0] is 'configure' instead of
gyp_node.py leading to the above error.

This commit suggests setting the program name explicitly in
gyp_node.py. Alternatively perhaps this could be done in configure.py
instead but I was not sure what would be best.

PR-URL: https://github.com/nodejs/node/pull/34255


Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>

8da0ae25

doc: improve text in fs docs about omitting callbacks · f902170a

Rich Trott authored Jul 10, 2020

Repair misplaced colon and condense text.

PR-URL: https://github.com/nodejs/node/pull/34307


Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

f902170a

deps: upgrade npm to 6.14.6 · 09476f71

claudiahdz authored Jul 07, 2020

PR-URL: https://github.com/nodejs/node/pull/34246


Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

09476f71