- Apr 23, 2020
-
-
Ruben Bridgewater authored
Inspecting errors results in duplicated information in case an error is created with enumerable `name`, `message` or `stack` properties. In that case, check if the output already contains that information and prevent listing that property. This reduces the noise as receiver. PR-URL: https://github.com/nodejs/node/pull/32327 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com>
-
Ben Noordhuis authored
`actual` is the first argument, `expected` the second, but the test flipped them around and was producing confusing assertion messages as a result. Refs: https://github.com/nodejs/node/pull/32408#issuecomment-602170887 PR-URL: https://github.com/nodejs/node/pull/32420 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Hassaan Pasha authored
After an OpenSSL source update, all the config files need to be regenerated and comitted by: $ cd deps/openssl/config $ make $ git add deps/openssl/config/archs $ git add deps/openssl/openssl/include/crypto/bn_conf.h $ git add deps/openssl/openssl/include/crypto/dso_conf.h $ git add deps/openssl/openssl/include/openssl/opensslconf.h $ git commit PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By:Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
Hassaan Pasha authored
This updates all sources in deps/openssl/openssl by: $ cd deps/openssl/ $ rm -rf openssl $ tar zxf ~/tmp/openssl-1.1.1f.tar.gz $ mv openssl-1.1.0h openssl $ git add --all openssl $ git commit openssl PR-URL: https://github.com/nodejs/node/pull/32583 Reviewed-By: -
cjihrig authored
Update ESLint to 7.0.0-alpha.3 PR-URL: https://github.com/nodejs/node/pull/32533 Reviewed-By:
Rich Trott <rtrott@gmail.com>
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32544 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
-
Daniel Estiven Rico Posada authored
PR-URL: https://github.com/nodejs/node/pull/32549 Reviewed-By:
-
Hachimi Aa (Sfeir) authored
PR-URL: https://github.com/nodejs/node/pull/29270 Reviewed-By:
Robert Nagy <ronagy@icloud.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Ben Noordhuis authored
Authenticated decryption works for file streams up to 32768 bytes but not beyond. Other streams and direct decryption are not affected. Refs: https://github.com/nodejs/node/issues/31733 PR-URL: https://github.com/nodejs/node/pull/31734 Reviewed-By:
Matteo Collina <matteo.collina@gmail.com>
-
Anna Henningsen authored
Class names are written in UpperCamelCase. Otherwise, this looks like it’s a variable, not a class name. PR-URL: https://github.com/nodejs/node/pull/32539 Reviewed-By:
-
Anna Henningsen authored
Do not emit `'exit'` events caused by recursively stopping all running Workers from inside the `process.exit()` call. PR-URL: https://github.com/nodejs/node/pull/32546 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/32548 Reviewed-By:
-
Robert Nagy authored
When not allowing half open, handle.close would be invoked before shutdown has been called and completed causing a potential data race. Fixes: https://github.com/nodejs/node/issues/32486#issuecomment-604072559 PR-URL: https://github.com/nodejs/node/pull/32491 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/32436 Reviewed-By:
Matheus Marchini <mat@mmarchini.me>
-
Rich Trott authored
Replace magic numbers with constant. Use for loop for repeated code. Reduce console logging. Remove unneeded countdown module use. PR-URL: https://github.com/nodejs/node/pull/32547 Reviewed-By:
-
Gabriel Schulhof authored
Replace the portion of the context-aware addon example that advocates for managing the life cycle of the per-addon-instance data using a weak reference with code that illustrates how to manage its life cycle using an environment cleanup hook. Signed-off-by:
Gabriel Schulhof <gabriel.schulhof@intel.com> PR-URL: https://github.com/nodejs/node/pull/28659 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/32222 Reviewed-By:
-
Ben Noordhuis authored
The publicEncrypt/privateDecrypt/etc. family of functions didn't clear OpenSSL's error stack on early return. Notably, trying to use an encrypted key with the wrong passphrase left an error on the stack that made subsequent encrypt or decrypt operations fail, even with an unencrypted key. Fixes: https://github.com/nodejs/node/issues/32240 PR-URL: https://github.com/nodejs/node/pull/32248 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32286 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
David Carlier <devnexen@gmail.com> Reviewed-By:
-
Xu Meng authored
The API clock_getres with attribute API CLOCK_THREAD_CPUTIME_ID is not supported on IBM i PASE. PR-URL: https://github.com/nodejs/node/pull/32459 Reviewed-By:
-
Robert Nagy authored
The http client should not know anything about free sockets. Let the agent handle its pool of sockets. PR-URL: https://github.com/nodejs/node/pull/32003 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Harshitha KP authored
Under peculiar system load conditions, the profiler thread does not get enough CPU slices to perform the sampling. Improve the interaction between worker and parent thread by performing a large disc read, which is a better blend of CPU and I/O bound work, than earlier versions. This produces x10 more samples than the existing one, in 10 iterations, as opposed to 1024. Also capture worker error situations to improve debugging Refs: https://github.com/nodejs/node/issues/26401#issuecomment-597438516 PR-URL: https://github.com/nodejs/node/pull/32190 Reviewed-By:
-
Bartlomiej Brzozowski authored
PR-URL: https://github.com/nodejs/node/pull/32205 Fixes: https://github.com/nodejs/node/issues/31573 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/32277 Refs: https://github.com/nodejs/node/issues/28710 Reviewed-By:
-
Antoine du HAMEL authored
PR-URL: https://github.com/nodejs/node/pull/32359 Reviewed-By:
-
Xu Meng authored
IBMi PASE Node.js always links to shared openssl and zlib libraries. So skip the static binding tests. PR-URL: https://github.com/nodejs/node/pull/31967 Reviewed-By:
-
Gus Caplan authored
Fixes: https://github.com/nodejs/node/issues/31889 PR-URL: https://github.com/nodejs/node/pull/31938 Reviewed-By:
-
Christian Niederer authored
The Aliased*Array overflow check test introduced a dependency to a compiled artifact. Add this artifact to the build process in a similar fashion as test/addons and test/js-native-api do. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Christian Niederer authored
Added native extension similar to test/addons/stringbytes-external-exceeded-max. Added an abort test to regression test the non overflow behaviour. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Christian Niederer authored
When resizing an aliased_buffer check if the new size will overflow. PR-URL: https://github.com/nodejs/node/pull/31740 Reviewed-By:
-
Rich Trott authored
Isolate the two test cases here a bit more and refactor code. PR-URL: https://github.com/nodejs/node/pull/32526 Reviewed-By:
-
Harshitha KP authored
this was influenced by https://github.com/nodejs/node/pull/32269 PR-URL: https://github.com/nodejs/node/pull/32298 Reviewed-By:
-
Syohei YOSHIDA authored
V8 CPU profile -> V8 heap profile PR-URL: https://github.com/nodejs/node/pull/32404 Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32294 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
Ruben Bridgewater authored
Also clean up the plugins package.json files. PR-URL: https://github.com/nodejs/node/pull/32310 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32322 Reviewed-By:
-
Filip Skokan authored
PR-URL: https://github.com/nodejs/node/pull/32340 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/32453 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Yongsheng Zhang <zyszys98@gmail.com> Reviewed-By:
-
Richard Lau authored
For notarization on macOS all packaged binaries must be signed. Add a regression test to check that known binaries from our dependencies (at the time of this commit term-size via npm) are signed. Signed-off-by:
-
Bartosz Sosnowski authored
On Windows 2016 under high load further change events can be emitted after writing the 5 bytes is reported. Updating the mtime of the file can be reported as a separate change. This will increase the "before" count, but not the "w1HookCount" since we removed the listener. This makes the test keep the listeners until the end of the test. Fixes: https://github.com/nodejs/node/issues/21425 PR-URL: https://github.com/nodejs/node/pull/32484 Reviewed-By:
-
