- Jul 10, 2020
-
-
Benjamin Coe authored
Original commit message: [coverage] remove the last continuation range before synthetic return Rather than only removing the continuation range for the last return statement prior to a synthetic return statement, remove the continuation tracking for whatever statement occurs prior to the synthetic return. Bug: v8:10628 Change-Id: Ieb8e393479c9811cf1b9756840bbfdbe7f44a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2280585 Commit-Queue: Benjamin Coe <bencoe@google.com> Reviewed-by:Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#68719} Refs: https://github.com/v8/v8/commit/2d5017a0fc0203c9657394e7f86158bac8440ba4 PR-URL: https://github.com/nodejs/node/pull/34272 Refs: https://github.com/bcoe/c8/issues/229 Reviewed-By:
Jiawen Geng <technicalcute@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Gus Caplan <me@gus.host>
-
- Jul 09, 2020
-
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/29739 PR-URL: https://github.com/nodejs/node/pull/34222 Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Tobias Nießen <tniessen@tnie.de>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/22804 PR-URL: https://github.com/nodejs/node/pull/34221 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Trivikram Kamat <trivikr.dev@gmail.com>
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/29714 PR-URL: https://github.com/nodejs/node/pull/34223 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/8569 PR-URL: https://github.com/nodejs/node/pull/34227 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/32431 PR-URL: https://github.com/nodejs/node/pull/34220 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/31244 PR-URL: https://github.com/nodejs/node/pull/34225 Reviewed-By:
-
James M Snell authored
Fixes: https://github.com/nodejs/node/issues/31279 PR-URL: https://github.com/nodejs/node/pull/34226 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
Some of the flags were no longer being used. Switched to use an AliasedStruct for shared state to avoid extraneous expensive JS=>C++ calls. Removed unused QuicSocket option PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
Anna Henningsen authored
0f97d606 accidentally removed this. Refs: https://github.com/nodejs/node/pull/34186 PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
Also, change setServerBusy into a setter PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
Errors thrown within the session event handler will be handled by destroying the session (allowing a proper connection close to be sent to the client peer). They will not crash the parent QuicSocket by default. Instead, a `'sessionError'` event will be emitted, allowing the error to be logged or handled. PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
The argument will always be a boolean already PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
James M Snell authored
PR-URL: https://github.com/nodejs/node/pull/34247 Reviewed-By:
-
Robert Nagy authored
PR-URL: https://github.com/nodejs/node/pull/34143 Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/33991 Fixes: https://github.com/nodejs/node/issues/33582 Reviewed-By:
Denys Otrishko <shishugi@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
Robert Nagy <ronagy@icloud.com>
-
Rich Trott authored
PR-URL: https://github.com/nodejs/node/pull/34228 Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Gabriel Schulhof authored
Add assertions that conversion and coercion N-APIs return appropriate error statuses when given `NULL`s for parameters they expect to not be `NULL`. For `napi_get_value_string_*` this also checks that it returns `napi_string_expected` when passed a `napi_value` not containing a string. PR-URL: https://github.com/nodejs/node/pull/34142 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
- Jul 08, 2020
-
-
Johannes Schöpp authored
Powershell defaults to tls 1.0 - This forces powershell to use tls 1.2 Tls 1.2 is supported in all current microsoft operating systems and needed to download chocolatey. Fixes: https://github.com/nodejs/node/issues/33140 PR-URL: https://github.com/nodejs/node/pull/33609 Reviewed-By:
Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By:
-
rickyes authored
PR-URL: https://github.com/nodejs/node/pull/34156 Reviewed-By:
-
Xu Meng authored
Due to some unknown system configuration, the code `socket_ipv6.bind(0, 111::1)` does not throw the expected error EADDRNOTAVAIL on some IBM i systems. This issue is still being investigated. To get the IBM i CI passing, skip it for now. PR-URL: https://github.com/nodejs/node/pull/34209 Reviewed-By:
-
Anna Henningsen authored
Add a test for a regression that occurs when transferring some `Buffer` objects that were created from C++ to a parent thread. Fixes: https://github.com/nodejs/node/issues/34126 PR-URL: https://github.com/nodejs/node/pull/34140 Reviewed-By:
Gerhard Stöbich <deb2001-github@yahoo.de>
-
Anna Henningsen authored
V8 will not exit the process after handling --help anymore: https://chromium-review.googlesource.com/c/v8/v8/+/2276276 As a drive-by fix, correctly return in the `print_bash_completion` case as well. Refs: https://github.com/nodejs/node/pull/34135 Co-authored-by:
Ulan Degenbaev <ulan@chromium.org> PR-URL: https://github.com/nodejs/node/pull/34136 Reviewed-By:
Shelley Vohr <codebytere@gmail.com> Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com>
-
Anna Henningsen authored
646e5a47 changed the way that the domain hook callback is called. Previously, the callback was only used in the case that async_hooks were *not* being used (since domains already integrate with async hooks the way they should), and the corresponding deprecation warning also only emitted in that case. However, that commit didn’t move that condition along when the code was ported from C++ to JS. As a consequence, the domain hook callback was used when it wasn’t necessary to use it, and the deprecation warning emitted accidentally along with it. Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-9f21ce1b9d6d46fdd07b969e8a04e140L192 Refs: https://github.com/nodejs/node/commit/646e5a471766e27e8317bb54d1fd1d2c72cffb69#diff-e6db408e12db906ead6ddfac3de15a6fR119 Refs: https://github.com/nodejs/node/pull/33801#issuecomment-654744913 PR-URL: https://github.com/nodejs/node/pull/34245 Fixes: https://github.com/nodejs/node/issues/34069 Reviewed-By:
Vladimir de Turckheim <vlad2t@hotmail.com> Reviewed-By:
Andrey Pechkurov <apechkurov@gmail.com> Reviewed-By:
Stephen Belanger <admin@stephenbelanger.com>
-
- Jul 07, 2020
-
-
Daniel Bevenius authored
This commit adds a local variable named encoding_type which is set to the value of the Maybe using ToChecked(). The motivation for this is the code for ToChecked() could be executed multiple times depending on path taken at runtime. I also think this improves readability, or at least it is as readable as before this change. PR-URL: https://github.com/nodejs/node/pull/34181 Reviewed-By:
David Carlier <devnexen@gmail.com>
-
Rich Trott authored
The test is marked flaky on ARM because it times out on Raspberry Pi devices in CI. Split the single test file into four separate test files to ease debugging. Add fs.close() to avoid timing out. Fixes: https://github.com/nodejs/node/issues/33796 PR-URL: https://github.com/nodejs/node/pull/34203 Reviewed-By:
-
- Jul 06, 2020
-
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34158 Reviewed-By:
-
sapics authored
PR-URL: https://github.com/nodejs/node/pull/34158 Reviewed-By:
-
Rich Trott authored
Refs: https://github.com/nodejs/node/pull/33764#issuecomment-653667275 PR-URL: https://github.com/nodejs/node/pull/34197 Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Rich Trott authored
test-repl-history-navigation fails with NODE_PENDING_DEPRECATION=1. Replace deprecated repl.inputStream with repl.input. PR-URL: https://github.com/nodejs/node/pull/34199 Reviewed-By:
-
