- Jan 17, 2017
-
-
Stewart X Addison authored
An application using node built as a shared library may legitimately implement its own signal handling routines. Current behaviour is to squash all signal handlers on node startup. This change will stop that behaviour when node is built as a shared library. PR-URL: https://github.com/nodejs/node/pull/10539 Fixes: https://github.com/nodejs/node/issues/10520 Refs: https://github.com/nodejs/node/pull/615 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Adrian Estrada authored
* use common.mustCall to validate functions executions * use common.fail to control error * remove unnecessary variables * remove unnecessary assertions * remove console.log and console.error * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10798 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com>
-
Rich Trott authored
If you alter the array returned by `tls.getCiphers()`, `crypto.getCiphers()`, `crypto.getHashes()`, or `crypto.getCurves()`, it will alter subsequent return values from those functions. ```js 'use strict'; const crypto = require('crypto'); var hashes = crypto.getHashes(); hashes.splice(0, hashes.length); hashes.push('some-arbitrary-value'); console.log(crypto.getHashes()); // "['some-arbitrary-value']" ``` This is surprising. Change functions to return copy of array instead. PR-URL: https://github.com/nodejs/node/pull/10795 Reviewed-By:Anna Henningsen <anna@addaleax.net> Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
cjihrig authored
This commit fixes a broken assertion in test-cli-eval.js. PR-URL: https://github.com/nodejs/node/pull/10840 Reviewed-By:
Italo A. Casas <me@italoacasas.com> Reviewed-By:
-
stefan judis authored
* use const instead of var * use assert.strictEqual instead of assert.equal * use common.mustCall instead of process.on( 'exit', fn ) PR-URL: https://github.com/nodejs/node/pull/10725 Reviewed-By:
-
Adrian Estrada authored
* validate the errors for assert.throws * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10714 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
-
Rich Trott authored
Confirm that `getCiphers()` contains no duplicates. PR-URL: https://github.com/nodejs/node/pull/10784 Reviewed-By:
-
Zach Bjornson authored
* Clarify that memory is always shared and never copied. * Fix wording that sounded like ArrayBuffer has a buffer property. PR-URL: https://github.com/nodejs/node/pull/10778 Ref: https://github.com/nodejs/node/issues/10770 Reviewed-By:
-
Adrian Estrada authored
* use common.fail to handle errors * remove console.log * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10830 Reviewed-By:
-
Сковорода Никита Андреевич authored
* It had some minor errors in td/th html tags. * Make it clear that v5, v0.10, and v0.12 are EOL and unsupported. We probably don't want people seeing 'LTS' badge next to those in the current Node.js repo and think that those are still supported. Not everyone is aware of the nodejs/LTS repo. This also includes the dates for v5, v0.10 and v0.12 EOL: - 2016-07-01 for v5 - 2016-11-01 for v0.10 - 2017-01-01 for v0.12 * Make v5/v0.10/v0.12 not bold in CHANGELOG Make v5, v0.10, v0.12 not bold in the CHANGELOG.md, as bold is said to be an indication of the most recent actively supported release futher on the same page. PR-URL: https://github.com/nodejs/node/pull/10743 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Sumit Goel authored
* assert unused vars in test-cli-eval.js * assert in more idiomatic way test-cli-eval * rename status to err in test-cli-eval.js PR-URL: https://github.com/nodejs/node/pull/10759 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
-
Adrian Estrada authored
* validate the errors for all assert.throws * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10779 Reviewed-By:
-
Rich Trott authored
Remove assignments to `SIMD` that are only to pacify ESLint. Instead, use either `global.SIMD` or provide an comment letting ESLint know in cases where `SIMD` is guaranteed to be a defined global identifier. PR-URL: https://github.com/nodejs/node/pull/10785 Reviewed-By:
Teddy Katz <teddy.katz@gmail.com> Reviewed-By:
-
larissayvette authored
PR-URL: https://github.com/nodejs/node/pull/10791 Reviewed-By:
-
Josh Hollandsworth authored
PR-URL: https://github.com/nodejs/node/pull/10807 Reviewed-By:
Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By:
-
abouthiroppy authored
Change regular expression of error message. Add test case(`res.writeHead()`). PR-URL: https://github.com/nodejs/node/pull/10808 Reviewed-By:
-
abouthiroppy authored
https://github.com/nodejs/node/blob/master/lib/_http_incoming.js#L136 Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_incoming.js.html PR-URL: https://github.com/nodejs/node/pull/10811 Reviewed-By:
-
Daijiro Wachi authored
use common.hasIntl to make sure Intl object is present or not. PR-URL: https://github.com/nodejs/node/pull/10707 Reviewed-By:
Steven R Loomis <srloomis@us.ibm.com>
-
- Jan 16, 2017
-
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/10828 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
Adrian Estrada authored
* validate errors in assert.throws * use arrow functions PR-URL: https://github.com/nodejs/node/pull/10752 Reviewed-By:
-
Ben Noordhuis authored
Overlooked when moving code around in commit 42da740e ("inspector: split HTTP/WS server from the inspector".) PR-URL: https://github.com/nodejs/node/pull/10407 Reviewed-By:
-
Yuya Tanaka authored
Squashed from: - child_process: stop indexOf() on whole IPC buffer - child_process: get rid of forEach() and slice() in IPC - child_process: get rid of another forEach() in IPC Fixes: https://github.com/nodejs/node/issues/3145 PR-URL: https://github.com/nodejs/node/pull/10557 Reviewed-By:
-
Yuya Tanaka authored
Squashed from: - child_process: fix IPC bench to obey send() ret val - child_process: fix IPC benchmark message has two more bytes - child_process: use setImmediate for IPC bench PR-URL: https://github.com/nodejs/node/pull/10557 Reviewed-By:
-
Rich Trott authored
Add a test to cover situation where REPL is initialized with `useGlobal` set to `true` and `.clear` is called. This adds coverage for code in repl.js that is not currently covered. Includes minor refactor of rocket functions in repl.js for concision. PR-URL: https://github.com/nodejs/node/pull/10777 Reviewed-By:
-
- Jan 15, 2017
-
-
Joyee Cheung authored
* Improve readability of util.normalizeEncoding and add some comments * Add a benchmark for util.normalizeEncoding PR-URL: https://github.com/nodejs/node/pull/10439 Reviewed-By:
Andreas Madsen <amwebdk@gmail.com>
-
Joyee Cheung authored
* add benchmark to compare the performance of getting url properties between the WHATWG URL and the legacy implementation * add benchmark to compare the performance of serializing urls between the WHATWG URL and the legacy implementation * refactor the benchmark for comparing parsing performance between the two implementations PR-URL: https://github.com/nodejs/node/pull/10678 Reviewed-By:
Brian White <mscdex@mscdex.net>
-
Rich Trott authored
There were no tests confirming situations where server.connections should return `null`. Add a test for that situation. Expand existing server.connection test slightly to check value. Refactor (mostly spacing) code for server.connections setter. PR-URL: https://github.com/nodejs/node/pull/10762 Reviewed-By:
-
This reverts commit 4444e731. PR-URL: https://github.com/nodejs/node/pull/10809 Reviewed-By:
-
Nikolai Vavilov authored
It would previously read from the current file position, which can be non-zero if the `fd` has been read from or written to. This contradicts the documentation which states that it "reads the entire contents of a file". PR-URL: https://github.com/nodejs/node/pull/9699 Fixes: https://github.com/nodejs/node/issues/9671 Reviewed-By:
-
- Jan 14, 2017
-
-
Joyee Cheung authored
Use the word "confidence" to indicate the confidence level of the p value so it's easier to understand. With this change more stars in the output of compare.R means higher confidence level (lower significance level). PR-URL: https://github.com/nodejs/node/pull/10737 Refs: https://github.com/nodejs/node/pull/10439 Reviewed-By:
-
cjihrig authored
This commit splits the existing cluster module into several internal modules. More specifically, the cluster master and worker implementations are separated, and the various data structures are separated. PR-URL: https://github.com/nodejs/node/pull/10746 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
Fedor Indutny <fedor.indutny@gmail.com>
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Brian White authored
PR-URL: https://github.com/nodejs/node/pull/10654 Reviewed-By:
-
Irene Li authored
PR-URL: https://github.com/nodejs/node/pull/10755 Reviewed-By:
-
Rich Trott authored
* use `+` instead of `*` where one-or-more is required * switch from String.prototype.match() to RegExp.prototype.test() PR-URL: https://github.com/nodejs/node/pull/10749 Reviewed-By:
Jackson Tian <shyvo1987@gmail.com>
-
Javis Sullivan authored
PR-URL: https://github.com/nodejs/node/pull/10741 Reviewed-By:
-
