- Jan 31, 2019
-
-
gengjiawen authored
Signed-off-by:
gengjiawen <technicalcute@gmail.com> PR-URL: https://github.com/nodejs/node/pull/25764 Reviewed-By:
Matheus Marchini <mat@mmarchini.me> Reviewed-By:
Anna Henningsen <anna@addaleax.net> Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Rich Trott authored
The TSC has delegated authority over LTS and Current branches to the Release WG. Remove the bullet point about TSC having authority to determine that a breaking change is necessary on LTS and Current release branches. Retaining that authority would require de-chartering the Release WG. Fixes: https://github.com/nodejs/TSC/issues/660 PR-URL: https://github.com/nodejs/node/pull/25780 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
Myles Borins <myles.borins@gmail.com>
-
Rich Trott authored
Revise inspect security information in cli.md. * Reword sentence for brevity. * Use bulleted list for clarity of options. * Eliminate personal pronoun (_you_) per style guide. PR-URL: https://github.com/nodejs/node/pull/25779 Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
-
Rich Trott authored
Use italics for words-as-words within style guide. Other minor improvements. PR-URL: https://github.com/nodejs/node/pull/25778 Reviewed-By:
-
cjihrig authored
This commit combines two if statements into a single if statement. Another if statement is replaced with a ternary. PR-URL: https://github.com/nodejs/node/pull/25744 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By:
-
Refael Ackermann authored
* Preserve 3 node-core checks * Preserve patch to `FileInfo.RepositoryName` * Remove TAP to logfile (unused) PR-URL: https://github.com/nodejs/node/pull/25771 Fixes: https://github.com/nodejs/node/issues/25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/25771 Fixes: https://github.com/nodejs/node/issues/25760 Refs: https://github.com/cpplint/cpplint/blob/3d8f6f876dd6e3918e5641483298dbc82e65f358/cpplint.py Reviewed-By:
-
Anna Henningsen authored
Re-use the existing `MaybeStackBuffer` logic for `SlicedArguments`. PR-URL: https://github.com/nodejs/node/pull/25745 Reviewed-By:
-
cclauss authored
As recommended at https://github.com/nodejs/node/pull/25759#issuecomment-458139766 * Python 2.6 end of life statement in 2013: https://www.python.org/dev/peps/pep-0361/#release-lifespan * Python 2.7 end of life statement in 2019: https://www.python.org/dev/peps/pep-0373/#update * Python 3.4 reaches it end of life in < 50 days so it should not be a target: https://devguide.python.org/#branchstatus PR-URL: https://github.com/nodejs/node/pull/25766 Reviewed-By:
Rich Trott <rtrott@gmail.com> Reviewed-By:
Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By:
-
Daniel Bevenius authored
PR-URL: https://github.com/nodejs/node/pull/25761 Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
-
Anna Henningsen authored
Add a check to make sure start_io_thread_async is not accidentally re-used or used when uninitialized. (This is a bit of an odd check imo, but it helped me figure out a real issue and it might do so again, so… why not?) PR-URL: https://github.com/nodejs/node/pull/25777 Reviewed-By:
Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By:
Minwoo Jung <minwoo@nodesource.com> Reviewed-By:
-
Anna Henningsen authored
For the report generation, we use `Environment::GetCurrent(isolate)` which uses `isolate->GetCurrentContext()` under the hood, thus allocates a handle. Without a `HandleScope`, this is invalid. This might not strictly be allowed inside of `OnFatalError()`, but it won’t make anything worse either. PR-URL: https://github.com/nodejs/node/pull/25775 Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25743 Reviewed-By:
Tiancheng "Timothy" Gu <timothygu99@gmail.com>
-
Anna Henningsen authored
Use the same JS-compatible format on both POSIX and Windows. PR-URL: https://github.com/nodejs/node/pull/25751 Reviewed-By:
-
Michaël Zasso authored
Notable changes: * deps: * OpenSSL has been updated to 1.1.1a, which is API/ABI compatible with the previous OpenSSL 1.1.0j. Note that while OpenSSL 1.1.1a supports TLS1.3, Node.js still does not. https://github.com/nodejs/node/pull/25582 PR-URL: https://github.com/nodejs/node/pull/25802 -
cjihrig authored
Prior to this commit, on non-Windows platforms, the "osVersion" value was prepended to the "machine" value. PR-URL: https://github.com/nodejs/node/pull/25755 Reviewed-By:
-
cjihrig authored
- Tidy up description in docs. - Remove a second definition in the docs. - Remove unused string input parameter. - Remove duplicate "JavaScript Callstack" in error messages. PR-URL: https://github.com/nodejs/node/pull/25749 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Eugene Ostroukhov authored
Fixes: https://github.com/nodejs/node/issues/23185 PR-URL: https://github.com/nodejs/node/pull/24814 Reviewed-By:
-
cjihrig authored
- Don't unnecessarily require('../common'). - Eliminate state maintained in tmppath. - validate() was being used synchronously, but was actually asynchronous. Make it synchronous. - Other misc. drive by cleanup. PR-URL: https://github.com/nodejs/node/pull/25754 Reviewed-By: -
Anna Henningsen authored
Inside workers, using stdio is always asynchronous, so using `process.exit()` always interrupts sending of messages to the parent thread, including error messages presented over stdio. Do not use `process.exit()` and instead trigger a “real” uncaught exception. PR-URL: https://github.com/nodejs/node/pull/25769 Reviewed-By:
Guy Bedford <guybedford@gmail.com> Reviewed-By:
-
Anna Henningsen authored
This could otherwise print unhandled rejection warnings if the process does not exit immediately inside an earlier `.catch()` handler. PR-URL: https://github.com/nodejs/node/pull/25769 Reviewed-By:
-
Anna Henningsen authored
Fixes: https://github.com/nodejs/node/issues/25765 PR-URL: https://github.com/nodejs/node/pull/25768 Reviewed-By:
Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By:
-
- Jan 30, 2019
-
-
Rich Trott authored
* Move client renegotiation limit tests from pummel to parallel. * Rename tests to more accurately reflect what they do. * Refactor to use arrow functions for anonymouse callbacks and to be consistent about trailing commas. PR-URL: https://github.com/nodejs/node/pull/25757 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
Joyee Cheung authored
This patch directly inlines `createMessageHandler()` and `createWorkerFatalExeception()` in the new `lib/internal/main/worker_thread.js` since the implementation of the two methods are related to the execution flow of workers. PR-URL: https://github.com/nodejs/node/pull/25667 Reviewed-By:
-
Joyee Cheung authored
This patch splits the execution mode selection from the environment setup in `lib/internal/bootstrap/node.js`, and split the entry point of different execution mode into main scripts under `lib/internal/main`: - `check_syntax.js`: used when `-c`/`--check` which only checks the syntax of the input instead of executing it. - `eval_stdin.js`: used when `-e` is passed without value and stdin is not a TTY (e.g. something is piped). - `eval_string`: used when `-e` is passed along with a string argument - `inspect.js`: for `node inspect`/`node debug` - `print_bash_completion.js`: for `--completion-bash` - `print_help.js`: for `--help` - `prof_process.js`: for `--prof-process` - `repl.js`: for the REPL - `run_main_module.js`: used when a main module is passed - `run_third_party_main.js`: for the legacy `_third_party_main.js` support - `worker_thread.js`: for workers This makes the entry points easier to navigate and paves the way for customized v8 snapshots (that do not need to deserialize execution mode setup) and better embedder APIs. As an example, after this patch, for the most common case where Node.js executes a user module as an entry point, it essentially goes through: - `lib/internal/per_context.js` to setup the v8 Context (which is also run when setting up contexts for the `vm` module) - `lib/internal/bootstrap/loaders.js` to set up internal binding and builtin module loaders (that are separate from the loaders accessible in the user land). - `lib/internal/bootstrap/node.js`: to set up the rest of the environment, including various globals and the process object - `lib/internal/main/run_main_module.js`: which is selected from C++ to prepare execution of the user module. This patch also removes `NativeModuleLoader::CompileAndCall` and exposes `NativeModuleLoader::LookupAndCompile` directly so that we can handle syntax errors and runtime errors of bootstrap scripts differently. PR-URL: https://github.com/nodejs/node/pull/25667 Reviewed-By:
-
Daniel Bevenius authored
This commit updates test/parallel/test-crypto-fips.js to use fipsMode instead of process.config.variables.openssl_fips. The motivation for this is that since the addition of the --openssl-is-fips configuration flag, it is possible to dynamically link with a FIPS compliant OpenSSL library. Using fipsMode allows for determining if there is FIPS support when statically or dynamically linking against a FIPS compatible OpenSSL library. PR-URL: https://github.com/nodejs/node/pull/25563 Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By:
-
Daniel Bevenius authored
Currently the following compiler warnings is generated: In file included from ../src/env-inl.h:28: ../src/env.h:521:18: warning: private field 'env_' is not used [-Wunused-private-field] Environment* env_; ^ 1 warning generated. This commit removes this unused field. PR-URL: https://github.com/nodejs/node/pull/25784 Reviewed-By:Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
-
Rich Trott authored
* Switch from Date.now() to process.hrtime.bigint(). * Move start time recording to before the request is created, not after. Fixes: https://github.com/nodejs/node/issues/25746 PR-URL: https://github.com/nodejs/node/pull/25752 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25734 Reviewed-By:
-
Rich Trott authored
.eslintrc has lots of trailing commas and lots of places where there aren't trailing commas. Use trailing commas throughout the files for consistency. PR-URL: https://github.com/nodejs/node/pull/25739 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/25735 Reviewed-By:
-
Shelley Vohr authored
* doc: * add oyyd to collaborators (Ouyang Yadong) [#24300](https://github.com/nodejs/node/pull/24300) * tls: * throw if protocol too long (Andre Jodat-Danbrani) [#23606](https://github.com/nodejs/node/pull/23606) PR-URL: https://github.com/nodejs/node/pull/25346
-
Rich Trott authored
The heapdump tests take a lot more time to run than our other tests in parallel. They are also a bit of an internal test that perhaps does not need to be run on every commit on every platform. This change moves them to the pummel directory where they will be run on a single platform once a day in CI. This shaves more than 20 seconds off `make test` on my laptop, FWIW. PR-URL: https://github.com/nodejs/node/pull/25181 Reviewed-By:
-
David Benjamin authored
SSL_set_tlsext_status_ocsp_resp expects the data to be allocated with OPENSSL_malloc, not libc malloc, so use OpenSSLMalloc. Additionally, though OpenSSL doesn't type-check due to it being a macro, the function is documented to take an unsigned char pointer: https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_tlsext_status_ocsp_resp.html (By default, OPENSSL_malloc is the same as libc malloc, but it is possible to customize this.) PR-URL: https://github.com/nodejs/node/pull/25706 Reviewed-By:
-
