- Mar 14, 2019
-
-
Joyee Cheung authored
Instead of setting it in the process object, since this is a configure-time option. Also added a shim that can be deprecated and removed some time later. PR-URL: https://github.com/nodejs/node/pull/26228 Reviewed-By:
Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By:
James M Snell <jasnell@gmail.com> Reviewed-By:
Ruben Bridgewater <ruben@bridgewater.de>
-
Beni von Cheni authored
Migrate various modules from using process.binding to internalBinding. PR-URL: https://github.com/nodejs/node/pull/24952 Refs: https://github.com/nodejs/node/issues/22160 Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By:
Anna Henningsen <anna@addaleax.net>
-
Richard Lau authored
The underlying JavaScript runtime may schedule tasks at its discretion so there may be more timer handles than the one created by the test. PR-URL: https://github.com/nodejs/node/pull/26434 Reviewed-By:
Colin Ihrig <cjihrig@gmail.com> Reviewed-By:
Luigi Pinca <luigipinca@gmail.com> Reviewed-By:
Gireesh Punathil <gpunathi@in.ibm.com>
-
Rich Trott authored
Edit the last few paragraphs of the Collaborator Guide section on deprecations. PR-URL: https://github.com/nodejs/node/pull/26419 Reviewed-By:
Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By:
Michaël Zasso <targos@protonmail.com> Reviewed-By:
Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By:
Richard Lau <riclau@uk.ibm.com> Reviewed-By:
-
Joyee Cheung authored
We need to be careful not to include the size of non-pointer fields in the parent's self size if we want to track them separately as a different node. Refs: https://github.com/nodejs/node/pull/26161/files#r259170771 PR-URL: https://github.com/nodejs/node/pull/26262 Reviewed-By:
-
Nitish Sakhawalkar authored
PR-URL: https://github.com/nodejs/node/pull/26380 Reviewed-By:
Refael Ackermann <refack@gmail.com>
-
Matteo Collina authored
socket.parser can be undefined under unknown circumstances. This is a fix for a bug I cannot reproduce but it is affecting people. Fixes: https://github.com/nodejs/node/issues/26366 PR-URL: https://github.com/nodejs/node/pull/26402 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26395 Reviewed-By:
-
- Mar 13, 2019
-
-
Refael Ackermann authored
PR-URL: https://github.com/nodejs/node/pull/26405 Reviewed-By:
Yang Guo <yangguo@chromium.org> Reviewed-By:
Michael Dawson <michael_dawson@ca.ibm.com>
-
Luigi Pinca authored
PR-URL: https://github.com/nodejs/node/pull/26412 Fixes: https://github.com/nodejs/node/issues/26357 Reviewed-By:
Masashi Hirano <shisama07@gmail.com> Reviewed-By:
Matteo Collina <matteo.collina@gmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26411 Reviewed-By:
-
Anna Henningsen authored
PR-URL: https://github.com/nodejs/node/pull/26383 Reviewed-By:
Tobias Nießen <tniessen@tnie.de> Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
-
Anna Henningsen authored
Support `.mailmap` for manually added `Author:` and `Co-authored-by:` tags. PR-URL: https://github.com/nodejs/node/pull/26383 Reviewed-By:
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/26340 Reviewed-By:
-
Geir Hauge authored
The N-API version of the hello example, returned "hello" instead of "world". PR-URL: https://github.com/nodejs/node/pull/26328 Reviewed-By:
Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By:
-
Luigi Pinca authored
Prevent the `'error'` event from being emitted multiple times if `writable.destroy()` is called with an error before the `_destroy()` callback is called. Emit the first error, discard all others. PR-URL: https://github.com/nodejs/node/pull/26057 Fixes: https://github.com/nodejs/node/issues/26015 Reviewed-By:
-
Vse Mozhet Byt authored
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: https://github.com/nodejs/node/pull/26461 Reviewed-By:
-
Anna Henningsen authored
Add a benchmark, and amend the relevant source code comment to state that currently, switching to directly returning a BigInt is not stopped by technical obstacles but rather the fact that using a typed array is actually a bit faster (about 2.5 %, measured locally). PR-URL: https://github.com/nodejs/node/pull/26381 Reviewed-By:
-
Anna Henningsen authored
Platform tasks should have their own handle scopes, rather than leak into outer ones. PR-URL: https://github.com/nodejs/node/pull/26376 Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By:
-
Anna Henningsen authored
There is no real reason to assume that V8 tasks would have to run in a Node.js `Context`. PR-URL: https://github.com/nodejs/node/pull/26376 Reviewed-By:
-
Anna Henningsen authored
We explicitly store the context anyway, and can skip the extra steps introduced in `Environment::GetCurrent()`. PR-URL: https://github.com/nodejs/node/pull/26376 Reviewed-By:
-
Anna Henningsen authored
Do not require an explicit `HandleScope`, or the ability to create one, when using `Environment::GetCurrent()`. `isolate->InContext()` is used as an indicator that it is probably okay to create a `HandleScope`, see also the short discussion in https://github.com/nodejs/node/pull/25775#pullrequestreview-197371049. PR-URL: https://github.com/nodejs/node/pull/26376 Reviewed-By:
-
cjihrig authored
Reduce the number of emitExperimentalWarning() call sites by making process.report emit a warning on access instead of each individual report function. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By:
Wyatt Preul <wpreul@gmail.com>
-
cjihrig authored
This commit removes process.report.setOptions(). Instead of using complex configuration synchronization between C++ and JS, this commit introduces individual getters and setters. PR-URL: https://github.com/nodejs/node/pull/26414 Reviewed-By:
-
Benjamin authored
Original commit message: [coverage] Extend SourceRangeAstVisitor for throw statements The SourceRangeAstVisitor has custom logic for blocks ending with a statement that has a continuation range. In these cases, the trailing continuation is removed which makes the reported coverage ranges a bit nicer. throw Error('foo') consists of an ExpressionStatement, with a Throw expression stored within the statement. The source range itself is stored with the Throw, not the statement. We now properly extract the correct AST node for trailing throw statements. R=jgruber@chromium.org, neis@chromium.org, yangguo@chromium.org Bug: v8:8691 Change-Id: Ibcbab79fbe54719a8993045040349c863b139011 Reviewed-on: https://chromium-review.googlesource.com/c/1480632 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:Georg Neis <neis@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59936} Refs: https://github.com/v8/v8/commit/2d08967d4a4b9a43aa2b11781421e09bff3b89ad PR-URL: https://github.com/nodejs/node/pull/26413 Reviewed-By:
Gus Caplan <me@gus.host> Reviewed-By:
-
Sam Roberts authored
Particularly, ensure that the commit messages are self-explanatory so that reviewers can understand that the large commits are the result of a simple repeatable process. This should make them easier to review. See: https://github.com/nodejs/node/pull/26327#issuecomment-468745161 PR-URL: https://github.com/nodejs/node/pull/26378 Reviewed-By:
-
Sam Roberts authored
Since its not packaged, we don't have to delete it, and the Makefile and update can become a (tiny) bit simpler. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Sam Roberts authored
`cd deps/openssl/config; make` updates all archs dependant files. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Sam Roberts authored
This updates all sources in deps/openssl/openssl with openssl-1.1.1b. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
Sam Roberts authored
This reverts commit f395a4a4. As of openssl-1.1.1b, the dot-files are no longer distributed, so this is no longer necessary. PR-URL: https://github.com/nodejs/node/pull/26327 Reviewed-By:
-
cjihrig authored
This commit adds support for the resourceUsage report section on Windows by using uv_getrusage() instead of getrusage(). PR-URL: https://github.com/nodejs/node/pull/26406 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26336 Reviewed-By:
Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26354 Reviewed-By:
-
Jeremy Apthorp authored
PR-URL: https://github.com/nodejs/node/pull/26365 Reviewed-By:
Sam Roberts <vieuxtech@gmail.com> Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26396 Reviewed-By:
-
leeight authored
In `_tls_wrap.js` while calling `socket.connect` the `localPort` was missing, restore it. PR-URL: https://github.com/nodejs/node/pull/24554 Fixes: https://github.com/nodejs/node/issues/24543 Reviewed-By:
-
himself65 authored
PR-URL: https://github.com/nodejs/node/pull/25818 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26275 Reviewed-By:
-
gengjiawen authored
PR-URL: https://github.com/nodejs/node/pull/26284 Reviewed-By:
-
Juan José Arboleda authored
PR-URL: https://github.com/nodejs/node/pull/26310 Reviewed-By:
Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By:
-
