Unverified Commit dc43066e authored by Anna Henningsen's avatar Anna Henningsen
Browse files

child_process: retain reference to data with advanced serialization

Do the same thing we do for other streams, and retain a reference to
the Buffer that was sent over IPC while the write request is active,
so that it doesn’t get garbage collected while the data is still in
flight.

(This is a good example of why it’s a bad idea that we’re not re-using
the general streams implementation for IPC and instead maintain
separate usage of the low-level I/O primitives.)

Fixes: https://github.com/nodejs/node/issues/34797

PR-URL: https://github.com/nodejs/node/pull/38728


Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
Reviewed-By: default avatarMinwoo Jung <nodecorelab@gmail.com>
parent ba84524a
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment