Commit ceb6a8c1 authored by João Reis's avatar João Reis
Browse files

test: fix test-debug-port-from-cmdline

This change is a backport of 2b4b6006
from io.js.

Original commit message:

  This test was failing because the spawned process was terminated
  before anything could be done, by calling child.stdin.end. With this
  change, the child's stdin is no longer closed. When the stdin is not
  a tty, io.js waits for the whole input before starting, so the child
  must be run with --interactive to process the command sent by the
  parent. The child is killed explicitly by the parent before it exits.

  This test was failing silently because the asserts were not called if
  nothing was received from the child. This fix moves assertOutputLines
  to always run on exit.

  Fixes: https://github.com/nodejs/io.js/issues/2177
  Refs: https://github.com/nodejs/io.js/issues/2094
  PR-URL: https://github.com/nodejs/io.js/pull/2186


Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarRod Vagg <rod@vagg.org>
Reviewed-By: default avatarJohan Bergström <bugs@bergstroem.nu>
Reviewed-By: default avatarAlexis Campailla <alexis@janeasystems.com>

Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
PR-URL: https://github.com/joyent/node/pull/25748
parent 14db6294
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment