Commit c0c0d732 authored by Alexis Campailla's avatar Alexis Campailla Committed by Rod Vagg
Browse files

build,win: set env before generating projects



vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
defaults to 'auto' and selects VS 2005.

vcbuild sets the environment in the current shell, so this issue
would manifest itself only on the first invocation of the script
in any given shell windows.

Reviewed-By: default avatarJulien Gilli <jgilli@fastmail.fm>
PR-URL: https://github.com/joyent/node/pull/20109
parent 54d54375
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment