Commit a9791c90 authored by Ben Noordhuis's avatar Ben Noordhuis Committed by Rod Vagg
Browse files

src: make debugger listen on 127.0.0.1 by default

CVE-2018-12120

Backport of 8e7cbe25 to v6.x
Prepared by Sam Roberts <vieuxtech@gmail.com>

Original commit:
  Commit 22720524 ("net: bind to `::` TCP address by default") from
  April 2014 seems to have accidentally changed the default listen
  address from 127.0.0.1 to 0.0.0.0, a.k.a. the "any" address.

  From a security viewpoint it's undesirable to accept debug agent
  connections from anywhere so let's change that back.  Users can
  override the default with the `--debug=<host>:<port>` switch.

  Fixes: https://github.com/nodejs/node/issues/8081
  PR-URL: https://github.com/nodejs/node/pull/8106


Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>

PR-URL: https://github.com/nodejs-private/node-private/pull/148


Reviewed-By: default avatarBen Noordhuis <info@bnoordhuis.nl>
Reviewed-By: default avatarSam Roberts <vieuxtech@gmail.com>
Reviewed-By: default avatarMatteo Collina <matteo.collina@gmail.com>
Reviewed-By: default avatarRod Vagg <rod@vagg.org>
parent 4beba664
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment