child_process: minor cleanup of internals

This commit removes self = this style assignments and replaces
some array iteration functions with a simpler for loop.

PR-URL: https://github.com/nodejs/node/pull/12348


Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>