Commit a1da024c authored by Trevor Norris's avatar Trevor Norris Committed by Bert Belder
Browse files

node, async-wrap: remove MakeDomainCallback

C++ won't deoptimize like JS if specific conditional branches are
sporadically met in the future. Combined with the amount of code
duplication removal and simplified maintenance complexity, it makes more
sense to merge MakeCallback and MakeDomainCallback.

Additionally, type casting in V8 before verifying what that type is will
cause V8 to abort in debug mode if that type isn't what was expected.
Fix this by first checking the v8::Value before casting.

PR-URL: https://github.com/joyent/node/pull/8110


Signed-off-by: default avatarTrevor Norris <trev.norris@gmail.com>
Reviewed-by: default avatarFedor Indutny <fedor@indutny.com>
Reviewed-by: default avatarAlexis Campailla <alexis@janeasystems.com>
Reviewed-by: default avatarJulien Gilli <julien.gilli@joyent.com>
parent 5d17b16e
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment