Commit 8d6b74d3 authored by woodfairy's avatar woodfairy Committed by Node.js GitHub Bot
Browse files

build: enable ASLR (PIE) on OS X

After conducting several benchmarks, I noticed performance losses of
5-10%. As OS X is not a performance critical platform, as already
mentioned by @bnoordhuis, I have removed the -no_pie flag at least for
this platform. I'd love to enable PIE for other platforms if the 5-10%
speed loss is not too high. I would be happy to hear your opinion on
this.

Refs: https://github.com/nodejs/node/issues/33425

PR-URL: https://github.com/nodejs/node/pull/35704


Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
Reviewed-By: default avatarRichard Lau <rlau@redhat.com>
Reviewed-By: default avatarDavid Carlier <devnexen@gmail.com>
Reviewed-By: default avatarRich Trott <rtrott@gmail.com>
Reviewed-By: default avatarMatteo Collina <matteo.collina@gmail.com>
parent fff25a07
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment