Commit 89e4b36e authored by Anna Henningsen's avatar Anna Henningsen Committed by Rich Trott
Browse files

src: make `CompiledFnEntry` a `BaseObject`

In particular:

- Move the class definition to the relevant header file,
  i.e. `node_contextify.h`.
- Make sure that class instances are destroyed on
  `Environment` teardown.
- Make instances of the key object traceable in heap dumps. This is
  particularly relevant here because our C++ script → map key mapping
  could introduce memory leaks when the import function metadata refers
  back to the script in some way.

Refs: https://github.com/nodejs/node/pull/28671

PR-URL: https://github.com/nodejs/node/pull/28782


Reviewed-By: default avatarGus Caplan <me@gus.host>
Reviewed-By: default avatarRich Trott <rtrott@gmail.com>
parent 31178994
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment