Commit 889ad35d authored by Richard Lau's avatar Richard Lau Committed by Node.js GitHub Bot
Browse files

build: make build-addons errors fail the build

The `build-addons` makefile target runs `tools/doc/addon-verify.js` and
then uses `touch` to update a timestamp file. Unconditionally calling
`touch` was losing the exit code from `tools/doc/addon-verify.js` so
any errors produced by that script were not failing the build.

PR-URL: https://github.com/nodejs/node/pull/38983


Reviewed-By: default avatarAntoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: default avatarMichael Dawson <midawson@redhat.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent d615aeb7
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment