Unverified Commit 861d3f7a authored by Fedor Indutny's avatar Fedor Indutny Committed by Anna Henningsen
Browse files

crypto: fix assertion caused by unsupported ext

`X509V3_EXT_print` can return value different from `1` if the X509
extension does not support printing to a buffer. Instead of failing with
an unrecoverable assertion - replace the relevant value in the hashmap
with a JS null value.

Fixes: https://hackerone.com/reports/746733

PR-URL: https://github.com/nodejs-private/node-private/pull/175


Reviewed-By: default avatarSam <Roberts &lt;vieuxtech@gmail.com>
Reviewed-By: default avatarMatteo <Collina &lt;matteo.collina@gmail.com>
Reviewed-By: default avatarBen <Noordhuis &lt;info@bnoordhuis.nl>
Reviewed-By: default avatarRich <Trott &lt;rtrott@gmail.com>
Reviewed-By: default avatarAnna <Henningsen &lt;anna@addaleax.net>
Reviewed-By: default avatarShelley <Vohr &lt;codebytere@gmail.com>
Reviewed-By: default avatarTobias <Nießen &lt;tniessen@tnie.de>
Reviewed-By: default avatarGireesh <Punathil &lt;gpunathi@in.ibm.com>
Reviewed-By: default avatarBeth <Griggs &lt;Bethany.Griggs@uk.ibm.com>
Reviewed-By: default avatarMichael <Dawson &lt;michael_dawson@ca.ibm.com>
parent fe397578
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment