Unverified Commit 855dabd6 authored by Joyee Cheung's avatar Joyee Cheung Committed by Anna Henningsen
Browse files

src: call CleanupHandles in FreeEnvironment

CleanupHandles() has not been called in our own code base anymore
after the v8 debug agent has been removed. It used to be in the
~Environment() destructor but then removed to avoid firing other
events after the exit event, given that we were not going to
clean up handles for the one environment per process setup.
Call it in FreeEnvironment so that embedders can clean up
the handles in the loop when creating multiple environments.

PR-URL: https://github.com/nodejs/node/pull/19319


Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
Reviewed-By: default avatarJackson Tian <shyvo1987@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent c6ae8a28
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment