Unverified Commit 76ecec20 authored by Anna Henningsen's avatar Anna Henningsen
Browse files

buffer: fix crash for invalid index types

2555cb4a introduced a crash
when a non-number value was passed to `ParseArrayIndex()`.

We do not always have JS typechecking for that in place, though.
This returns back to the previous behavior of coercing values
to integers, which is certainly questionable.

Refs: https://github.com/nodejs/node/pull/22129
Fixes: https://github.com/nodejs/node/issues/23668

PR-URL: https://github.com/nodejs/node/pull/25154


Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent 0043c6f5
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment