Unverified Commit 5512fff6 authored by Anna Henningsen's avatar Anna Henningsen
Browse files

src: remove `kFlagNoShutdown` flag

This was originally introduced in 3446ff41, in order to fix
a hard crash. However, since the libuv 1.18.0 update, that hard
crash is gone, and since f2b9805f we do not throw an
error in JS land anymore either, rendering the flag unnecessary.

Also, the original test that checked this condition was added
to `test/parallel/`. Since that typically runs without a TTY stdin,
a duplicate test is being added to the pseudo-tty test suite
in this commit.

Refs: https://github.com/nodejs/node/commit/3446ff417ba1e11d35d1661b8788eac5af029360
Refs: https://github.com/nodejs/node/commit/f2b9805f85d3ff770892b37944a0890e0e60ca78
Refs: https://github.com/libuv/libuv/commit/0e2814179c9903423d058b095e84f48fcfb8f3d1
PR-URL: https://github.com/nodejs/node/pull/20388


Reviewed-By: default avatarAnatoli Papirovski <apapirovski@mac.com>
Reviewed-By: default avatarRuben Bridgewater <ruben@bridgewater.de>
Reviewed-By: default avatarBen Noordhuis <info@bnoordhuis.nl>
parent 4740e5dd
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment