Commit 506c7fd4 authored by Ben Noordhuis's avatar Ben Noordhuis
Browse files

test: fix infinite spawn cycle in stdio test

Fix parallel/test-stdio-closed introduced in commit b5f25a96 ("src:
ensure that file descriptors 0-2 are valid") to not keep spawning
child processes ad infinitum.

The test spawns itself as a child process but a missing return statement
made the child process spawn itself again, and again, and again.

It went unnoticed for some time because the child process exits almost
immediately afterwards, i.e. it didn't fill up the process table.  The
observable effect was an iojs process that was quietly consuming CPU
cyles in the background with a PID that was constantly changing.

Refs: https://github.com/iojs/io.js/pull/938
PR-URL: https://github.com/iojs/io.js/pull/948


Reviewed-By: default avatarFedor Indutny <fedor@indutny.com>
parent 87e4bfd5
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment