Unverified Commit 4afcd552 authored by Chengzhong Wu's avatar Chengzhong Wu Committed by legendecas
Browse files

node-api: make reference weak parameter an indirect link to references

As the cancellation of second pass callbacks are not reachable from the
current v8 API, and the second pass callbacks are scheduled with
NodePlatform's task runner, we have to ensure that the weak parameter
holds indirect access to the v8impl::Reference object so that the object
can be destroyed on addon env teardown before the whole node env is able
to shutdown.

PR-URL: https://github.com/nodejs/node/pull/38000


Reviewed-By: default avatarMichael Dawson <midawson@redhat.com>
Reviewed-By: default avatarGabriel Schulhof <gabriel.schulhof@intel.com>
parent d4f33f10
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment