Unverified Commit 420d56c2 authored by Ben Noordhuis's avatar Ben Noordhuis Committed by Myles Borins
Browse files

src: don't touch js object in Http2Session dtor

Don't try to update the internal field pointer of the JS object in the
destructor.

The garbage collector invokes the destructor when the object is
collected and is not necessarily in a valid state anymore.

Backport-PR-URL: https://github.com/nodejs/node/pull/19185
PR-URL: https://github.com/nodejs/node/pull/18656


Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
Reviewed-By: default avatarJoyee Cheung <joyeec9h3@gmail.com>
parent f89f659d
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment