Commit 3f52ce35 authored by Rich Trott's avatar Rich Trott
Browse files

test: fix flaky test-https-timeout

Remove `setTimeout()` in test and instead rely on `common.mustCall()` on
a `timeout` event handler.

The test was flaky on CI. The flakiness was replicable by running the
test under load. This version, in contrast, is robust under load.

Took the opportunity to do some `var` -> `const` while refactoring.

PR-URL: https://github.com/nodejs/node/pull/10404


Reviewed-By: default avatarSantiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarItalo A. Casas <me@italoacasas.com>
Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
parent 2bba2d21
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment