Commit 37ee43ef authored by Trevor Norris's avatar Trevor Norris Committed by Alexis Campailla
Browse files

test: improve performance of stringbytes test

String concatenation in the assert messages has drastic impact on test
runtime. Removal of these messages is unlikely to affect debugging if
any breaking changes are made.

Previous time to run:

    $ time ./iojs test/parallel/test-stringbytes-external.js

    real    0m2.321s
    user    0m2.256s
    sys     0m0.092s

With fix:

    $ time ./iojs test/parallel/test-stringbytes-external.js

    real    0m0.518s
    user    0m0.508s
    sys     0m0.008s

PR-URL: https://github.com/nodejs/node/pull/2544


Reviewed-By: default avatartrevnorris - Trevor Norris <trev.norris@gmail.com>
Reviewed-By: default avatarthefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
parent 5169b516
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment