Commit 2742f386 authored by Joyee Cheung's avatar Joyee Cheung Committed by Rich Trott
Browse files

test: use Worker scope in WPT

Previously, we use the Window scope by default in our WPT test
runner. When one of the test fails, the WPT harness would try to
use document.getElementsByTagName() etc. to display the failure,
which is not going to work for us.

This patch switches the scope to DedicatedWorker and use our
Worker implementation as a global - this does not test the Worker
implementation per se, just tells the WPT harness to pass the results
back to us via the callbacks we installed and not try to access
a document.

We may still need to use a Window scope when we try to run
.window.js tests in the future, but for now we only run .any.js
tests so it's fine to use a worker scope by default.

PR-URL: https://github.com/nodejs/node/pull/24410


Reviewed-By: default avatarGus Caplan <me@gus.host>
Reviewed-By: default avatarAnna Henningsen <anna@addaleax.net>
parent 566a694b
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment