Commit 10f251e8 authored by Alexis Campailla's avatar Alexis Campailla Committed by Julien Gilli
Browse files

win: backport set env before generating projects

Backport commit a58b1745

 from branch
v0.12.

Original commit message:

  vcbuild.bat calls python configure before setting GYP_MSVS_VERSION,
  so SelectVisualStudioVersion (tools\gyp\pylib\gyp\MSVSVersion.py)
  defaults to 'auto' and selects VS 2005.

  vcbuild sets the environment in the current shell, so this issue
  would manifest itself only on the first invocation of the script
  in any given shell windows.

Reviewed-By: default avatarJulien Gilli <jgilli@fastmail.fm>
  PR-URL: https://github.com/joyent/node/pull/20109



Conflicts:
	vcbuild.bat

Reviewed-By: default avatarJoão Reis <reis@janeasystems.com>
PR-URL: https://github.com/joyent/node/pull/25569
parent 7df57703
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment