inspector: add virtual destructor to WorkerDelegate
Currently the WorkerDelegate class has a virtual function
but no virtual destructor which means that if delete is called on a
WorkerDelegate pointer to a derived instance, the derived destructor
will not get called.
The following warning is currently being printed when
compiling:
warning: delete called on 'node::inspector::WorkerDelegate' that is
abstract but has non-virtual destructor [-Wdelete-non-virtual-dtor]
delete __ptr;
^
This commit adds a virtual destructor.
PR-URL: https://github.com/nodejs/node/pull/23215
Reviewed-By:
Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By:
Colin Ihrig <cjihrig@gmail.com>
Reviewed-By:
Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By:
Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By:
Anna Henningsen <anna@addaleax.net>
Reviewed-By:
James M Snell <jasnell@gmail.com>
parent
a8c14580
Please register or sign in to comment