Commit 0f8e63ca authored by Evan Lucas's avatar Evan Lucas
Browse files

dns: throw a TypeError in lookupService with invalid port

Previously, port was assumed to be a number and would cause an abort in
cares_wrap. This change throws a TypeError if port is not a number
before we actually hit C++.

Fixes: https://github.com/nodejs/node/issues/4837
PR-URL: https://github.com/nodejs/node/pull/4839


Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
Reviewed-By: default avatarRoman Klauke <romaaan.git@gmail.com>
Reviewed-By: default avatarBrian White <mscdex@mscdex.net>
parent 8ba56316
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment