Unverified Commit 04c1fbb0 authored by Ben Noordhuis's avatar Ben Noordhuis Committed by Anna Henningsen
Browse files

net: remove misleading comment

The allowHalfOpen comment was added in commit 8a3befa0 ("net: Refactor
to use streams2") from 2012 but it wasn't true even then as far as I
can tell: Node.js simply always does a shutdown(2) first.

It is true that streams2 withholds the 'end' event when allowHalfOpen
is true but the comment is about a callback that hangs off the 'finish'
event that is emitted after calling `socket.end()`.

PR-URL: https://github.com/nodejs/node/pull/11573


Reviewed-By: default avatarJames M Snell <jasnell@gmail.com>
Reviewed-By: default avatarColin Ihrig <cjihrig@gmail.com>
parent 6aa18aae
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment