Commit 741e941c authored by Nam Cao's avatar Nam Cao Committed by Anup Patel
Browse files

platform: starfive: call starfive_jh7110_inst_init() in pm_reset_init()



The function starfive_jh7110_inst_init() initialize some power
management unit address and clock addresses, needed for the reset
driver. It doesn't do anything else, and also the reset driver doesn't
work without calling this function. Thus, it does not make much sense
that this function is independent from pm_reset_init().

Delete the separate call to starfive_jh7110_inst_init(), and instead
just call this function inside pm_reset_init().

Doing this also fixes another problem: if starfive_jh7110_inst_init()
returns an error code, it gets propagated to final_init() and OpenSBI
hangs. This hang is not necessary, because failures within
starfive_jh7110_inst_init() only mean OpenSBI cannot perform reboot or
shutdown, but the system can still function normally.

Signed-off-by: default avatarNam Cao <namcao@linutronix.de>
Tested-by: default avatarMinda Chen <minda.chen@starfivetech.com>
Reviewed-by: default avatarAnup Patel <anup@brainfault.org>
parent 3edf0447
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment