* Tweak remote bitbang code.

Reducing the number of times we perform two read(2) calls in a row.

Change-Id: If8f326d4f2c4ece979af427a2213f77b9024e6dd

* Remove unnecessary block/non-block changes.

Change-Id: I095717d19483fb0daf2e6c264cab1134fd5f84cd
Signed-off-by: Tim Newsome <tim@sifive.com>

* Refactor, creating remote_bitbang_recv_buf_empty()

Change-Id: Ib678bda990b3e224abe8faec2c48401b08cf4698

* Refactor available space computation.

Creating remote_bitbang_recv_buf_contiguous_available_space() which has
a ridiculously long name but I don't see anything much better without
replacing the remote_bitbang prefix throughout the file.

Change-Id: I5d241b872a50a80a2df69fa60635207496484b7d

* Use TCP_NODELAY on remote bitbang socket.

`make` in riscv-tests/debug went from 2m40s to 1m20s.

Change-Id: I0fa9f0007774626f2306d554397877c2117e8bdb
Signed-off-by: Tim Newsome <tim@sifive.com>

* Fix build on Windows.

Change-Id: I91f3ddee794e8540c5e871ead3c09583c272bd34
Signed-off-by: Tim Newsome <tim@sifive.com>

Otherwise they don't happen if somebody makes a PR from a different
fork.

Change-Id: Ic09eb8a556e2dfbc0900e3df9f07cf7aff3d5309
Signed-off-by: Tim Newsome <tim@sifive.com>

Expose them in the virtual priv register, and set them on mcontrol6
hardware triggers. I have no good way to test this right now, so it's
all untested. But this change doesn't break anything, at least.

Change-Id: I0343a6169a0b2b1f0cc0abf687c6bdc560d99b1b
Signed-off-by: Tim Newsome <tim@sifive.com>

Fixes #632.

Change-Id: Ic884823faf67749f1ac8fbd91fe67ff9ebdd8fd0
Signed-off-by: Tim Newsome <tim@sifive.com>

* Copy snapshot workflow from mainline.

Travis died. We need something that checks OpenOCD builds.

Change-Id: I7c018caaa3a13884fc526733271697bc90edc891
Signed-off-by: Tim Newsome <tim@sifive.com>

* Run checkpatch like we used to do with travis.

Nervous about this because upstream often messes things up.

Change-Id: I0ca0229ea2bd4422d7ffe4800e8861acc716cf56
Signed-off-by: Tim Newsome <tim@sifive.com>

* Fetch more, install filterdiff.

Change-Id: I8cca61c5adc91b845619f2cc89accbb5217ce73a
Signed-off-by: Tim Newsome <tim@sifive.com>

* It's patchutils, not filterdiff.

Change-Id: I2afe78bc4153462283a61571e15ee147f9f20b10
Signed-off-by: Tim Newsome <tim@sifive.com>

* Fetch more revisions.

Change-Id: Ieb5269494721f7b78d93d67c502203f1b1fbbba7
Signed-off-by: Tim Newsome <tim@sifive.com>

* gnulib no longer exists.

Change-Id: I97fc797c99f19f6b504952f7cb9c7072181c1e72
Signed-off-by: Tim Newsome <tim@sifive.com>

* Working on Linux build.

Change-Id: I6b70fbf5bd2dbb5f1540d0d929310b29b312566e
Signed-off-by: Tim Newsome <tim@sifive.com>

* Don't actually publish any artifacts.

Change-Id: Ic363744e0530288f3f78268d1becfbfb6b47b505
Signed-off-by: Tim Newsome <tim@sifive.com>

* Add 32-bit build?

Change-Id: I44866e0da539db7b8e3bd0536d305bee0595a301
Signed-off-by: Tim Newsome <tim@sifive.com>

* Fix environment.

Change-Id: I19c3ef2cc886350db243a07185d2441ca9328dfa
Signed-off-by: Tim Newsome <tim@sifive.com>

* Fix syntax error.

Change-Id: I80ba08d9929d4c2f0e57b393b6b53462202f5bce
Signed-off-by: Tim Newsome <tim@sifive.com>

* More syntax error.

Change-Id: I24c5270683626b7007f9c100f1a36c9fa28a3405
Signed-off-by: Tim Newsome <tim@sifive.com>

* Shooting in the dark trying to fix problem.

Change-Id: Iecb3dc67ec6a0b932167b65dd0a5b82da9a1518f
Signed-off-by: Tim Newsome <tim@sifive.com>

* More syntax fixing.

Change-Id: I01f014f38e742b9a6c0d7c2e5b31058536572506
Signed-off-by: Tim Newsome <tim@sifive.com>

* Install clang.

Signed-off-by: Tim Newsome <tim@sifive.com>
Change-Id: I1d6828554ade149f7319f0797238a4e23f073a25

* Store config.log

Change-Id: I8275341de2c042ef32c6d57687c420b6dc53c8ab
Signed-off-by: Tim Newsome <tim@sifive.com>

* Install gcc-multilib

Change-Id: I08f233f58f3a4cbc89ae5dd0314d99319bf5724c
Signed-off-by: Tim Newsome <tim@sifive.com>

* Check final executable.

Intentionally supposed to fail.

Change-Id: I003dba85e766e3cf3ef4d6925d96f5b09a9fe80f
Signed-off-by: Tim Newsome <tim@sifive.com>

* All done!

Change-Id: I37ed2142082fdbce01157e0989c4e2122229abb7
Signed-off-by: Tim Newsome <tim@sifive.com>

From upstream

Change-Id: Ib8a1d0ad66a74b4bc85fd70b4cd82d1ccc200e56
Signed-off-by: Tim Newsome <tim@sifive.com>

Conflicts:
	src/flash/nor/nrf5.c
	src/flash/nor/xcf.c
	src/jtag/drivers/remote_bitbang.c
	src/rtos/FreeRTOS.c
	src/rtos/zephyr.c
	src/target/cortex_a.c
	src/target/cortex_a.h
	src/target/cortex_m.c
	src/target/riscv/riscv.c

Change-Id: I80b0a33b40c06c229d20fe34e04d6322da83326d

The stlink driver incorrectly uses a NULL pointer for libusb's
struct libusb_context.
The correct value to be used is local in libusb_helper.c.

Move in the helper file, in a wrapper function, the only call that
requires the above value, and let stlink driver to use this
wrapper.

This issue has not triggered any visible problem until a code
refactoring [1] in libusb has made OpenOCD crashing on Windows and
on MacOS.

Change-Id: Id1818c8af7cf0d4d17dfa1d22aad079da01ef740
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Fixes: https://sourceforge.net/p/openocd/tickets/308/
Fixes: https://github.com/libusb/libusb/issues/928/
Fixes: 42d8fa89 ("stlink_usb: Submit multiple USB URBs at once to improve performance")
Link: [1] https://github.com/libusb/libusb/commit/32a22069428c


Reported-by: Andrzej Sierżęga <asier70@gmail.com>
Co-developed-by: Andrzej Sierżęga <asier70@gmail.com>
Co-developed-by: Xiaofan Chen <xiaofanc@gmail.com>
Reviewed-on: http://openocd.zylin.com/6331


Tested-by: jenkins
Reviewed-by: Marc Schink <dev@zapb.de>
Reviewed-by: Xiaofan <xiaofanc@gmail.com>
Reviewed-by: Andrzej Sierżęga <asier70@gmail.com>
Reviewed-by: Oleksij Rempel <linux@rempel-privat.de>
Reviewed-by: Andreas Fritiofson <andreas.fritiofson@gmail.com>

The current implementation fails due to the assert() statements in
get_stm32l4_rev_str() and get_stm32l4_bank_type_str(). Rearrange the
code in order to fix the problem.

Change-Id: If19c648dec8ddd3ef2fb801150114104b34c3bf2
Signed-off-by: Marc Schink <dev@zapb.de>
Fixes: 64c2e03b ("flash/nor: improved API of flash_driver.info & fixed buffer overruns")
Reviewed-on: http://openocd.zylin.com/6326


Tested-by: jenkins
Reviewed-by: Jan Matyas <matyas@codasip.com>
Reviewed-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I8027178b6e771753775514a8641a050c6e63a1d5
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6321


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

The HLA target is not anymore used by ST-Link only, but required
by Nu-Link and TI-ICDI too.

Rename the flag 'stlink' as 'is_hla_target'.

Change-Id: Id2ee2c0a1e8bf1f1e899f7a560140c34eefeeee5
Signed-off-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-on: http://openocd.zylin.com/6206


Tested-by: jenkins
Reviewed-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>

Change-Id: Ic18973d3e90d74c211b48627bdaac4cf3357b682
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6324


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

This fixes 'dead assignment' bugs identified by the clang static analyzer.

Change-Id: I140ed55f0043e06a533f45f50a36887614585b04
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6323


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Add board configuration for Renesas Falcon board based on the R8A779A0 V3U SoC.

Change-Id: If8369f2e2b97dfea9ccbee2c9b916ef7094f9b92
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Reviewed-on: http://openocd.zylin.com/6315


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

The V3U SoC is unique in that it now has 8x CA76 and CR52,
while the previous SoCs had CA57/CA53/CR7 . This can still
be handled without too complex modifications to the gen3
configuration file, so add the logic to handle it there.

Change-Id: I7ab33eacc1fd379d369988d3d6690d2e82346c7e
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Reviewed-on: http://openocd.zylin.com/6314


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

On SMP Renesas R-Car Gen2/Gen3 systems, select the boot core as
the default target using the 'targets' command. This way, the
user can start debugging code running on the boot core without
having to switch to the boot core by explicitly invoking 'targets'
command first, since it is likely the debugged code will run on
the boot core. Note that most of the code is already in place, it
was just not used, so this is more of a fix to make the original
intention work.

Change-Id: I727808adce617c1d9ebd6ffa34f60f5882cdae60
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Reviewed-on: http://openocd.zylin.com/6313


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I5f4ab5243104df41031950682f688f2448a09b17
Signed-off-by: Jesse Sheridan <jesse.sheridan@gmail.com>
Reviewed-on: http://openocd.zylin.com/6322


Tested-by: jenkins
Reviewed-by: Tim Newsome <tim@sifive.com>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

* https://store.digilentinc.com/nexys-video-artix-7-fpga-trainer-board-for-multimedia-applications/
* https://reference.digilentinc.com/_media/nexys-video:nexys_video_sch.pdf



The Nexys Video board has FTDI FT2232 whose channel B is connected to
Artix-7 FPGA's JTAG pins, and can be supported by OpenOCD's
ftdi interface. Tested to be working fine on real hardware.

Change-Id: I2996166dc8c2b6c08a9390958adfcdec8fc2bd37
Signed-off-by: Rohit Singh <rohit91.2008@gmail.com>
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/4364


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

* Get closer to mainline.

.gitignore is left-over from when I tried gnulib.
The other changes were made to make the checker happy, and I don't care
to upstream these.

Change-Id: I9168b3b80d89a142a46eb1906a7640fc02552743
Signed-off-by: Tim Newsome <tim@sifive.com>

* checkpatch requires this.

Why isn't this correct in upstream?

Change-Id: I3810e26e591450b6d7425368a39750405f4d8bfa
Signed-off-by: Tim Newsome <tim@sifive.com>

* Appears unnecessary.

I added this as part of FreeRtos work, but all those tests pass just
fine even without this change. I suspect I added it in an attempt to fix
something and it turned out to be unnecessary. Reverting because I don't
know how to justify upstreaming this.

Change-Id: I1e4d0af9d2b4d62c79969216929702463bf0c815
Signed-off-by: Tim Newsome <tim@sifive.com>

Fix merge

Should result in no changes, but now I will probably merge the PR so git
knows the merge happened. (I accidentally did a squash merge before.)

Change-Id: I939492c0b1ef181ccb3f3158e5fc3a0626a60412

Fixes bug #202

Change-Id: I855a1b8570af71379891634f405b4cc726917cb2
Signed-off-by: R. Diez <rdiezmail-openocd@yahoo.de>
Reviewed-on: http://openocd.zylin.com/6272


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I8cf679190d6911de2dee181879c8895b55466835
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6296


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: Ie913630c6ab3b600532d8e375e2fc11ca202cf5e
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6295


Tested-by: jenkins
Reviewed-by: Jan Matyas <matyas@codasip.com>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: Ie02a112c0339ae5d3b3763483e493370b487be98
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6294


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

In these drivers we read CPUID to check the Cortex-M PARTNO,
but now the PARTNO is stored in struct cortex_m_common.core_info.

Change-Id: I5bb3b95210ab6e23b8e1252686dd81015740bf68
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6240


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Rework core detection by adding cortex_m_partno enum to detect all CPUs
using the same method.

Instead of checking the core PARTNO then assign the arch, use the stored
information within cortex_m parts[] with the flags inside which can help
simplifying a bit the cortex_m_examine code.

This change fixes:
 - the Cortex-M1 detection as ARMv6-M Core (was managed as ARMv7-M)
 - the displayed CPU name for Cortex-M0+ (was displayed Cortex-M0)

Change-Id: I40b6e03f7cf3664c85e297adfc25323196dfe90b
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6233


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

In target/arm.h the struct arm do contain 3 flags to retain architecture
version for some tweaks.
The proposal is to have only one enumerated flag 'arch' for the same purpose.

Change-Id: Ia5d5accfed8158ca21eb54af2fdea8e36f0266ae
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6229


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

atoi used but stdlib.h wasn't included.
Also, include statements reordered alphabetically.

Change-Id: I7fcdbf3fa940a172204ec811399e1a7fdebdc979
Signed-off-by: Diego Herranz <diegoherranz@diegoherranz.com>
Reviewed-on: http://openocd.zylin.com/6312


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I9dd67ac3e8cd5dd9cdeffce56020b387a8f298fa
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6316


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I4a0c401a325e57ba5d4d93d83b7e6b71a4d0865e
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6064


Tested-by: jenkins
Reviewed-by: Marc Schink <dev@zapb.de>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: I6a991899bb178ee0c6b41870a45d0a9439d9dc1e
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6063


Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Tested-by: jenkins

Change-Id: I0f3fffa8cf1746569f6acce0233e9544d3862f51
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6062


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

1) The API of "info" callback in "struct flash_driver" has been
improved. Fixed buffers for strings

2) Removed the calls to snprintf() from the flash_driver.info
implementations. Many of them were used in an unsafe manner
(buffer overruns were possible).

Change-Id: I42ab8a8018d01f9af43c5ba49f650c3cb5d31dcb
Signed-off-by: Jan Matyas <matyas@codasip.com>
Reviewed-on: http://openocd.zylin.com/6182


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

Change 7dd323b2

 reduced remote bitbang performance a lot. This change
gets most of that performance back again, by reintroducing a write
buffer.

Performance numbers collected using DebugBreakpoint test from
riscv-tests/debug against a single 64-bit spike (RISC-V simulator)
instance. (Ubuntu 20.04.2, AMD Ryzen 5 3600)
Before Windows support was added: 3.09s
After Windows support was added: 12.67s
After this change: 4.69s

Signed-off-by: Tim Newsome <tim@sifive.com>
Change-Id: I72ff4912cbbf316a30ef065e5b8f461a555f06cc
Reviewed-on: http://openocd.zylin.com/6283


Tested-by: jenkins
Reviewed-by: Jan Matyas <matyas@codasip.com>
Reviewed-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

Change-Id: Ieea3dc05809263aa0eba5125d52fef3fe77e9c5a
Signed-off-by: Marc Schink <dev@zapb.de>
Reviewed-on: http://openocd.zylin.com/6289


Tested-by: jenkins
Reviewed-by: Antonio Borneo <borneo.antonio@gmail.com>

* cortex_m: use unsigned int for FPB and DWT quantifiers

related quantifiers are:
 - fp_num_lit
 - fp_num_code
 - dwt_num_comp
 - dwt_comp_available

Change-Id: I07dec2d4aa21bc0e580be0d9fd0a6809f876c2a8
Signed-off-by: Tarek BOCHKATI <tarek.bouchkati@gmail.com>
Reviewed-on: http://openocd.zylin.com/6185


Tested-by: jenkins
Reviewed-by: Tomas Vanek <vanekt@fbl.cz>

* telnet: allow hiding selected commands during auto-completion

We have TCL procedure and commands that we do not want to show in
the list of auto-completion. E.g. TCL wrappers for deprecated
commands, internal procedures that are not supposed to be exposed
to user, or even commands that the user decides to hide.

Create a TCL procedure to be called by telnet auto-complete code
in place of the hard-coded TCL command. The procedure will run the
same command and will filter-out the unwanted command names.

Initialize the list of commands to be filtered-out with the name
of the TCL procedure above, as ...

Change-Id: I4f2667db91f84f07af354691aac5d4c9e3aea3fa
Signed-off-by: Tim Newsome <tim@sifive.com>