Skip to content
GitLab
  1. Oct 18, 2022
  3. Oct 13, 2022
    • Ralf W. Grosse-Kunstleve's avatar
      Minor `py::capsule` cleanup. No functional change. (#4238) · 964c4997
      Ralf W. Grosse-Kunstleve authored 
      Use `PyCapsule_Destructor` (part of the stable Python ABI) instead of spelling out the C `typedef`.

The deprecation message is misleading. Replace with a message pointing to another existing ctor.

Background: According to @wjakob the original motivation for deprecating the ctor (in PR #752) was to hide Python C API details, but PR #902 brought those back with a new ctor, it cannot be avoided. Having a `PyCapsule_Destructor` or a `void (*destructor)(void *)` are two separate and valid use cases.
      964c4997
    • Aaron Gokaslan's avatar
      chore: Optimize iterator advance() call (#4237) · 8781daf6
      Aaron Gokaslan authored
      8781daf6
  5. Oct 12, 2022
  7. Oct 11, 2022
  9. Oct 10, 2022
    • Ralf W. Grosse-Kunstleve's avatar
      Reproducer and fix for issue encountered in smart_holder update. (#4228) · da104a9e
      Ralf W. Grosse-Kunstleve authored 
      * Reproducer for issue encountered in smart_holder update.

* clang-tidy compatibility (untested).

* Add `enable_if_t` to workaround.

* Bug fix: Move `PYBIND11_USING_WORKAROUND_FOR_CUDA_11_4_THROUGH_8` determination to detail/common.h

So that it actually is defined in pybind11.h

* Try using the workaround (which is nicer than the original code) universally.

* Reduce reproducer for CUDA 11.7 issue encountered in smart_holder update.

This commit tested in isolation on top of current master + first version of reproducer (62311eb431849d135a5db84f6c75ec390f2ede7c).

Succeeds with Debian Clang 14.0.6 C++17 (and probably all other compilers).

Fails for CUDA 11.7:

```
cd /build/tests && /usr/local/cuda/bin/nvcc -forward-unknown-to-host-compiler -Dpybind11_tests_EXPORTS -I/mounted_pybind11/include -isystem=/usr/include/python3.10 -g --generate-code=arch=compute_52,code=[compute_52,sm_52] -Xcompiler=-fPIC -Xcompiler=-fvisibility=hidden -Werror all-warnings -std=c++17 -MD -MT tests/CMakeFiles/pybind11_tests.dir/test_class.cpp.o -MF CMakeFiles/pybind11_tests.dir/test_class.cpp.o.d -x cu -c /mounted_pybind11/tests/test_class.cpp -o CMakeFiles/pybind11_tests.dir/test_class.cpp.o
/mounted_pybind11/tests/test_class.cpp(53): error: more than one instance of overloaded function "pybind11::class_<type_, options...>::def [with type_=test_class::pr4220_tripped_over_this::Empty0, options=<>]" matches the argument list:
            function template "pybind11::class_<test_class::pr4220_tripped_over_this::Empty0> &pybind11::class_<type_, options...>::def(const char *, Func &&, const Extra &...) [with type_=test_class::pr4220_tripped_over_this::Empty0, options=<>]"
/mounted_pybind11/include/pybind11/pybind11.h(1557): here
            function template "pybind11::class_<test_class::pr4220_tripped_over_this::Empty0> &pybind11::class_<type_, options...>::def(const T &, const Extra &...) [with type_=test_class::pr4220_tripped_over_this::Empty0, options=<>]"
/mounted_pybind11/include/pybind11/pybind11.h(1586): here
            argument types are: (const char [8], <unknown-type>)
            object type is: pybind11::class_<test_class::pr4220_tripped_over_this::Empty0>

1 error detected in the compilation of "/mounted_pybind11/tests/test_class.cpp".
```
      da104a9e
  11. Oct 08, 2022
  13. Oct 07, 2022
  15. Oct 05, 2022
  17. Oct 04, 2022
  19. Sep 27, 2022
  21. Sep 26, 2022
  23. Sep 22, 2022
  25. Sep 21, 2022
  27. Sep 20, 2022
  29. Sep 15, 2022
  31. Sep 13, 2022
  33. Sep 07, 2022
  35. Aug 30, 2022
  37. Aug 25, 2022
  39. Aug 24, 2022
    • Brad Messer's avatar
      Words matter updates (#4155) · a48ec3e8
      Brad Messer authored 
      * Remove sanity check from code base.

* Use main over master.

* Better alternative that doesn't collide with language keywords/frequent usage words.
      a48ec3e8
  41. Aug 22, 2022
  43. Aug 21, 2022
  45. Aug 12, 2022
  47. Aug 09, 2022
  49. Aug 08, 2022
  51. Aug 05, 2022
  53. Aug 03, 2022