Unverified Commit f47f1edf authored by Aaron Gokaslan's avatar Aaron Gokaslan Committed by GitHub
Browse files

Fix #3812 and fix const of inplace assignments (#4065)



* Fix #3812 and fix const of inplace assignments

* Fix missing tests

* Revert operator overloading changes

* calculate answer first for tests

* Simplify tests

* Add more tests

* Add a couple more tests

* Add test_inplace_lshift, test_inplace_rshift for completeness.

* Update tests

* Shortcircuit on self assigment and address reviewer comment

* broaden skip for self assignment

* One more reviewer comment

* Document opt behavior and make consistent

* Revert unnecessary change

* Clarify comment

Co-authored-by: default avatarRalf W. Grosse-Kunstleve <rwgk@google.com>
parent ef7d971e
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment