Unverified Commit aa982e13 authored by Boris Staletic's avatar Boris Staletic Committed by GitHub
Browse files

Small fixes in numpy.h (#2293)

- `PyArray_NewFromDescr_` should have been using `Py_intptr_t const *`
  - https://github.com/numpy/numpy/blob/18a6e3e505ee416ddfc617f3e9afdff5a031c2c2/numpy/core/src/multiarray/ctors.h#L5-L8
- `PyArray_GetArrayParamsFromObject_` should be using `NPY_BOOL`
  - https://github.com/numpy/numpy/blob/18a6e3e505ee416ddfc617f3e9afdff5a031c2c2/numpy/core/src/multiarray/ctors.c#L1350-L1355
  - https://docs.scipy.org/doc/numpy-1.13.0/reference/c-api.dtype.html#c.npy_bool
- `PyArray_DescrNewFromType` is at offset 96
  - https://github.com/numpy/numpy/blob/36e017194c32a53cf2965a513243cb3c348095df/numpy/core/code_generators/numpy_api.py#L141
- `array_t` constructor that takes a size and a pointer should take `ssize_t`.
  - Fixes #1599
parent fe1392d0
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment